Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] invalid title error on wc #6280

Merged
merged 1 commit into from
Apr 27, 2023
Merged

[FIX] invalid title error on wc #6280

merged 1 commit into from
Apr 27, 2023

Conversation

abretonc7s
Copy link
Contributor

FIX wallet connect v1 integration when title is missing

@abretonc7s abretonc7s added needs-qa Any New Features that needs a full manual QA prior to being added to a release. WalletConnect WalletConnect related issue or bug labels Apr 26, 2023
@abretonc7s abretonc7s requested a review from a team as a code owner April 26, 2023 23:49
@deeeed deeeed mentioned this pull request Apr 26, 2023
Closed
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chrisleewilcox
Copy link
Contributor

fixes https://github.com/MetaMask/mobile-planning/issues/938

andreahaku
andreahaku approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherferreira9 christopherferreira9 added QA in Progress QA has started on the feature. release-6.5.0 Issue or pull request that will be included in release 6.5.0 and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 27, 2023
@christopherferreira9
Copy link
Contributor

Working properly, will still check on the next RC to be sure.

@christopherferreira9 christopherferreira9 added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Apr 27, 2023
@christopherferreira9 christopherferreira9 merged commit 96759c5 into release/6.5.0 Apr 27, 2023
@christopherferreira9 christopherferreira9 deleted the fix/release-65-wc-issue branch April 27, 2023 10:28
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andreahaku andreahaku andreahaku approved these changes

Assignees

@chrisleewilcox chrisleewilcox

@andreahaku andreahaku

@christopherferreira9 christopherferreira9

Labels
QA Passed A successful QA run through has been done release-6.5.0 Issue or pull request that will be included in release 6.5.0 WalletConnect WalletConnect related issue or bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abretonc7s @chrisleewilcox @christopherferreira9 @andreahaku