Automation providers features changes to support De-explorization of Ansible Tower Explorer #21108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-kataria
requested review from
agrare,
bdunne,
Fryguy and
kbrock
as code owners
This was referenced Mar 16, 2021
- Added an alias `ems_automation` to be consistent with Configuration Provider and features/controller/view naming. - Added methods to show count of inventory groups on list view and inventory group name on summary details view.
h-kataria
force-pushed
the
automation_providers_features
branch
from
457f3f2 to
7ea9c2a
Compare
- Updated startpage shortcut entry. - Updated OOTB user roles to access to 3 product features after the Ansible Tower explorer split into 3 individual screens.
h-kataria
force-pushed
the
automation_providers_features
branch
from
7ea9c2a to
c0fdd25
Compare
Fryguy
reviewed
Mar 18, 2021
| @@ -1,2 +1,7 @@ | |||
| class ManageIQ::Providers::AutomationManager::ConfiguredSystem < ::ConfiguredSystem | |||
| virtual_column :inventory_root_group_name, :type => :string | |||
There was a problem hiding this comment.
Assuming inventory_root_group is a relationship, can you add a :uses => :inventory_root_group clause here for performance reasons?
There was a problem hiding this comment.
@Fryguy please re-review
|
@Fryguy can you review this pr? |
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
May 5, 2021
These were added/edited in ManageIQ#21108 and ManageIQ#21076 All other MiqProductFeature has the feature_type field: irb(main):004:0> MiqProductFeature.where(:feature_type => nil).count (0.7ms) SELECT COUNT(*) FROM "miq_product_features" WHERE "miq_product_features"."feature_type" IS NULL => 2 Because this was missing, the sort_by in MiqProductFeature.sort_children was failing with the error below when you try to login as a non-admin user: ``` [----] F, [2021-05-05T12:03:59.696562 ManageIQ#8905:3fcc63630bcc] FATAL -- : Error caught: [ActionView::Template::Error] comparison of Array with Array failed /Users/joerafaniello/Code/manageiq/app/models/miq_product_feature.rb:145:in `sort_by' /Users/joerafaniello/Code/manageiq/app/models/miq_product_feature.rb:145:in `sort_children' /Users/joerafaniello/Code/manageiq/app/models/miq_product_feature.rb:76:in `feature_children' /Users/joerafaniello/Code/manageiq/app/models/miq_user_role.rb:55:in `block in allows_any?' /Users/joerafaniello/Code/manageiq/app/models/miq_user_role.rb:55:in `map' /Users/joerafaniello/Code/manageiq/app/models/miq_user_role.rb:55:in `allows_any?' /Users/joerafaniello/Code/manageiq/app/models/miq_user_role.rb:57:in `allows_any?' /Users/joerafaniello/Code/manageiq/lib/rbac/authorizer.rb:62:in `user_role_allows_any?' /Users/joerafaniello/Code/manageiq/lib/rbac/authorizer.rb:28:in `role_allows?' /Users/joerafaniello/Code/manageiq/lib/rbac/authorizer.rb:6:in `role_allows?' /Users/joerafaniello/Code/manageiq/lib/rbac.rb:29:in `role_allows?' /Users/joerafaniello/Code/manageiq/app/models/user.rb:212:in `role_allows_any?' /Users/joerafaniello/Code/manageiq-ui-classic/app/presenters/menu/section.rb:38:in `visible?' ``` Admin users bypass some of the feature checks so was able to login without issue.
jrafanie
added a commit
to jrafanie/manageiq-schema
that referenced
this pull request
May 25, 2021
The product feature was renamed along with the other de-explorization of ansible tower in: ManageIQ/manageiq#21108 The database migration in ManageIQ#564 handled most of the renames but one feature was missed. This commit handles automation_manager_add_provider => ems_automation_add_provider.
jrafanie
added a commit
to jrafanie/manageiq-schema
that referenced
this pull request
May 25, 2021
The product feature was renamed along with the others for de-explorization of ansible tower in: ManageIQ/manageiq#21108 The database migration in ManageIQ#564 handled most of the renames but one feature was missed. This commit handles automation_manager_add_provider => ems_automation_add_provider.
jrafanie
added a commit
to jrafanie/manageiq-schema
that referenced
this pull request
Jun 8, 2021
The product feature was renamed along with the others for de-explorization of ansible tower in: ManageIQ/manageiq#21108 The database migration in ManageIQ#564 handled most of the renames but one feature was missed. This commit handles automation_manager_add_provider => ems_automation_add_provider.
jrafanie
added a commit
to jrafanie/manageiq-api
that referenced
this pull request
Jul 12, 2021
ManageIQ#1033 was fine on master but relied on a refactoring/rewording of product features and models in ManageIQ/manageiq#21108 and this refactoring did not get backported to lasker. In other words, ems_automation_add_provider doesn't exist in lasker, but automation_manager_add_provider does, so we'll use that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for ManageIQ/manageiq-ui-classic#6819
Data Migration PR
UI PR
Cross Repo PR