-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LASKER] Manual backport 7740 #7752
Conversation
…icable features. For now, we're skipping the verbose warnings for tests that seed some features but not the one the code uses in the assert_privileges call. We'll tackle that in a followup.
Checked commits jrafanie/manageiq-ui-classic@4ee1373~...e765797 with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint spec/controllers/automation_manager_controller_spec.rb
spec/controllers/ems_storage_controller_spec.rb
spec/controllers/miq_ae_customization_controller_spec.rb
spec/controllers/miq_report_controller/dashboards_spec.rb
spec/controllers/pxe_controller_spec.rb
|
I added 2 Lasker commits to fix easy things. See the commit list. This might be hiding actual bugs in the automation manager/configuration manager screens for non-admins. The reason why it's only in this area is there was a refactoring/renaming of many features and screens and we fixed the renamed/refactored areas on master, but haven't on lasker. Keep this is in mind if you navigate in these pages in the UI with a fully seeded database, there could be some pages that are using the wrong feature identifier. Anyway, here's the test failures we're hiding by the last commit:
|
Manual backport of #7740 WITHOUT ca4fec8 since ManageIQ/manageiq#21108 was MASTER only and
ems_automation_manager_show_list
doesn't exist on lasker BUTautomation_manager
does exist so the existing code is fine and that commit is NOT needed on lasker.EDIT:
I added 2 simple lasker only test fixes and 1 application_helper fix that makes it so tests don't have to be so strict to creating features they use in the tests.