Code

[LASKER] Manual backport 7740#7752

Code

Merged

Fryguy merged 18 commits intoManageIQ:laskerManageIQ/manageiq-ui-classic:laskerfrom jrafanie:manual_backport_7740jrafanie/manageiq-ui-classic:manual_backport_7740Copy head branch name to clipboardJun 2, 2021

+68-38

Commits

Commits on Jun 2, 2021

• Don't hide the routes failures

  jrafanie

  committed
  4ee1373

  Copy full SHA for 4ee1373

• Raise an exception calling role_allows with non-existing feature

  jrafanie

  committed
  41a0caf

  Copy full SHA for 41a0caf

• Use correct features for assert_privileges calls

  jrafanie

  committed
  031845d

  Copy full SHA for 031845d

• Allow existing rspec tests to largely pass even when not seeding applicable features.

  Show description for 7c2fa4b
  jrafanie

  committed
  7c2fa4b

  Copy full SHA for 7c2fa4b

• Seed the missing product features needed by the test.

  jrafanie

  committed
  38843ed

  Copy full SHA for 38843ed

• Support running one controller: TEST_CONTROLLER=catalog rspec spec/routes_spec.rb

  jrafanie

  committed
  f2ba51f

  Copy full SHA for f2ba51f

• Reword the exception raised when there are missing features

  jrafanie

  committed
  14517e2

  Copy full SHA for 14517e2

• Change saved report reload to use the new product feature

  jrafanie

  committed
  7576414

  Copy full SHA for 7576414

• Leverage user_with_feature shortcut.

  jrafanie

  committed
  d0d1464

  Copy full SHA for d0d1464

• pxe_image_tag and windows_image_tag aren't yet fully implemented

  jrafanie

  committed
  8fe6347

  Copy full SHA for 8fe6347

• Cleanup superfluous rescue/raise

  jrafanie

  committed
  0e1efb4

  Copy full SHA for 0e1efb4

• Simplify indentations/unnecessary blocks.

  jrafanie

  committed
  aa1695a

  Copy full SHA for aa1695a

• Cleanup the features after routes_spec so you can run normal specs afterwards.

  jrafanie

  committed
  deedc38

  Copy full SHA for deedc38

• Fix policy profile save for new or existing profile.

  jrafanie

  committed
  7de3750

  Copy full SHA for 7de3750

• Fix miq_policy/show failure due to wrong feature id

  jrafanie

  committed
  84990d2

  Copy full SHA for 84990d2

• Lasker: Two features don't exist and aren't needed

  jrafanie

  committed
  5b972d6

  Copy full SHA for 5b972d6

• Lasker: You can't assert_privileges on a feature you don't seed.

  jrafanie

  committed
  70e9f85

  Copy full SHA for 70e9f85

• Lasker: Loosen requirements to seed features properly in test a backport

  jrafanie

  committed
  e765797

  Copy full SHA for e765797