Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add missing feature_type to recently added product features
These were added/edited in ManageIQ#21108 and ManageIQ#21076 All other MiqProductFeature has the feature_type field: irb(main):004:0> MiqProductFeature.where(:feature_type => nil).count (0.7ms) SELECT COUNT(*) FROM "miq_product_features" WHERE "miq_product_features"."feature_type" IS NULL => 2 Because this was missing, the sort_by in MiqProductFeature.sort_children was failing with the error below when you try to login as a non-admin user: ``` [----] F, [2021-05-05T12:03:59.696562 ManageIQ#8905:3fcc63630bcc] FATAL -- : Error caught: [ActionView::Template::Error] comparison of Array with Array failed /Users/joerafaniello/Code/manageiq/app/models/miq_product_feature.rb:145:in `sort_by' /Users/joerafaniello/Code/manageiq/app/models/miq_product_feature.rb:145:in `sort_children' /Users/joerafaniello/Code/manageiq/app/models/miq_product_feature.rb:76:in `feature_children' /Users/joerafaniello/Code/manageiq/app/models/miq_user_role.rb:55:in `block in allows_any?' /Users/joerafaniello/Code/manageiq/app/models/miq_user_role.rb:55:in `map' /Users/joerafaniello/Code/manageiq/app/models/miq_user_role.rb:55:in `allows_any?' /Users/joerafaniello/Code/manageiq/app/models/miq_user_role.rb:57:in `allows_any?' /Users/joerafaniello/Code/manageiq/lib/rbac/authorizer.rb:62:in `user_role_allows_any?' /Users/joerafaniello/Code/manageiq/lib/rbac/authorizer.rb:28:in `role_allows?' /Users/joerafaniello/Code/manageiq/lib/rbac/authorizer.rb:6:in `role_allows?' /Users/joerafaniello/Code/manageiq/lib/rbac.rb:29:in `role_allows?' /Users/joerafaniello/Code/manageiq/app/models/user.rb:212:in `role_allows_any?' /Users/joerafaniello/Code/manageiq-ui-classic/app/presenters/menu/section.rb:38:in `visible?' ``` Admin users bypass some of the feature checks so was able to login without issue.
- Loading branch information