[LASKER] ems_automation_add_provider was from a refactoring on master, not lasker #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManageIQ#1033 was fine on master but relied on a refactoring/rewording of product features and models in ManageIQ/manageiq#21108 and this refactoring did not get backported to lasker. In other words, ems_automation_add_provider doesn't exist in lasker, but automation_manager_add_provider does, so we'll use that.
Fryguy
approved these changes
Jul 12, 2021
agrare
approved these changes
Jul 12, 2021
|
Checked commit jrafanie@8dc1ca1 with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint |
Yeah, I only knew because I was looking at all of these bogus product features that the UI was doing and silently wrongly failing feature checks for non-admin users. Normally, it would make sense to backport simple product feature renames but since these reflected code changes in model names, I think we correctly chose not to backport it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1033 was fine on master but relied
on a refactoring/rewording of product features and models in ManageIQ/manageiq#21108
and this refactoring did not get backported to lasker.
In other words, ems_automation_add_provider doesn't exist in lasker, but
automation_manager_add_provider does, so we'll use that.
cc @agrare