Moved 'Providers' out of Automation/Ansible Tower Explorer #7662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-kataria
changed the title
|
@miq-bot cross_repo_tests manageiq-api, manageiq-ui-classic including manageiq-schema#564, manageiq#21108 |
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Mar 16, 2021
From Pull Request: ManageIQ/manageiq-ui-classic#7662
42 tasks
h-kataria
force-pushed
the
automation_providers
branch
2 times, most recently
from
da12753 to
ff119f4
Compare
h-kataria
changed the title
|
|
When i select some provider and press Policy/Edit tag, i can edit something in that page or press cancel, it is going back to provider summary page instead of list view. I am not sure if this is an issue or not. |
@kavyanekkalapu please re-test |
h-kataria
force-pushed
the
automation_providers
branch
3 times, most recently
from
2d4ea79 to
009d4d1
Compare
kavyanekkalapu
approved these changes
Mar 17, 2021
h-kataria
force-pushed
the
automation_providers
branch
from
009d4d1 to
42cfcf6
Compare
Renamed controller/view/helper files with `ems_automation` prefix.
For Automation Providers list and details view
Adjusted spec tests and removed any redundant tests.
- Fixed code to display breadcrumbs links on the form, this change fixes breadcrumbs for both Ansible Provider and Configuration Provider edit forms because they both use common mixin code. - Added `Edit Tags` button on Ansible Provider details screen to be consistent with other screens. - some minor cleanup of setting/checking of `@explorer`
h-kataria
force-pushed
the
automation_providers
branch
from
f3f16c8 to
d938b52
Compare
Fryguy
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed controller/view/helper files with
ems_automationprefix.Data Migration PR
Dependent Core PR
Cross Repo PR
before
after
