Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added features under Chargeback Rates #20156

Merged
merged 2 commits into from
May 19, 2020
Merged

Added features under Chargeback Rates #20156

merged 2 commits into from
May 19, 2020

Conversation

h-kataria
Copy link
Contributor

@h-kataria h-kataria commented May 12, 2020 •
edited
Loading

Added and reorganized features under Chargeback Rates node to support changes in non-explorer version of Chargeback Rates screen.

Follow up PR for ManageIQ/manageiq-ui-classic#7016

Fixes #6996
Should be merged after #20129 & ManageIQ/manageiq-ui-classic#7016

before
before_cb_rates_features

start_page_before

after
after_cb_rates_features

start_page_after

Existing feature(no change) New feature
chargeback_rates
chargeback_rates_copy
chargeback_rates_delete
chargeback_rates_edit
chargeback_rates_new
chargeback_rates_admin
chargeback_rates_show_list
chargeback_rates_show
chargeback_rates_view
  • Need a data migration to give user access to chargeback_rates_view feature if they have any of these features allowed chargeback_rates, chargeback_rates_copy, chargeback_rates_edit, chargeback_rates_delete, chargeback_rates_new

@h-kataria h-kataria requested a review from skateman May 12, 2020 02:28
@h-kataria h-kataria requested review from agrare and bdunne as code owners May 12, 2020 02:28
@h-kataria h-kataria force-pushed the cb_rates_non_explorer_features branch from 6c60f71 to f2920e4 Compare May 12, 2020 02:44
@h-kataria
Copy link
Contributor Author

@skateman i need some guidance on:

  • Data migration part for feature changes in this PR
  • Need to discuss how to proceed with start page shortcut changes(that's a messy one, we will need data migration for those twice, first once we split a single explorer into multiple explorers and then again as we convert explorer screens into non-explorers) Just trying to think if there is a better way to handle that, any advice/suggestions?

@chessbyte chessbyte changed the title Added features under Chargebcak Rates Added features under Chargeback Rates May 12, 2020
@skateman
Copy link
Member

So as far as I understand, the migration has to go through the features and if all are enabled, also enable the new parent.

@h-kataria
Added features under Chargebcak Rates
90dab7b 
Added and reorganized features under Chargeback Rates node to support changes in non-explorer version of Chargeback Rates screen.

Follow up PR for ManageIQ/manageiq-ui-classic#7016

Fixes ManageIQ#6996
@h-kataria h-kataria force-pushed the cb_rates_non_explorer_features branch from f2920e4 to 90dab7b Compare May 12, 2020 18:54
@miq-bot
Copy link
Member

miq-bot commented May 12, 2020

Checked commits h-kataria/manageiq@90dab7b~...4ce4c14 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 1 offense detected

db/fixtures/miq_product_features.yml

  • 💣 💥 🔥 🚒 - Line 6569, Col 25 - trailing-spaces - trailing spaces

@gtanzillo gtanzillo mentioned this pull request May 12, 2020
Closed
12 tasks
@skateman
Copy link
Member

I kinda have the migration for the features, just need to finish the reverse ones. Regarding the start page, I guess it's already broken now without the migration as we no longer have the main explorer. We have to make a choice with a single page that would repace Overview/Chargeback. My suggestion is to go with the Reports, but I'm okay to do it with any other.

@skateman skateman mentioned this pull request May 13, 2020
Merged
@gtanzillo gtanzillo self-assigned this May 14, 2020
@gtanzillo gtanzillo merged commit 53dae01 into ManageIQ:master May 19, 2020
simaishi pushed a commit that referenced this pull request May 21, 2020
@gtanzillo @simaishi
Merge pull request #20156 from h-kataria/cb_rates_non_explorer_features
4d162e5 
Added features under Chargeback Rates

(cherry picked from commit 53dae01)
@simaishi
Copy link
Contributor

Jansa backport details:

$ git log -1
commit 4d162e53c2218c84380654394603a7723040a1f8
Author: Gregg Tanzillo <[email protected]>
Date:   Tue May 19 13:30:10 2020 -0400

    Merge pull request #20156 from h-kataria/cb_rates_non_explorer_features

    Added features under Chargeback Rates

    (cherry picked from commit 53dae01b24de45815e6760741cb8c5e8f905ebbb)

@h-kataria h-kataria deleted the cb_rates_non_explorer_features branch December 31, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skateman skateman Awaiting requested review from skateman

@agrare agrare Awaiting requested review from agrare agrare is a code owner

@bdunne bdunne Awaiting requested review from bdunne bdunne is a code owner

Assignees

@gtanzillo gtanzillo

Labels
core/chargeback core/rbac enhancement jansa/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@h-kataria @skateman @miq-bot @simaishi @gtanzillo