-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Chargeback explorer into 3 explorers #7016
Split Chargeback explorer into 3 explorers #7016
Conversation
2a58ae7
to
c1b0398
Compare
Removed Accordions from Chargeback Explorer, splitting that into 3 individual explorers with their third level subtabs under Overview/Chargeback, third level tabs are Reports/Rates/Assignments. These new subtabs still use old Product features "chargeback_explorer" that will be taken care of when explorers are converted into non-explorer style screens as this will also require migration at the time. Made changes to remove functionality from new screens to show collapsible accordion on the top like other explorer style screen Split spec tests into multiple files based upon new controller/explorer structure Partially fixes ManageIQ#6996
This commit will allow direct url with id of rate to work in chargeback rates explorer - http://localhost:3000/chargeback_rate/explorer/ (loads Rates explorer) - http://localhost:3000/chargeback_rate/x_show/9 (loads summary screen of rate using id passed in the url) Partially fixes ManageIQ#6996
bcc2a80
to
a16cf8f
Compare
- Added a button in GTL view toolbar to add ability to toggle between list view and tree view. Tree has links to Chargeback Rate records, User can click on "Rates" link in breadcrumbs to go back to list view. - Updated all toolbar buttons to work in non-explorer modes Follow up PR for ManageIQ#7016 Fixes ManageIQ#6996
- Added a button in GTL view toolbar to add ability to toggle between list view and tree view. Tree has links to Chargeback Rate records, User can click on "Rates" link in breadcrumbs to go back to list view. - Updated all toolbar buttons to work in non-explorer modes Follow up PR for ManageIQ#7016 Fixes ManageIQ#6996
Can we use maybe fa-sitemap for the tree icon? https://fontawesome.com/icons?d=gallery&q=sitemap I would prefer if the tree icon was visually left-right oriented (as opposed to top-down oriented like sitemap), but I couldn't find an icon like that. |
@Fryguy yeah, but we're on FA4, so https://fontawesome.com/v4.7.0/icon/sitemap instead |
I think that's good for now |
- Added a button in GTL view toolbar to add ability to toggle between list view and tree view. Tree has links to Chargeback Rate records, User can click on "Rates" link in breadcrumbs to go back to list view. - Updated all toolbar buttons to work in non-explorer modes Follow up PR for ManageIQ#7016 Fixes ManageIQ#6996
- Added a button in GTL view toolbar to add ability to toggle between list view and tree view. Tree has links to Chargeback Rate records, User can click on "Rates" link in breadcrumbs to go back to list view. - Updated all toolbar buttons to work in non-explorer modes Follow up PR for ManageIQ#7016 Fixes ManageIQ#6996
- Added a button in GTL view toolbar to add ability to toggle between list view and tree view. Tree has links to Chargeback Rate records, User can click on "Rates" link in breadcrumbs to go back to list view. - Updated all toolbar buttons to work in non-explorer modes Follow up PR for ManageIQ#7016 Fixes ManageIQ#6996
Added and reorganized features under Chargeback Rates node to support changes in non-explorer version of Chargeback Rates screen. Follow up PR for ManageIQ/manageiq-ui-classic#7016 Fixes ManageIQ#6996
Added and reorganized features under Chargeback Rates node to support changes in non-explorer version of Chargeback Rates screen. Follow up PR for ManageIQ/manageiq-ui-classic#7016 Fixes ManageIQ#6996
@@ -216,20 +216,32 @@ def valid_html_id(id) | |||
id | |||
end | |||
|
|||
NO_ACCORDION = %w[chargeback_assignment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely not a good solution, let me think about it a little.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as described in the comments above
- Added miq_accordion styling back in chargeback explorer screens to be consistent with other explorers with only one accordion. - Removed redundant `tree_autoload` route from chargeback_rates controller Partially fixes ManageIQ#6996
Some comments on commits h-kataria/manageiq-ui-classic@21918d8~...2b632f5 spec/controllers/chargeback_rate_controller_spec.rb
|
Checked commits h-kataria/manageiq-ui-classic@21918d8~...2b632f5 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint app/controllers/chargeback_assignment_controller.rb
app/controllers/chargeback_rate_controller.rb
app/controllers/chargeback_report_controller.rb
app/helpers/application_helper/toolbar_chooser.rb
app/presenters/menu/default_menu.rb
app/views/chargeback_assignment/explorer.html.haml
app/views/chargeback_rate/explorer.html.haml
app/views/chargeback_rate/x_show.html.haml
app/views/chargeback_report/explorer.html.haml
config/routes.rb
spec/controllers/chargeback_assignment_controller_spec.rb
spec/controllers/chargeback_report_controller_spec.rb
|
Can you show me an example URL that should redirect me to a location deep in the hierarchy? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added and reorganized features under Chargeback Rates node to support changes in non-explorer version of Chargeback Rates screen. Follow up PR for ManageIQ/manageiq-ui-classic#7016 Fixes ManageIQ#6996
- Added a button in GTL view toolbar to add ability to toggle between list view and tree view. Tree has links to Chargeback Rate records, User can click on "Rates" link in breadcrumbs to go back to list view. - Updated all toolbar buttons to work in non-explorer modes Follow up PR for ManageIQ#7016 Fixes ManageIQ#6996
- Added a button in GTL view toolbar to add ability to toggle between list view and tree view. Tree has links to Chargeback Rate records, User can click on "Rates" link in breadcrumbs to go back to list view. - Updated all toolbar buttons to work in non-explorer modes Follow up PR for ManageIQ#7016 Fixes ManageIQ#6996
This migration will update startpage entry for any existing user from `chargeback/explorer` to `chargeback_reports/explorer` This issue was caused by changes in ManageIQ/manageiq-ui-classic#7016
This migration will update startpage entry for any existing user from `chargeback/explorer` to `chargeback_reports/explorer` This issue was caused by changes in ManageIQ/manageiq-ui-classic#7016
This migration will update startpage entry for any existing user from `chargeback/explorer` to `chargeback_reports/explorer` This issue was caused by changes in ManageIQ/manageiq-ui-classic#7016
Split Chargeback explorer into 3 explorers (cherry picked from commit 22c37ca)
Jansa backport details:
|
This migration will update startpage entry for any existing user from `chargeback/explorer` to `chargeback_reports/explorer` This issue was caused by changes in ManageIQ/manageiq-ui-classic#7016
- Added a button in GTL view toolbar to add ability to toggle between list view and tree view. Tree has links to Chargeback Rate records, User can click on "Rates" link in breadcrumbs to go back to list view. - Updated all toolbar buttons to work in non-explorer modes Follow up PR for ManageIQ#7016 Fixes ManageIQ#6996
Removed Accordions from Chargeback Explorer, splitting that into 3 individual explorers with their third level subtabs under Overview/Chargeback, third level tabs are Reports/Rates/Assignments. These new subtabs still use old Product features "chargeback_explorer" that will be taken care of when explorers are converted into non-explorer style screens as this will also require migration at the time.
Made changes to remove functionality from new screens to show collapsible accordion on the top like other explorer style screen
Split spec tests into multiple files based upon new controller/explorer structure
Partial fix for #6996
Core PR affected by changes in this PR ManageIQ/manageiq#20129
Before
After