Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved API specific Chargeback features under API section. #20129

Merged
merged 1 commit into from
May 12, 2020
Merged

Moved API specific Chargeback features under API section. #20129

merged 1 commit into from
May 12, 2020

Conversation

h-kataria
Copy link
Contributor

While splitting chargeback explorer, noticed these API specific features that should live under API section, it is confusing to have them in UI section as there are no screens to go with these features.

Partially fixes ManageIQ/manageiq-ui-classic#6996

before
before

after
after

@h-kataria h-kataria requested a review from himdel May 6, 2020 15:33
@h-kataria h-kataria requested review from agrare and bdunne as code owners May 6, 2020 15:33
@miq-bot
Copy link
Member

miq-bot commented May 6, 2020

Checked commit h-kataria@72b6283 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 2 offenses detected

db/fixtures/miq_product_features.yml

  • 💣 💥 🔥 🚒 - Line 3944, Col 1 - trailing-spaces - trailing spaces
  • 💣 💥 🔥 🚒 - Line 6576, Col 25 - trailing-spaces - trailing spaces

@h-kataria h-kataria mentioned this pull request May 6, 2020
Merged
@gtanzillo gtanzillo self-assigned this May 7, 2020
skateman
skateman approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

@h-kataria h-kataria mentioned this pull request May 12, 2020
Merged
@chessbyte chessbyte assigned chessbyte and unassigned gtanzillo May 12, 2020
@chessbyte chessbyte merged commit fed64de into ManageIQ:master May 12, 2020
@gtanzillo gtanzillo mentioned this pull request May 12, 2020
Closed
12 tasks
simaishi pushed a commit that referenced this pull request May 18, 2020
@chessbyte @simaishi
Merge pull request #20129 from h-kataria/chargeback_remove_accordions
4e8d1fa 
Moved API specific Chargeback features under API section.

(cherry picked from commit fed64de)
@simaishi
Copy link
Contributor

Jansa backport details:

$ git log -1
commit 4e8d1faf5151ec58b31996ad01a5e03f76ad6896
Author: Oleg Barenboim <[email protected]>
Date:   Tue May 12 08:22:56 2020 -0400

    Merge pull request #20129 from h-kataria/chargeback_remove_accordions

    Moved API specific Chargeback features under API section.

    (cherry picked from commit fed64dedeb638509397e2399272afa82673c0f62)

@h-kataria h-kataria deleted the chargeback_remove_accordions branch December 31, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skateman skateman skateman approved these changes

@himdel himdel Awaiting requested review from himdel

@agrare agrare Awaiting requested review from agrare agrare is a code owner

@bdunne bdunne Awaiting requested review from bdunne bdunne is a code owner

Assignees

@chessbyte chessbyte

Labels
jansa/backported refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Accordions from explorer style screens and link them into menu navigation
6 participants
@h-kataria @miq-bot @simaishi @skateman @gtanzillo @chessbyte