OpenStack Nova enable/disable service #6996

petrblaho · 2016-02-29T15:01:51Z

This is WIP PR for enabling/disabling nova scheduling for host - which is needed to implement scaling down.

Parts of code needs to be refactored and there are no tests now.

chessbyte · 2016-02-29T15:08:16Z

app/models/ems_refresh/save_inventory_helper.rb

@@ -34,6 +34,7 @@ def fetch(hash)
  end

  def save_inventory_multi(association, hashes, deletes, find_key, child_keys = [], extra_keys = [])
+


why this whitespace change in this PR?

Sorry about that - this is remnant of me playing with that code. I will remove that in next update of PR.

miq-bot · 2016-03-18T20:37:58Z

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

chessbyte · 2016-04-01T01:17:10Z

@blomquisg please review

petrblaho · 2016-04-06T15:46:03Z

@Ladas please can you look at this?

sseago · 2016-04-06T15:51:46Z

app/models/manageiq/providers/openstack/infra_manager/host/operations.rb

+      nova_fog_service.enable
+    end
+
+    def nova_fog_disable_service


There was a comment by @blomquisg on my PR suggesting the removal of the fog-related part in the method name -- i.e. ironic_fog_set_node_maintenance shortened to set_node_maintenance. I'm not sure what the convention is for provider API calls that call out to fog, but these method names would be in a similar category -- whatever we do should probably be consistent across these features. Here's a link to the comment:
#7528 (comment)

Yeah, I prefer to not prefix the methods with nova_fog.

Also, is 'nova-compute' going to be the only service that gets disabled/enabled?

blomquisg · 2016-04-07T01:15:03Z

I'm a bit confused by this PR. (Some of this repeats what I put in line comments)

I thought @Ladas already captured the services from host smart state, though that might not capture the scheduling status for those services (enabled vs. disabled).
I'm not sure why we'd only allow enabling and disabling of nova-compute.
I'm not sure why we'd only capture the scheduling status of nova-compute.

@Ladas and @petrblaho, thoughts?

petrblaho · 2016-04-07T14:57:34Z

@blomquisg

I thought @Ladas already captured the services from host smart state, though that might not capture the scheduling status for those services (enabled vs. disabled).

Enabled/disabled for scheduling cannot be observed by parsing openstack-status report from host b/c this repost only refers to system services on that machine. Scheduling status is apart from active/enabled/disabled services on host and only means if this particular host (and service) will be considered as target when nova goes through decision on which host new VM will be spawned. So this has to be obtained via API call.

I'm not sure why we'd only allow enabling and disabling of nova-compute.
I'm not sure why we'd only capture the scheduling status of nova-compute.

In the future we can enable/disable scheduling even for cinder - so when it is needed this functionality should (and will) be generalized. Currently I do not know of any other services in OpenStack that has enabling/disabling of scheduling feature.

miq-bot · 2016-04-07T20:40:31Z

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

Adds scheduling_status field for SystemService model. Adds set of methods in Host::Operations to enable and disable scheduling for Nova Compute service. Adds system_services to Openstack::CloudManager::RefreshParser with modification of save_system_services_inventory in EmsRefresh::SaveInventory - this is ugly but needed to bridge over a fact that data are coming from Cloud refresh but needed to be stored with Infra's Host's SystemServices. Modifies spec for Openstack Infra Refresher to include Infra + Cloud situation - these tests different number of records in DB after refresh of both Infra and Cloud is done. Updates VCR Cassettes to reflect refresh call to get Openstack Services information.

miq-bot · 2016-04-08T12:37:53Z

Checked commit petrblaho@76376b9 with ruby 2.2.3, rubocop 0.37.2, and haml-lint 0.16.1
6 files checked, 4 offenses detected

app/models/ems_refresh/save_inventory.rb

🔶 - Line 266, Col 11 - Style/MultilineBlockChain - Avoid multi-line chains of blocks.

app/models/manageiq/providers/openstack/cloud_manager/refresh_parser.rb

🔶 - Line 461, Col 9 - Style/AccessorMethodName - Do not prefix reader method names with get_.

spec/models/manageiq/providers/openstack/infra_manager/refresher_rhos_juno_spec.rb

🔶 - Line 112, Col 1 - Style/EmptyLines - Extra blank line detected.
🔹 - Line 125, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for assert_table_counts is too high. [114/15]

Ladas · 2016-04-13T09:21:49Z

app/models/manageiq/providers/openstack/cloud_manager/refresh_parser.rb

+    end
+
+    def parse_service(service)
+      # <Fog::Compute::OpenStack::Service


delete these large comments please

Fryguy · 2016-04-18T20:48:53Z

db/migrate/20160122143711_add_scheduling_status_to_system_services.rb

+  def change
+    add_column :system_services, :scheduling_status, :string
+  end
+end


@petrblaho Can you please pull this migration out into a separate PR so that it can be merged independent of the rest of the changes in this PR? We are approaching the deadline for schema changes for the darga branch, and I don't want the rest of the requested fixes in this PR to hold that up.

miq-bot · 2016-04-19T04:29:09Z

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

petrblaho · 2016-04-19T17:09:22Z

Closing in favor of schema changes in #8093 and functionality code in #7996

Added and reorganized features under Chargeback Rates node to support changes in non-explorer version of Chargeback Rates screen. Follow up PR for ManageIQ/manageiq-ui-classic#7016 Fixes ManageIQ#6996

Follow up PR for ManageIQ/manageiq-ui-classic#7016 ManageIQ#6996

chessbyte added enhancement wip providers/openstack labels Feb 29, 2016

chessbyte reviewed Feb 29, 2016
View reviewed changes

petrblaho force-pushed the nova-enable-disable-services branch from 0605d72 to 47daa52 Compare March 2, 2016 13:25

petrblaho force-pushed the nova-enable-disable-services branch from 47daa52 to 49d9124 Compare March 16, 2016 13:35

petrblaho force-pushed the nova-enable-disable-services branch from 49d9124 to ba688e6 Compare March 31, 2016 17:28

petrblaho changed the title ~~[WIP] OpenStack Nova enable/disable service~~ OpenStack Nova enable/disable service Mar 31, 2016

petrblaho force-pushed the nova-enable-disable-services branch from ba688e6 to 4a474c6 Compare March 31, 2016 18:54

chessbyte removed the wip label Apr 1, 2016

petrblaho force-pushed the nova-enable-disable-services branch from 4a474c6 to 864c8fc Compare April 4, 2016 09:55

blomquisg added wip and removed wip labels Apr 5, 2016

sseago mentioned this pull request Apr 6, 2016

OpenStack infra add node Maintenance mode #7528

Merged

sseago reviewed Apr 6, 2016
View reviewed changes

petrblaho force-pushed the nova-enable-disable-services branch from 864c8fc to c97bbde Compare April 8, 2016 11:16

petrblaho force-pushed the nova-enable-disable-services branch from c97bbde to 76376b9 Compare April 8, 2016 12:32

Ladas reviewed Apr 13, 2016
View reviewed changes

chessbyte added the sql migration label Apr 18, 2016

Fryguy reviewed Apr 18, 2016
View reviewed changes

petrblaho closed this Apr 19, 2016

Fryguy added the providers/cloud label Jan 24, 2020

h-kataria mentioned this pull request May 12, 2020

Added features under Chargeback Rates #20156

Merged

h-kataria added a commit to h-kataria/manageiq that referenced this pull request May 12, 2020

Added new start page entries to match menu changes in Chargeback area

4ce4c14

Follow up PR for ManageIQ/manageiq-ui-classic#7016 ManageIQ#6996

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OpenStack Nova enable/disable service #6996

OpenStack Nova enable/disable service #6996

petrblaho commented Feb 29, 2016

chessbyte Feb 29, 2016

petrblaho Feb 29, 2016

miq-bot commented Mar 18, 2016

chessbyte commented Apr 1, 2016

petrblaho commented Apr 6, 2016

sseago Apr 6, 2016

blomquisg Apr 7, 2016

blomquisg commented Apr 7, 2016

petrblaho commented Apr 7, 2016

miq-bot commented Apr 7, 2016

miq-bot commented Apr 8, 2016

Ladas Apr 13, 2016

Fryguy Apr 18, 2016

miq-bot commented Apr 19, 2016

petrblaho commented Apr 19, 2016

		@@ -34,6 +34,7 @@ def fetch(hash)
		end

		def save_inventory_multi(association, hashes, deletes, find_key, child_keys = [], extra_keys = [])

OpenStack Nova enable/disable service #6996

OpenStack Nova enable/disable service #6996

Conversation

petrblaho commented Feb 29, 2016

chessbyte Feb 29, 2016

Choose a reason for hiding this comment

petrblaho Feb 29, 2016

Choose a reason for hiding this comment

miq-bot commented Mar 18, 2016

chessbyte commented Apr 1, 2016

petrblaho commented Apr 6, 2016

sseago Apr 6, 2016

Choose a reason for hiding this comment

blomquisg Apr 7, 2016

Choose a reason for hiding this comment

blomquisg commented Apr 7, 2016

petrblaho commented Apr 7, 2016

miq-bot commented Apr 7, 2016

miq-bot commented Apr 8, 2016

Ladas Apr 13, 2016

Choose a reason for hiding this comment

Fryguy Apr 18, 2016

Choose a reason for hiding this comment

miq-bot commented Apr 19, 2016

petrblaho commented Apr 19, 2016