Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusted chargeback rates features for de-explorerization #480

Merged
merged 1 commit into from
May 19, 2020
Merged

Adjusted chargeback rates features for de-explorerization #480

merged 1 commit into from
May 19, 2020

Conversation

skateman
Copy link
Member

This is required for ManageIQ/manageiq#20156

@skateman skateman force-pushed the chargeback-rates-features branch from 1d263db to 7ca255e Compare May 13, 2020 13:38
@skateman skateman changed the title Adjusted chargeback rates features for de-explorerization [WIP] Adjusted chargeback rates features for de-explorerization May 13, 2020
@miq-bot miq-bot added the wip label May 13, 2020
@skateman skateman force-pushed the chargeback-rates-features branch from 850c632 to 4ac1247 Compare May 13, 2020 13:58
@skateman skateman force-pushed the chargeback-rates-features branch from 4ac1247 to 89b4938 Compare May 13, 2020 14:04
@miq-bot
Copy link
Member

miq-bot commented May 13, 2020

Checked commit skateman@89b4938 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@skateman skateman changed the title [WIP] Adjusted chargeback rates features for de-explorerization Adjusted chargeback rates features for de-explorerization May 13, 2020
@miq-bot miq-bot removed the wip label May 13, 2020
@gtanzillo gtanzillo mentioned this pull request May 13, 2020
Closed
12 tasks
@h-kataria
Copy link
Contributor

@gtanzillo cc

gtanzillo
gtanzillo approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@h-kataria
Copy link
Contributor

looks good, verified in UI

@gtanzillo gtanzillo self-assigned this May 14, 2020
@gtanzillo gtanzillo merged commit c2adcb2 into ManageIQ:master May 19, 2020
simaishi pushed a commit that referenced this pull request May 21, 2020
@gtanzillo @simaishi
Merge pull request #480 from skateman/chargeback-rates-features
b7ff340 
Adjusted chargeback rates features for de-explorerization

(cherry picked from commit c2adcb2)
@simaishi
Copy link
Contributor

Jansa backport details:

$ git log -1
commit b7ff340e581b514d0496745175d4e8c9972ebf51
Author: Gregg Tanzillo <[email protected]>
Date:   Tue May 19 13:29:15 2020 -0400

    Merge pull request #480 from skateman/chargeback-rates-features

    Adjusted chargeback rates features for de-explorerization

    (cherry picked from commit c2adcb2a86db9d74e6a85c053377ac76572bbb37)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-kataria h-kataria h-kataria approved these changes

@gtanzillo gtanzillo gtanzillo approved these changes

Assignees

@gtanzillo gtanzillo

Labels
data enhancement jansa/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@skateman @miq-bot @h-kataria @simaishi @gtanzillo @chessbyte