Only show catalog types for supported EMSs #20039

agrare · 2020-04-02T13:45:19Z

If an EMS isn't supported by disabling it in the Vmdb::PermissionStore we shouldn't show it as an available catalog type

Follow-up to: #19214
Pluggability: #19440
Cross-Repo-Tests: ManageIQ/manageiq-cross_repo-tests#106

Depends on:

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1746084

app/models/ext_management_system.rb

app/models/service_template.rb

Fryguy · 2020-04-03T13:20:16Z

Aside, I'm concerned about the supported prefix, especially because this introduced the supported? method, which might conflict with the supports feature stuff. For now it's fine, but we may want to consider renaming to permitted prefix (e.g. permitted_subclasses, permitted_types_for_create, etc.)

Fryguy · 2020-04-03T13:25:20Z

@agrare Can you also verify that the API makes its way here as well? I'm concerned the API might present/allow things it shouldn't.

agrare · 2020-04-03T13:40:21Z

Yeah that's true let me rename the methods I added to permitted and we can follow up with the existing supported_subclasses / supported_types

spec/models/manageiq/providers/embedded_ansible/automation_manager_spec.rb

app/models/service_template.rb

If an EMS isn't supported by disabling it in the Vmdb::PermissionStore we shouldn't show it as an available catalog type Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1746084

agrare · 2020-04-03T18:35:11Z

@Fryguy cross-repo tests are green (at least on traivs .org) ManageIQ/manageiq-cross_repo-tests#106

Fryguy · 2020-04-06T20:42:07Z

I noticed that the network manager also has this method, which feels like it should be refactored as part of this PR.

agrare · 2020-04-06T21:18:22Z

I noticed that the network manager also has this method, which feels like it should be refactored as part of this PR.

https://github.com/ManageIQ/manageiq/pull/20039/files#diff-43ca61dfc6415fdd839b6468b7c20a37R71-R73

miq-bot · 2020-04-06T22:45:27Z

Checked commits agrare/manageiq@4514e30~...227ad29 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
7 files checked, 2 offenses detected

app/models/service_template.rb

❗ - Line 100, Col 9 - Layout/MultilineMethodCallIndentation - Align .reduce with .supported_types_for_catalog on line 98.
❗ - Line 99, Col 9 - Layout/MultilineMethodCallIndentation - Align .flat_map with .supported_types_for_catalog on line 98.

Fryguy · 2020-04-09T17:37:03Z

Merging on red since cross-repo is green

…g_types Only show catalog types for supported EMSs (cherry picked from commit ac4f13a)

simaishi · 2020-04-16T21:22:54Z

Jansa backport details:

$ git log -1
commit 92c8b5e3d46aebd124fb143f21ff4e736ec9d00c
Author: Jason Frey <[email protected]>
Date:   Thu Apr 9 13:37:11 2020 -0400

    Merge pull request #20039 from agrare/only_show_supported_emss_catalog_types

    Only show catalog types for supported EMSs

    (cherry picked from commit ac4f13a0be15ce047805b828317022530027970d)

agrare requested review from Fryguy and kbrock as code owners April 2, 2020 13:45

agrare added the wip label Apr 2, 2020

agrare force-pushed the only_show_supported_emss_catalog_types branch from 8072098 to 1eeddac Compare April 2, 2020 13:46

agrare commented Apr 2, 2020

View reviewed changes

app/models/ext_management_system.rb Show resolved Hide resolved

agrare force-pushed the only_show_supported_emss_catalog_types branch from 1eeddac to c6c6340 Compare April 2, 2020 14:51

gtanzillo added the enhancement label Apr 2, 2020

agrare force-pushed the only_show_supported_emss_catalog_types branch 4 times, most recently from fea624f to a9aafaa Compare April 3, 2020 13:11

Fryguy reviewed Apr 3, 2020

View reviewed changes

app/models/service_template.rb Outdated Show resolved Hide resolved

Fryguy self-assigned this Apr 3, 2020

agrare mentioned this pull request Apr 3, 2020

[Providers] Pluggability Checklist #19440

Open

48 tasks

agrare force-pushed the only_show_supported_emss_catalog_types branch from a9aafaa to c8123d9 Compare April 3, 2020 13:39

agrare force-pushed the only_show_supported_emss_catalog_types branch from c8123d9 to 150dfeb Compare April 3, 2020 13:57

agrare requested a review from gtanzillo as a code owner April 3, 2020 13:57

miq-bot added the core/embedded ansible label Apr 3, 2020

Fryguy reviewed Apr 3, 2020

View reviewed changes

spec/models/manageiq/providers/embedded_ansible/automation_manager_spec.rb Outdated Show resolved Hide resolved

Fryguy reviewed Apr 3, 2020

View reviewed changes

spec/models/manageiq/providers/embedded_ansible/automation_manager_spec.rb Outdated Show resolved Hide resolved

Fryguy reviewed Apr 3, 2020

View reviewed changes

spec/models/manageiq/providers/embedded_ansible/automation_manager_spec.rb Outdated Show resolved Hide resolved

Fryguy reviewed Apr 3, 2020

View reviewed changes

app/models/service_template.rb Outdated Show resolved Hide resolved

agrare force-pushed the only_show_supported_emss_catalog_types branch from 150dfeb to 16adfcb Compare April 3, 2020 14:16

kbrock reviewed Apr 3, 2020

View reviewed changes

app/models/service_template.rb Outdated Show resolved Hide resolved

agrare force-pushed the only_show_supported_emss_catalog_types branch from 16adfcb to 6b1ea4b Compare April 3, 2020 16:32

Only show catalog types for supported EMSs

4514e30

If an EMS isn't supported by disabling it in the Vmdb::PermissionStore we shouldn't show it as an available catalog type Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1746084

agrare force-pushed the only_show_supported_emss_catalog_types branch from 6b1ea4b to 4514e30 Compare April 3, 2020 17:29

agrare added a commit to agrare/manageiq-cross_repo-tests that referenced this pull request Apr 3, 2020

Test ManageIQ/manageiq#20039

ac2bf08

agrare added a commit to agrare/manageiq-cross_repo-tests that referenced this pull request Apr 6, 2020

Test ManageIQ/manageiq#20039

a019277

Refactor NetworkManager supported_types_and_descriptions_hash

227ad29

agrare force-pushed the only_show_supported_emss_catalog_types branch from ee836b6 to 227ad29 Compare April 6, 2020 22:44

agrare added a commit to agrare/manageiq-cross_repo-tests that referenced this pull request Apr 6, 2020

Test ManageIQ/manageiq#20039

f501267

agrare changed the title ~~[WIP] Only show catalog types for supported EMSs~~ Only show catalog types for supported EMSs Apr 8, 2020

miq-bot removed the wip label Apr 8, 2020

Fryguy merged commit ac4f13a into ManageIQ:master Apr 9, 2020

Fryguy added jansa/yes? bug and removed enhancement labels Apr 9, 2020

agrare deleted the only_show_supported_emss_catalog_types branch April 9, 2020 17:43

agrare mentioned this pull request Apr 10, 2020

Fix a missing permission stub in a spec #20067

Merged

agrare added pluggability/providers jansa/yes and removed jansa/yes? labels Apr 14, 2020

simaishi pushed a commit that referenced this pull request Apr 16, 2020

Merge pull request #20039 from agrare/only_show_supported_emss_catalo…

92c8b5e

…g_types Only show catalog types for supported EMSs (cherry picked from commit ac4f13a)

simaishi added jansa/backported and removed jansa/yes labels Apr 16, 2020

agrare mentioned this pull request Jul 20, 2020

Allow plugins to bring new Vm vendor_types #20372

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Only show catalog types for supported EMSs #20039

Only show catalog types for supported EMSs #20039

agrare commented Apr 2, 2020 •

edited by Fryguy

Loading

Fryguy commented Apr 3, 2020 •

edited

Loading

Fryguy commented Apr 3, 2020 •

edited

Loading

agrare commented Apr 3, 2020

agrare commented Apr 3, 2020

Fryguy commented Apr 6, 2020

agrare commented Apr 6, 2020

miq-bot commented Apr 6, 2020

Fryguy commented Apr 9, 2020

simaishi commented Apr 16, 2020

Only show catalog types for supported EMSs #20039

Only show catalog types for supported EMSs #20039

Conversation

agrare commented Apr 2, 2020 • edited by Fryguy Loading

Fryguy commented Apr 3, 2020 • edited Loading

Fryguy commented Apr 3, 2020 • edited Loading

agrare commented Apr 3, 2020

agrare commented Apr 3, 2020

Fryguy commented Apr 6, 2020

agrare commented Apr 6, 2020

miq-bot commented Apr 6, 2020

Fryguy commented Apr 9, 2020

simaishi commented Apr 16, 2020

agrare commented Apr 2, 2020 •

edited by Fryguy

Loading

Fryguy commented Apr 3, 2020 •

edited

Loading

Fryguy commented Apr 3, 2020 •

edited

Loading