Removed Google from the Catalog Item Types list. #19214
Conversation
|
Checked commit h-kataria@9d160ae with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
There was a problem hiding this comment.
We should not be removing this upstream, since it's still a plugin here, and is supported by ManageIQ. Ideally this would be a pluggable setting and removing it would be based on disabling the plugin. The next best thing would be to somehow leverage supported_providers_for_create here instead. @agrare Thoughts?
@h-kataria Are there any other PRs that have been created to "remove" google? If so, can you send them to me in email? I want to make sure we are not removing them, but instead using the "disable" functionality properly.
|
@h-kataria @Fryguy where are we with this PR? Sounds like it should be reworked or closed? |
|
@h-kataria closing per comments from @Fryguy |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1746084
before
after
