Only show catalog types for supported EMSs

If an EMS isn't supported by disabling it in the Vmdb::PermissionStore we shouldn't show it as an available catalog type
ManageIQ · Apr 2, 2020 · 8072098 · 8072098
1 parent 8bd930c
commit 8072098
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/app/models/ext_management_system.rb b/app/models/ext_management_system.rb
@@ -22,17 +22,15 @@ def self.leaf_subclasses
   end
 
   def self.supported_subclasses
-    subclasses.flat_map do |s|
-      s.subclasses.empty? ? s : s.supported_subclasses
-    end
+    leaf_subclasses.select(&:supported?)
+  end
+
+  def self.supported?
+    Vmdb::PermissionStores.instance.supported_ems_type?(ems_type)
   end
 
   def self.supported_types_and_descriptions_hash
-    supported_subclasses.each_with_object({}) do |klass, hash|
-      if Vmdb::PermissionStores.instance.supported_ems_type?(klass.ems_type)
-        hash[klass.ems_type] = klass.description
-      end
-    end
+    supported_subclasses.each_with_object({}) { |klass, hash| hash[klass.ems_type] = klass.description }
   end
 
   def self.api_allowed_attributes

diff --git a/app/models/service_template.rb b/app/models/service_template.rb
@@ -104,7 +104,7 @@ def self.with_additional_tenants
   end
 
   def self.catalog_item_types
-    ci_types = Set.new(Rbac.filtered(ExtManagementSystem.all).flat_map(&:supported_catalog_types))
+    ci_types = Set.new(Rbac.filtered(ExtManagementSystem.supported_subclasses).flat_map(&:supported_catalog_types))
     ci_types.add('generic_orchestration') if Rbac.filtered(OrchestrationTemplate).exists?
     ci_types.add('generic')
     CATALOG_ITEM_TYPES.each.with_object({}) do |(key, description), hash|