Make Provider Catalog Types Pluggable

[agrare]

Cross Repo Tests: ManageIQ/manageiq-cross_repo-tests#106
Core PR: ManageIQ/manageiq#20039

[djberg96]

I'm totally nitpicking, and I realize that they're synonyms, but I generally use context for inner blocks, and describe for the outer block only.

[agrare]

That's funny because in ManageIQ/manageiq#20039 (comment) I got the opposite advice :)

I tend to use describe as the top level for a method, and context if I'm testing different...well...contexts within that method

[djberg96]

Eh, maybe you're right: https://lmws.net/describe-vs-context-in-rspec

[Fryguy]

@djberg96 I don't do describe vs context based on location (inner vs outer). I tend to recommend more like what @agrare said:

• Use describe to describe the method under test, trying to use the actual method name if possible (e.g. ".the_method" for class methods, "#the_method" for instance methods and appending " (private)" if the method under test is private).

• Use context to describe a particular environment in which the tests runs. (e.g. "when there are credentials defined"), and then having a before that sets up specific credentials

• I tend to avoid creating extraneous describes and contexts unless I have more than one test. That is, if a single it is good enough, I just do that...

  # I don't really like:
  describe ".the_method" do
    it "works" do
      described_class.the_method
    end
  end
  
  # I prefer:
  it ".the_method" do
    described_class.the_method
  end

[miq-bot]

Checked commit agrare@2278740 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. ⭐

[Fryguy]

Merging on red since cross-repo is green

[simaishi]

Jansa backport details:

$ git log -1
commit 0de5b37136a28f7e6e1bc55cbf9321ad5236c48b
Author: Jason Frey <[email protected]>
Date:   Thu Apr 9 13:39:52 2020 -0400

    Merge pull request #389 from agrare/make_catalog_types_pluggable

    Make Provider Catalog Types Pluggable

    (cherry picked from commit 116fc4bfadf198e2fcea20f1b9483faf7c14ff4e)