Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a missing permission stub in a spec #20067

Merged
merged 1 commit into from
Apr 11, 2020

Conversation

agrare
Copy link
Member

@agrare agrare commented Apr 10, 2020

#20053 removed the stub_vmdb_permission_store_with_types method but a new spec that used that method was added by #20039

Failure: https://travis-ci.com/github/ManageIQ/manageiq/jobs/318274533#L667-L675

Failures:
  1) ExtManagementSystem.supported_types with removed permissions
     Failure/Error:
       stub_vmdb_permission_store_with_types(["ems-type:vmwarews"]) do
         expect(described_class.supported_types).not_to include("vmwarews")
       end
     NoMethodError:
       undefined method `stub_vmdb_permission_store_with_types' for #<RSpec::ExampleGroups::ExtManagementSystem::SupportedTypes:0x00000000300cddb8>
     # ./spec/models/ext_management_system_spec.rb:95:in `block (3 levels) in <top (required)>'

The stub_vmdb_permission_store_with_types stub was removed, replace with
a mock
@miq-bot
Copy link
Member

miq-bot commented Apr 10, 2020

Checked commit agrare@6422be7 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@Fryguy Fryguy merged commit 5e34843 into ManageIQ:master Apr 11, 2020
@Fryguy Fryguy self-assigned this Apr 11, 2020
@agrare agrare deleted the fix_missing_vmdb_persmission_stub branch April 11, 2020 13:08
simaishi pushed a commit that referenced this pull request Apr 16, 2020
Fix a missing permission stub in a spec

(cherry picked from commit 5e34843)
@simaishi
Copy link
Contributor

Jansa backport details:

$ git log -1
commit e514f722d55ba619b5b5eb92bd2b63a7cf9e3fb1
Author: Jason Frey <[email protected]>
Date:   Sat Apr 11 08:56:45 2020 -0400

    Merge pull request #20067 from agrare/fix_missing_vmdb_persmission_stub

    Fix a missing permission stub in a spec

    (cherry picked from commit 5e3484340dd3f5777059ab3d42caa482cc977805)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants