Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ooniprobe 3.22.0 #172462

Merged
merged 2 commits into from
May 22, 2024
Merged

ooniprobe 3.22.0 #172462

merged 2 commits into from
May 22, 2024

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

release notes
This is a stable release. As usual, this release includes both an OONI Probe CLI release and the corresponding release of the measurement engine, which is hosted by the same repository.

Here's a thematic summary of what changed since v3.21.0:

  • ✨ Preparing Web Connectivity LTE for use in production
  • 🐛 Prioritize DNS results when communicating with backends
  • 🚧 Refactor and document communication with the OONI backend
  • 📖 Documenting the release process
  • 🚧 Minor changes & bug fixes

More in detail, here's what has changed:

✨ Preparing Web Connectivity LTE for use in production

We worked towards closing all the open Web Connectivity LTE issues, such that we can finally be well placed to run an A/B testing between the v0.4 and LTE using this version of the OONI Probe Engine.

🐛 Prioritize DNS results when communicating with backends

We documented the strategy to communicate with backends, including the OONI backend, and we discussed the design as part of the ooni/probe-cli#1552. During such a review, it was requested to modify the policy with which we communicate with the backends, so that the DNS results have higher priority. The main concern of this change request was to avoid long recovery periods if the currently deployed bridge becomes unavailable as well as to tilt the overall design such that uncensored OONI Probe users communicate with the backends in the simplest possible way.

🚧 Refactor and document communication with the OONI backend

We wanted to document the interaction with the OONI backend and specifically with the "probe services" (i.e., the collection of APIs used by OONI Probe), per ooni/probe#2700. To this end, we seized the opportunity to simplify the code interactions, reduce the number of used packages, and refactor the code to improve its reliability and future usability.

📖 Documenting the release process

We were asked to document the release process in ooni/probe#2698, and the resulting work is this:

🚧 Releasing & maintenance

This set of changes deal with preparing a release. In particular, in this case, we took on the chore of reducing the number of warnings emitted by gosec, such that its output can actually be informative and actionable (there was lots of noise). In terms of behavioral changes in the ooniprobe binary, these are the two most "impactful" changes:

  1. I explicitly ignore errors when resetting with -f the OONI_HOME directory, to keep the previous idempotent behavior, because I think that otherwise the desktop app may emit errors if asked to delete the OONI_HOME multiple times: https://github.com/ooni/probe-cli/pull/1603/files#diff-2e841e5388e3f75b0ab808e74d5b34a9ebb72466a508daecda35625a7eab5c7fR29

  2. I have improved how we manage survey errors: https://github.com/ooni/probe-cli/pull/1603/files#diff-3e09d6a095d686f531f06efe21b6e430b311340af5ce74989f110dc05424cbcdR24 and fix(cli/rm/rm.go): using panic is not user friendly ooni/probe-cli#1608

  3. I am now reporting an error if we fail to update the database to set the upload status: https://github.com/ooni/probe-cli/pull/1603/files#diff-2a4cd822f78eb174dc7c6b88e3ab71be4810624b358b98109c10bcb5371e4844R249

  4. I have now configured timeouts for receiving headers in oohelperd: https://github.com/ooni/probe-cli/pull/1603/files#diff-663f720a0015bc642e1957e965f9bc9115cea500fc0268bf5a6e22b5ad7cb44dR111

Here's the full list of pull requests:

🚧 Minor changes & bug fixes

Full Changelog: ooni/probe-cli@v3.21.0...v3.22.0

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels May 22, 2024
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 22, 2024
@BrewTestBot BrewTestBot enabled auto-merge May 22, 2024 13:45
@BrewTestBot BrewTestBot added this pull request to the merge queue May 22, 2024
Merged via the queue into master with commit 43b8b60 May 22, 2024
14 checks passed
@BrewTestBot BrewTestBot deleted the bump-ooniprobe-3.22.0 branch May 22, 2024 13:51
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants