refactor(probeservices): use httpclientx for check-in #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff includes a first attempt at consolidating the patterns with which we invoke OONI and third-party API calls. I have refactored the code of httpx and httpapi into a new package called httpclientx, added some tests, started converting some parts of the tree, and explained myself in a design document. Part of ooni/probe#2700
Spotted thanks to a very paranoid check inside ./internal/oonirun. Was not a problem before for `httpx` because of its usage pattern and may or may not be a problem for the `httpapi` package (did not check since this work is focused on replacing both `httpx` and `httpapi`).
Previously, we were gracefully handling this case, but honestly it is not the best approach to pretend there's an empty structure if the server breaks the API and returns `"null"` rather than an object. That said, it was still awesome to have this test in place because it helped us to figure out this extra condition of which httpclientx should be aware and that this problem needs to be dealt with systematically inside the httpclientx package.
Conflicts: internal/enginelocate/cloudflare.go internal/enginelocate/ubuntu.go
Conflicts: internal/oonirun/v2_test.go
As before, here I am going to ensure there's redundancy.
Conflicts: internal/httpclientx/DESIGN.md internal/httpclientx/getraw.go internal/httpclientx/overlapped.go
Conflicts: internal/probeservices/login_test.go
Conflicts: internal/testingx/oonicollector.go
Conflicts: internal/probeservices/collector_test.go
Conflicts: internal/probeservices/bouncer.go internal/probeservices/collector.go internal/probeservices/login.go internal/probeservices/measurementmeta.go internal/probeservices/psiphon.go internal/probeservices/register.go internal/probeservices/tor.go
While there, add additional tests ensuring that we're actually writing into the key-value store after check-in. Also, ensure that failure to write into the key-value store does not break check-in for good.
bassosimone
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ooni/probe#2724.
While there (1) make sure we test the check-in API call writes into the kvstore as a side effect; (2) remove parts of ooapi that have now become unused due to the change inside this pull request.