Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oonimkall.HTTPRequest): URL => Url to fix iOS #1545

Merged
merged 5 commits into from
Apr 8, 2024

Conversation

aanorbel
Copy link
Member

@aanorbel aanorbel commented Apr 8, 2024

Closes: ooni/probe#2701

 `Url`, the former doesnt keep values on iOS
@bassosimone bassosimone changed the title fix : Update HTTPRequest property name from URL to Url, the former doesnt keep values on iOS fix(oonimkall.HTTPRequest): URL => Url to fix iOS Apr 8, 2024
pkg/oonimkall/httpx.go Outdated Show resolved Hide resolved
pkg/oonimkall/httpx.go Outdated Show resolved Hide resolved
Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

@bassosimone bassosimone merged commit d08ce02 into master Apr 8, 2024
28 checks passed
@bassosimone bassosimone deleted the fix/unmapped-ios-property branch April 8, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oonimkall.HTTPRequest.URL is not passed properly from iOS
2 participants