Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(enginenetx): remove previous policies #1593

Merged
merged 134 commits into from
May 9, 2024
Merged

cleanup(enginenetx): remove previous policies #1593

merged 134 commits into from
May 9, 2024

Conversation

bassosimone
Copy link
Contributor

@bassosimone bassosimone commented May 9, 2024

In #1592 and previous pull requests, I replaced the policies that embedded mixing logic with neutral policies and external mixing logic, which enabled me to implement what was requested in the #1552 pull request review. Now, with this pull request, I am cleaning up, by removing the policies that we were previously using. Work part of ooni/probe#2704.

This diff refactors the code generating tactics to mix bridge and DNS
tactics, such that we avoid trying all bridge tactics before falling
back to DNS tactics. In the event in which the bridge is IP or endpoint
blocked, this change makes sure we try using DNS tactics earlier, and,
if the DNS is working, this means a faster bootstrap.

Based on testing, where I replaced the bridge address with 10.0.0.1, we
try DNS tactics after 8 seconds. After the first run, if the DNS tactics
are working, we would immediately use them before bridge tactics, since
we store information about tactics inside the $OONI_HOME/engine dir.

Part of ooni/probe#2704.
Previously, we were only testing with DNS returning error, while
now we should also have a test case for when it's working given that
we're mixing tactics together now.
@bassosimone bassosimone changed the title Issue/2704d cleanup(enginenetx): remove previous policies May 9, 2024
@bassosimone bassosimone marked this pull request as ready for review May 9, 2024 14:10
@bassosimone bassosimone requested a review from hellais as a code owner May 9, 2024 14:10
@bassosimone bassosimone merged commit 9f77da7 into master May 9, 2024
17 of 19 checks passed
@bassosimone bassosimone deleted the issue/2704d branch May 9, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant