Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(enginenetx): add algorithms to filter, mix, and stream tactics #1556

Merged
merged 110 commits into from
Apr 17, 2024

Conversation

bassosimone
Copy link
Contributor

@bassosimone bassosimone commented Apr 17, 2024

This diff extends the enginenetx package to add algorithms to filter, mix, and stream tactics.

We will use this algorithms to simplify the implementation and make it more composable.

This work is part of ooni/probe#2704.

This diff refactors the code generating tactics to mix bridge and DNS
tactics, such that we avoid trying all bridge tactics before falling
back to DNS tactics. In the event in which the bridge is IP or endpoint
blocked, this change makes sure we try using DNS tactics earlier, and,
if the DNS is working, this means a faster bootstrap.

Based on testing, where I replaced the bridge address with 10.0.0.1, we
try DNS tactics after 8 seconds. After the first run, if the DNS tactics
are working, we would immediately use them before bridge tactics, since
we store information about tactics inside the $OONI_HOME/engine dir.

Part of ooni/probe#2704.
Previously, we were only testing with DNS returning error, while
now we should also have a test case for when it's working given that
we're mixing tactics together now.
@bassosimone bassosimone changed the title Issue/2704d feat(enginenetx): add algorithms to filter, mix, and stream Apr 17, 2024
@bassosimone bassosimone changed the title feat(enginenetx): add algorithms to filter, mix, and stream feat(enginenetx): add algorithms to filter, mix, and stream tactics Apr 17, 2024
@bassosimone bassosimone marked this pull request as ready for review April 17, 2024 09:38
@bassosimone bassosimone requested a review from hellais as a code owner April 17, 2024 09:38
@bassosimone bassosimone merged commit 8c4a4f6 into master Apr 17, 2024
27 checks passed
@bassosimone bassosimone deleted the issue/2704d branch April 17, 2024 09:42
bassosimone added a commit that referenced this pull request Apr 17, 2024
This diff refactors enginenetx to assign InitialDelay only when dialing.
It is pointless to do that before. Also, take advantage of algorithms
introduced by #1556 to make the
code more compact.

Part of ooni/probe#2704.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant