Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make deletion_policy field for Project resource PREVENT by default #11255

Merged
merged 18 commits into from
Aug 13, 2024
Merged

Make deletion_policy field for Project resource PREVENT by default #11255

merged 18 commits into from
Aug 13, 2024

Conversation

abd-goog
Copy link
Member

@abd-goog abd-goog commented Jul 25, 2024 •
edited by zli82016
Loading

Make deletion_policy field 'PREVENT' by default to make deletion actions require an explicit intent.
Deprecate skip_delete field in favor of this change.
Part of b/330143705

Part of hashicorp/terraform-provider-google#18775

Release Note Template for Downstream PRs (will be copied)

resourcemanager: made `deletion-policy` in `google_project` 'PREVENT' by default. This makes deleting them require an explicit intent. `google_project` resources cannot be destroyed unless `deletion_policy` is set to 'ABANDON' or 'DELETE' for the resource.

@abd-goog abd-goog changed the base branch from main to FEATURE-BRANCH-major-release-6.0.0 July 25, 2024 10:35
@abd-goog abd-goog mentioned this pull request Jul 25, 2024
Closed
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 21 files changed, 413 insertions(+), 74 deletions(-))
google-beta provider: Diff ( 22 files changed, 422 insertions(+), 75 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 11 insertions(+), 7 deletions(-))
Open in Cloud Shell: Diff ( 2 files changed, 4 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field backend.balancing_mode default value changed from CONNECTION to UTILIZATION on google_compute_region_backend_service - reference
  • Field connection_draining_timeout_sec default value changed from 0 to 300 on google_compute_region_backend_service - reference
  • Field max_throughput default value changed from 300 to on google_vpc_access_connector - reference
  • Field min_throughput default value changed from 200 to on google_vpc_access_connector - reference
  • Field outlier_detection.consecutive_errors default value changed from 5 to on google_compute_backend_service - reference
  • Field outlier_detection.consecutive_errors default value changed from 5 to on google_compute_region_backend_service - reference
  • Field outlier_detection.consecutive_gateway_failure default value changed from 5 to on google_compute_backend_service - reference
  • Field outlier_detection.consecutive_gateway_failure default value changed from 5 to on google_compute_region_backend_service - reference
  • Field outlier_detection.enforcing_consecutive_errors default value changed from 100 to on google_compute_backend_service - reference
  • Field outlier_detection.enforcing_consecutive_errors default value changed from 100 to on google_compute_region_backend_service - reference
  • Field outlier_detection.enforcing_consecutive_gateway_failure default value changed from 0 to on google_compute_backend_service - reference
  • Field outlier_detection.enforcing_consecutive_gateway_failure default value changed from 0 to on google_compute_region_backend_service - reference
  • Field outlier_detection.enforcing_success_rate default value changed from 100 to on google_compute_backend_service - reference
  • Field outlier_detection.enforcing_success_rate default value changed from 100 to on google_compute_region_backend_service - reference
  • Field outlier_detection.max_ejection_percent default value changed from 10 to on google_compute_backend_service - reference
  • Field outlier_detection.max_ejection_percent default value changed from 10 to on google_compute_region_backend_service - reference
  • Field outlier_detection.success_rate_minimum_hosts default value changed from 5 to on google_compute_backend_service - reference
  • Field outlier_detection.success_rate_minimum_hosts default value changed from 5 to on google_compute_region_backend_service - reference
  • Field outlier_detection.success_rate_request_volume default value changed from 100 to on google_compute_backend_service - reference
  • Field outlier_detection.success_rate_request_volume default value changed from 100 to on google_compute_region_backend_service - reference
  • Field outlier_detection.success_rate_stdev_factor default value changed from 1900 to on google_compute_backend_service - reference
  • Field outlier_detection.success_rate_stdev_factor default value changed from 1900 to on google_compute_region_backend_service - reference
  • Field schema_settings transitioned from optional+computed to optional google_pubsub_topic - reference
  • Field skip_delete within resource google_project was either removed or renamed - reference
  • Field template.containers.liveness_probe transitioned from optional+computed to optional google_cloud_run_v2_service - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1367
Passed tests: 1113
Skipped tests: 120
Affected tests: 134

Click here to see the affected service packages
  • bigquery
  • cloudfunctions
  • cloudrunv2
  • compute
  • pubsub
  • resourcemanager
  • vpcaccess
  • appengine
#### Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccVPCAccessConnector_vpcAccessConnectorThroughput_combiningThroughputAndInstancesFields_conflict

Action taken

Found 134 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccPubsubTopic_schema
  • TestAccDataSourceGoogleProjectService_basic
  • TestAccDataSourceGoogleProject_basic
  • TestAccProjectIamAuditConfig_addFirstExemptMember
  • TestAccProjectIamAuditConfig_basic
  • TestAccProjectIamAuditConfig_multiple
  • TestAccProjectIamAuditConfig_removeLastExemptMember
  • TestAccProjectIamAuditConfig_update
  • TestAccProjectIamAuditConfig_updateNoExemptMembers
  • TestAccProjectIamBinding_basic
  • TestAccProjectIamBinding_invalidMembers
  • TestAccProjectIamBinding_multiple
  • TestAccProjectIamBinding_noMembers
  • TestAccProjectIamBinding_update
  • TestAccProjectIamBinding_withCondition
  • TestAccProjectIamMemberRemove_basic
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccProjectIamMemberRemove_multipleMembersInBinding
  • TestAccProjectIamMember_basic
  • TestAccProjectIamMember_invalidMembers
  • TestAccProjectIamMember_withCondition
  • TestAccProjectIamPolicy_basic
  • TestAccProjectIamPolicy_basicAuditConfig
  • TestAccProjectIamPolicy_emptyMembers
  • TestAccProjectIamPolicy_expanded
  • TestAccProjectIamPolicy_expandedAuditConfig
  • TestAccProjectIamPolicy_invalidMembers
  • TestAccProjectIamPolicy_withCondition
  • TestAccProjectService_handleNotFound
  • TestAccProject_abandon
  • TestAccProject_noAllowDestroy
  • TestAccResourceGoogleProjectDefaultServiceAccountsBasic
  • TestAccResourceGoogleProjectDefaultServiceAccountsDelete
  • TestAccResourceGoogleProjectDefaultServiceAccountsDeleteRevertIgnoreFailure
  • TestAccResourceGoogleProjectDefaultServiceAccountsDeprivilege
  • TestAccResourceGoogleProjectDefaultServiceAccountsDisable
  • TestAccResourceManagerLien_basic
  • TestAccVPCAccessConnector_vpcAccessConnectorExample
  • TestAccVPCAccessConnector_vpcAccessConnectorSharedVpcExample
  • TestAccVPCAccessConnector_vpcAccessConnectorThroughput
  • TestAccVPCAccessConnector_vpcAccessConnectorThroughput_usingThroughputOrInstancesLimits
  • TestAccAppEngineApplication_basic
  • TestAccAppEngineApplication_withIAP
  • TestAccAppEngineFirewallRule_appEngineFirewallRuleBasicExample
  • TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample
  • TestAccAppEngineFlexibleAppVersion_update
  • TestAccAppEngineStandardAppVersion_update
  • TestAccBigQueryTable_schemaWithRequiredFieldAndView
  • TestAccCloudRunV2Job_cloudrunv2JobFullUpdate
  • TestAccCloudRunV2Job_cloudrunv2JobVpcaccessExample
  • TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate
  • TestAccCloudRunV2Service_cloudrunv2ServiceGRPCProbesUpdate
  • TestAccCloudRunV2Service_cloudrunv2ServiceVpcaccessExample
  • TestAccComputeBackendService_trafficDirectorUpdateBasic
  • TestAccComputeBackendService_trafficDirectorUpdateFull
  • TestAccComputeBackendService_trafficDirectorUpdateLbPolicies
  • TestAccComputeForwardingRule_forwardingRuleExternallbExample
  • TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample
  • TestAccComputeForwardingRule_forwardingRuleHttpLbExample
  • TestAccComputeForwardingRule_forwardingRuleInternallbExample
  • TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example
  • TestAccComputeForwardingRule_forwardingRuleIpAddressIpv6
  • TestAccComputeForwardingRule_forwardingRuleL3DefaultExample
  • TestAccComputeForwardingRule_forwardingRulePscRecreate
  • TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample
  • TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExample
  • TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExampleUpdate
  • TestAccComputeForwardingRule_forwardingRuleVpcPscExample
  • TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate
  • TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample
  • TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample
  • TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample
  • TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeNetworkAttachment_networkAttachmentBasicExample
  • TestAccComputeNodeGroup_nodeGroupShareSettingsExample
  • TestAccComputePacketMirroring_computePacketMirroringFullExample
  • TestAccComputeProjectCloudArmorTier_withProjectSet
  • TestAccComputeProjectDefaultNetworkTier_basic
  • TestAccComputeProjectDefaultNetworkTier_modify
  • TestAccComputeProjectMetadata_basic
  • TestAccComputeProjectMetadata_modify_1
  • TestAccComputeProjectMetadata_modify_2
  • TestAccComputeRegionBackendService_basic
  • TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol
  • TestAccComputeRegionBackendService_ilbUpdateBasic
  • TestAccComputeRegionBackendService_ilbUpdateFull
  • TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample
  • TestAccComputeRegionBackendService_regionBackendServiceCacheExample
  • TestAccComputeRegionBackendService_regionBackendServiceExternalExample
  • TestAccComputeRegionBackendService_regionBackendServiceExternalIapExample
  • TestAccComputeRegionBackendService_regionBackendServiceExternalWeightedExample
  • TestAccComputeRegionBackendService_regionBackendServiceIlbRingHashExample
  • TestAccComputeRegionBackendService_regionBackendServiceIlbRoundRobinExample
  • TestAccComputeRegionBackendService_subsettingUpdate
  • TestAccComputeRegionBackendService_withBackendAndIAP
  • TestAccComputeRegionBackendService_withBackendInternal
  • TestAccComputeRegionBackendService_withBackendInternalManaged
  • TestAccComputeRegionBackendService_withBackendMultiNic
  • TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate
  • TestAccComputeRegionBackendService_withSecurityPolicy
  • TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample
  • TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyBasicExample
  • TestAccComputeRegionTargetHttpProxy_update
  • TestAccComputeRegionTargetHttpsProxy_addSslPolicy_withForwardingRule
  • TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyBasicExample
  • TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyCertificateManagerCertificateExample
  • TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyMtlsExample
  • TestAccComputeRegionTargetHttpsProxy_update
  • TestAccComputeRegionTargetTcpProxy_regionTargetTcpProxyBasicExample
  • TestAccComputeRegionTargetTcpProxy_update
  • TestAccComputeRegionUrlMap_advanced
  • TestAccComputeRegionUrlMap_defaultRouteAction_full_update
  • TestAccComputeRegionUrlMap_ilbPathUpdate
  • TestAccComputeRegionUrlMap_ilbRouteUpdate
  • TestAccComputeRegionUrlMap_noPathRulesWithUpdate
  • TestAccComputeRegionUrlMap_regionUrlMapBasicExample
  • TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample
  • TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathExample
  • TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathPartialExample
  • TestAccComputeRegionUrlMap_regionUrlMapL7IlbRouteExample
  • TestAccComputeRegionUrlMap_regionUrlMapL7IlbRoutePartialExample
  • TestAccComputeRegionUrlMap_regionUrlMapPathTemplateMatchExample
  • TestAccComputeRegionUrlMap_update_path_matcher
  • TestAccComputeResourceUsageExportBucket
  • TestAccComputeRoute_routeIlbExample
  • TestAccComputeRoute_routeIlbVipExample
  • TestAccComputeServiceAttachment_serviceAttachmentBasicExample
  • TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate
  • TestAccComputeServiceAttachment_serviceAttachmentExplicitNetworksExample
  • TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample
  • TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample
  • TestAccComputeSharedReservation_update
  • TestAccComputeSharedVpc_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigQueryTable_schemaWithRequiredFieldAndView[Debug log]
TestAccCloudRunV2Job_cloudrunv2JobFullUpdate[Debug log]
TestAccCloudRunV2Job_cloudrunv2JobVpcaccessExample[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceGRPCProbesUpdate[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceVpcaccessExample[Debug log]
TestAccComputeBackendService_trafficDirectorUpdateBasic[Debug log]
TestAccComputeBackendService_trafficDirectorUpdateFull[Debug log]
TestAccComputeBackendService_trafficDirectorUpdateLbPolicies[Debug log]
TestAccComputeForwardingRule_forwardingRuleExternallbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example[Debug log]
TestAccComputeForwardingRule_forwardingRuleIpAddressIpv6[Debug log]
TestAccComputeForwardingRule_forwardingRuleL3DefaultExample[Debug log]
TestAccComputeForwardingRule_forwardingRulePscRecreate[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExampleUpdate[Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate[Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample[Debug log]
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate[Debug log]
TestAccComputePacketMirroring_computePacketMirroringFullExample[Debug log]
TestAccComputeRegionBackendService_basic[Debug log]
TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol[Debug log]
TestAccComputeRegionBackendService_ilbUpdateBasic[Debug log]
TestAccComputeRegionBackendService_ilbUpdateFull[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceCacheExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceExternalExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceExternalIapExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceExternalWeightedExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceIlbRingHashExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceIlbRoundRobinExample[Debug log]
TestAccComputeRegionBackendService_subsettingUpdate[Debug log]
TestAccComputeRegionBackendService_withBackendAndIAP[Debug log]
TestAccComputeRegionBackendService_withBackendInternal[Debug log]
TestAccComputeRegionBackendService_withBackendInternalManaged[Debug log]
TestAccComputeRegionBackendService_withBackendMultiNic[Debug log]
TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate[Debug log]
TestAccComputeRegionBackendService_withSecurityPolicy[Debug log]
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Debug log]
TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyBasicExample[Debug log]
TestAccComputeRegionTargetHttpProxy_update[Debug log]
TestAccComputeRegionTargetHttpsProxy_addSslPolicy_withForwardingRule[Debug log]
TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyBasicExample[Debug log]
TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyCertificateManagerCertificateExample[Debug log]
TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyMtlsExample[Debug log]
TestAccComputeRegionTargetHttpsProxy_update[Debug log]
TestAccComputeRegionTargetTcpProxy_regionTargetTcpProxyBasicExample[Debug log]
TestAccComputeRegionTargetTcpProxy_update[Debug log]
TestAccComputeRegionUrlMap_advanced[Debug log]
TestAccComputeRegionUrlMap_defaultRouteAction_full_update[Debug log]
TestAccComputeRegionUrlMap_ilbPathUpdate[Debug log]
TestAccComputeRegionUrlMap_ilbRouteUpdate[Debug log]
TestAccComputeRegionUrlMap_noPathRulesWithUpdate[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapBasicExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathPartialExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbRouteExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbRoutePartialExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapPathTemplateMatchExample[Debug log]
TestAccComputeRegionUrlMap_update_path_matcher[Debug log]
TestAccComputeRoute_routeIlbExample[Debug log]
TestAccComputeRoute_routeIlbVipExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitNetworksExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample[Debug log]
TestAccProject_abandon[Debug log]
TestAccProject_noAllowDestroy[Debug log]
TestAccPubsubTopic_schema[Debug log]
TestAccVPCAccessConnector_vpcAccessConnectorExample[Debug log]
TestAccVPCAccessConnector_vpcAccessConnectorSharedVpcExample[Debug log]
TestAccVPCAccessConnector_vpcAccessConnectorThroughput[Debug log]
TestAccVPCAccessConnector_vpcAccessConnectorThroughput_usingThroughputOrInstancesLimits[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineApplication_basic[Error message] [Debug log]
TestAccAppEngineApplication_withIAP[Error message] [Debug log]
TestAccAppEngineFirewallRule_appEngineFirewallRuleBasicExample[Error message] [Debug log]
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[Error message] [Debug log]
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]
TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]
TestAccComputeInstanceFromMachineImage_diffProject[Error message] [Debug log]
TestAccComputeNetworkAttachment_networkAttachmentBasicExample[Error message] [Debug log]
TestAccComputeNodeGroup_nodeGroupShareSettingsExample[Error message] [Debug log]
TestAccComputeProjectCloudArmorTier_withProjectSet[Error message] [Debug log]
TestAccComputeProjectDefaultNetworkTier_basic[Error message] [Debug log]
TestAccComputeProjectDefaultNetworkTier_modify[Error message] [Debug log]
TestAccComputeProjectMetadata_basic[Error message] [Debug log]
TestAccComputeProjectMetadata_modify_1[Error message] [Debug log]
TestAccComputeProjectMetadata_modify_2[Error message] [Debug log]
TestAccComputeResourceUsageExportBucket[Error message] [Debug log]
TestAccComputeSharedReservation_update[Error message] [Debug log]
TestAccComputeSharedVpc_basic[Error message] [Debug log]
TestAccDataSourceGoogleProjectService_basic[Error message] [Debug log]
TestAccDataSourceGoogleProject_basic[Error message] [Debug log]
TestAccProjectIamAuditConfig_addFirstExemptMember[Error message] [Debug log]
TestAccProjectIamAuditConfig_basic[Error message] [Debug log]
TestAccProjectIamAuditConfig_multiple[Error message] [Debug log]
TestAccProjectIamAuditConfig_removeLastExemptMember[Error message] [Debug log]
TestAccProjectIamAuditConfig_update[Error message] [Debug log]
TestAccProjectIamAuditConfig_updateNoExemptMembers[Error message] [Debug log]
TestAccProjectIamBinding_basic[Error message] [Debug log]
TestAccProjectIamBinding_invalidMembers[Error message] [Debug log]
TestAccProjectIamBinding_multiple[Error message] [Debug log]
TestAccProjectIamBinding_noMembers[Error message] [Debug log]
TestAccProjectIamBinding_update[Error message] [Debug log]
TestAccProjectIamBinding_withCondition[Error message] [Debug log]
TestAccProjectIamMemberRemove_basic[Error message] [Debug log]
TestAccProjectIamMemberRemove_memberInMultipleBindings[Error message] [Debug log]
TestAccProjectIamMemberRemove_multipleMembersInBinding[Error message] [Debug log]
TestAccProjectIamMember_basic[Error message] [Debug log]
TestAccProjectIamMember_invalidMembers[Error message] [Debug log]
TestAccProjectIamMember_withCondition[Error message] [Debug log]
TestAccProjectIamPolicy_basic[Error message] [Debug log]
TestAccProjectIamPolicy_basicAuditConfig[Error message] [Debug log]
TestAccProjectIamPolicy_emptyMembers[Error message] [Debug log]
TestAccProjectIamPolicy_expanded[Error message] [Debug log]
TestAccProjectIamPolicy_expandedAuditConfig[Error message] [Debug log]
TestAccProjectIamPolicy_invalidMembers[Error message] [Debug log]
TestAccProjectIamPolicy_withCondition[Error message] [Debug log]
TestAccProjectService_handleNotFound[Error message] [Debug log]
TestAccResourceGoogleProjectDefaultServiceAccountsBasic[Error message] [Debug log]
TestAccResourceGoogleProjectDefaultServiceAccountsDelete[Error message] [Debug log]
TestAccResourceGoogleProjectDefaultServiceAccountsDeleteRevertIgnoreFailure[Error message] [Debug log]
TestAccResourceGoogleProjectDefaultServiceAccountsDeprivilege[Error message] [Debug log]
TestAccResourceGoogleProjectDefaultServiceAccountsDisable[Error message] [Debug log]
TestAccResourceManagerLien_basic[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@zli82016
Copy link
Member

Can you also modify the resource doc? https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/website/docs/r/google_project.html.markdown?plain=1

Thanks.

@abd-goog abd-goog changed the base branch from FEATURE-BRANCH-major-release-6.0.0 to main July 26, 2024 13:49
@abd-goog abd-goog changed the base branch from main to FEATURE-BRANCH-major-release-6.0.0 July 26, 2024 13:49
@abd-goog abd-goog force-pushed the Tags-R2401-deletion-policy branch from e89cfb8 to 96da457 Compare July 29, 2024 09:48
@abd-goog abd-goog marked this pull request as ready for review July 29, 2024 09:55
@github-actions github-actions bot requested a review from trodge July 29, 2024 09:56
@github-actions GitHub Actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@abd-goog
Copy link
Member Author

@zli82016 could you please review? Thanks!

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 163 files changed, 506 insertions(+), 16 deletions(-))
google-beta provider: Diff ( 176 files changed, 539 insertions(+), 16 deletions(-))
terraform-google-conversion: Diff ( 6 files changed, 6 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field skip_delete within resource google_project was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 163 files changed, 506 insertions(+), 16 deletions(-))
google-beta provider: Diff ( 176 files changed, 539 insertions(+), 16 deletions(-))
terraform-google-conversion: Diff ( 6 files changed, 6 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field skip_delete within resource google_project was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@abd-goog
Copy link
Member Author

@trodge please feel free to skip this as it's a follow up from #11195 where @zli82016 already has context. Thanks.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2144
Passed tests: 1839
Skipped tests: 228
Affected tests: 77

Click here to see the affected service packages
  • oslogin
  • kms
  • resourcemanager
  • sql
  • binaryauthorization
  • compute
  • container
  • corebilling
  • dns
  • storage
  • serviceusage
  • apigee
  • documentaiwarehouse
  • gkehub2
  • iam2
  • integrationconnectors
  • cloudquotas
  • orgpolicy
  • vmwareengine
  • apphub
  • billing
  • firestore
  • logging
  • tags
  • vertexai
  • accesscontextmanager
  • appengine
  • firebase
  • firebaseappcheck
  • firebasedatabase
  • dialogflow
  • gkehub
  • monitoring
  • iap
  • identityplatform
  • servicenetworking

Action taken

Found 77 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeBackendService_trafficDirectorUpdateBasic
  • TestAccComputeBackendService_trafficDirectorUpdateFull
  • TestAccComputeBackendService_trafficDirectorUpdateLbPolicies
  • TestAccComputeForwardingRule_forwardingRuleExternallbExample
  • TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample
  • TestAccComputeForwardingRule_forwardingRuleHttpLbExample
  • TestAccComputeForwardingRule_forwardingRuleInternallbExample
  • TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example
  • TestAccComputeForwardingRule_forwardingRuleIpAddressIpv6
  • TestAccComputeForwardingRule_forwardingRuleL3DefaultExample
  • TestAccComputeForwardingRule_forwardingRulePscRecreate
  • TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample
  • TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExample
  • TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExampleUpdate
  • TestAccComputeForwardingRule_forwardingRuleVpcPscExample
  • TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate
  • TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample
  • TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample
  • TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample
  • TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate
  • TestAccComputePacketMirroring_computePacketMirroringFullExample
  • TestAccComputeRegionBackendService_basic
  • TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol
  • TestAccComputeRegionBackendService_ilbUpdateBasic
  • TestAccComputeRegionBackendService_ilbUpdateFull
  • TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample
  • TestAccComputeRegionBackendService_regionBackendServiceCacheExample
  • TestAccComputeRegionBackendService_regionBackendServiceExternalExample
  • TestAccComputeRegionBackendService_regionBackendServiceExternalWeightedExample
  • TestAccComputeRegionBackendService_regionBackendServiceIlbRingHashExample
  • TestAccComputeRegionBackendService_regionBackendServiceIlbRoundRobinExample
  • TestAccComputeRegionBackendService_subsettingUpdate
  • TestAccComputeRegionBackendService_withBackendAndIAP
  • TestAccComputeRegionBackendService_withBackendInternal
  • TestAccComputeRegionBackendService_withBackendInternalManaged
  • TestAccComputeRegionBackendService_withBackendMultiNic
  • TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate
  • TestAccComputeRegionBackendService_withSecurityPolicy
  • TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample
  • TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyBasicExample
  • TestAccComputeRegionTargetHttpProxy_update
  • TestAccComputeRegionTargetHttpsProxy_addSslPolicy_withForwardingRule
  • TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyBasicExample
  • TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyCertificateManagerCertificateExample
  • TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyMtlsExample
  • TestAccComputeRegionTargetHttpsProxy_update
  • TestAccComputeRegionTargetTcpProxy_regionTargetTcpProxyBasicExample
  • TestAccComputeRegionTargetTcpProxy_update
  • TestAccComputeRegionUrlMap_advanced
  • TestAccComputeRegionUrlMap_defaultRouteAction_full_update
  • TestAccComputeRegionUrlMap_ilbPathUpdate
  • TestAccComputeRegionUrlMap_ilbRouteUpdate
  • TestAccComputeRegionUrlMap_noPathRulesWithUpdate
  • TestAccComputeRegionUrlMap_regionUrlMapBasicExample
  • TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample
  • TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathExample
  • TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathPartialExample
  • TestAccComputeRegionUrlMap_regionUrlMapL7IlbRouteExample
  • TestAccComputeRegionUrlMap_regionUrlMapL7IlbRoutePartialExample
  • TestAccComputeRegionUrlMap_regionUrlMapPathTemplateMatchExample
  • TestAccComputeRegionUrlMap_update_path_matcher
  • TestAccComputeRoute_routeIlbExample
  • TestAccComputeRoute_routeIlbVipExample
  • TestAccComputeServiceAttachment_serviceAttachmentBasicExample
  • TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate
  • TestAccComputeServiceAttachment_serviceAttachmentExplicitNetworksExample
  • TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample
  • TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample
  • TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample
  • TestAccAppEngineFlexibleAppVersion_update
  • TestAccAppEngineStandardAppVersion_update
  • TestAccIapAppEngineServiceIamBindingGenerated
  • TestAccIapAppEngineServiceIamBindingGenerated_withCondition
  • TestAccIapAppEngineServiceIamMemberGenerated
  • TestAccIapAppEngineServiceIamMemberGenerated_withCondition
  • TestAccIapAppEngineServiceIamPolicyGenerated
  • TestAccIapAppEngineServiceIamPolicyGenerated_withCondition

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2144
Passed tests: 1839
Skipped tests: 228
Affected tests: 77

Click here to see the affected service packages
  • billing
  • firebaseappcheck
  • iap
  • servicenetworking
  • documentaiwarehouse
  • firestore
  • gkehub
  • gkehub2
  • iam2
  • vmwareengine
  • binaryauthorization
  • cloudquotas
  • dns
  • appengine
  • logging
  • apphub
  • dialogflow
  • firebase
  • integrationconnectors
  • monitoring
  • sql
  • storage
  • compute
  • corebilling
  • identityplatform
  • oslogin
  • resourcemanager
  • tags
  • container
  • kms
  • orgpolicy
  • accesscontextmanager
  • apigee
  • firebasedatabase
  • serviceusage
  • vertexai

Action taken

Found 77 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIapAppEngineServiceIamBindingGenerated
  • TestAccIapAppEngineServiceIamBindingGenerated_withCondition
  • TestAccIapAppEngineServiceIamMemberGenerated
  • TestAccIapAppEngineServiceIamMemberGenerated_withCondition
  • TestAccIapAppEngineServiceIamPolicyGenerated
  • TestAccIapAppEngineServiceIamPolicyGenerated_withCondition
  • TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample
  • TestAccAppEngineFlexibleAppVersion_update
  • TestAccAppEngineStandardAppVersion_update
  • TestAccComputeBackendService_trafficDirectorUpdateBasic
  • TestAccComputeBackendService_trafficDirectorUpdateFull
  • TestAccComputeBackendService_trafficDirectorUpdateLbPolicies
  • TestAccComputeForwardingRule_forwardingRuleExternallbExample
  • TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample
  • TestAccComputeForwardingRule_forwardingRuleHttpLbExample
  • TestAccComputeForwardingRule_forwardingRuleInternallbExample
  • TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example
  • TestAccComputeForwardingRule_forwardingRuleIpAddressIpv6
  • TestAccComputeForwardingRule_forwardingRuleL3DefaultExample
  • TestAccComputeForwardingRule_forwardingRulePscRecreate
  • TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample
  • TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExample
  • TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExampleUpdate
  • TestAccComputeForwardingRule_forwardingRuleVpcPscExample
  • TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate
  • TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample
  • TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample
  • TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample
  • TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate
  • TestAccComputePacketMirroring_computePacketMirroringFullExample
  • TestAccComputeRegionBackendService_basic
  • TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol
  • TestAccComputeRegionBackendService_ilbUpdateBasic
  • TestAccComputeRegionBackendService_ilbUpdateFull
  • TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample
  • TestAccComputeRegionBackendService_regionBackendServiceCacheExample
  • TestAccComputeRegionBackendService_regionBackendServiceExternalExample
  • TestAccComputeRegionBackendService_regionBackendServiceExternalWeightedExample
  • TestAccComputeRegionBackendService_regionBackendServiceIlbRingHashExample
  • TestAccComputeRegionBackendService_regionBackendServiceIlbRoundRobinExample
  • TestAccComputeRegionBackendService_subsettingUpdate
  • TestAccComputeRegionBackendService_withBackendAndIAP
  • TestAccComputeRegionBackendService_withBackendInternal
  • TestAccComputeRegionBackendService_withBackendInternalManaged
  • TestAccComputeRegionBackendService_withBackendMultiNic
  • TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate
  • TestAccComputeRegionBackendService_withSecurityPolicy
  • TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample
  • TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyBasicExample
  • TestAccComputeRegionTargetHttpProxy_update
  • TestAccComputeRegionTargetHttpsProxy_addSslPolicy_withForwardingRule
  • TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyBasicExample
  • TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyCertificateManagerCertificateExample
  • TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyMtlsExample
  • TestAccComputeRegionTargetHttpsProxy_update
  • TestAccComputeRegionTargetTcpProxy_regionTargetTcpProxyBasicExample
  • TestAccComputeRegionTargetTcpProxy_update
  • TestAccComputeRegionUrlMap_advanced
  • TestAccComputeRegionUrlMap_defaultRouteAction_full_update
  • TestAccComputeRegionUrlMap_ilbPathUpdate
  • TestAccComputeRegionUrlMap_ilbRouteUpdate
  • TestAccComputeRegionUrlMap_noPathRulesWithUpdate
  • TestAccComputeRegionUrlMap_regionUrlMapBasicExample
  • TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample
  • TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathExample
  • TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathPartialExample
  • TestAccComputeRegionUrlMap_regionUrlMapL7IlbRouteExample
  • TestAccComputeRegionUrlMap_regionUrlMapL7IlbRoutePartialExample
  • TestAccComputeRegionUrlMap_regionUrlMapPathTemplateMatchExample
  • TestAccComputeRegionUrlMap_update_path_matcher
  • TestAccComputeRoute_routeIlbExample
  • TestAccComputeRoute_routeIlbVipExample
  • TestAccComputeServiceAttachment_serviceAttachmentBasicExample
  • TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate
  • TestAccComputeServiceAttachment_serviceAttachmentExplicitNetworksExample
  • TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample
  • TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeBackendService_trafficDirectorUpdateBasic[Debug log]
TestAccComputeBackendService_trafficDirectorUpdateFull[Debug log]
TestAccComputeBackendService_trafficDirectorUpdateLbPolicies[Debug log]
TestAccComputeForwardingRule_forwardingRuleExternallbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example[Debug log]
TestAccComputeForwardingRule_forwardingRuleIpAddressIpv6[Debug log]
TestAccComputeForwardingRule_forwardingRuleL3DefaultExample[Debug log]
TestAccComputeForwardingRule_forwardingRulePscRecreate[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExampleUpdate[Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate[Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample[Debug log]
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate[Debug log]
TestAccComputePacketMirroring_computePacketMirroringFullExample[Debug log]
TestAccComputeRegionBackendService_basic[Debug log]
TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol[Debug log]
TestAccComputeRegionBackendService_ilbUpdateBasic[Debug log]
TestAccComputeRegionBackendService_ilbUpdateFull[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceCacheExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceExternalExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceExternalWeightedExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceIlbRingHashExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceIlbRoundRobinExample[Debug log]
TestAccComputeRegionBackendService_subsettingUpdate[Debug log]
TestAccComputeRegionBackendService_withBackendAndIAP[Debug log]
TestAccComputeRegionBackendService_withBackendInternal[Debug log]
TestAccComputeRegionBackendService_withBackendInternalManaged[Debug log]
TestAccComputeRegionBackendService_withBackendMultiNic[Debug log]
TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate[Debug log]
TestAccComputeRegionBackendService_withSecurityPolicy[Debug log]
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Debug log]
TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyBasicExample[Debug log]
TestAccComputeRegionTargetHttpProxy_update[Debug log]
TestAccComputeRegionTargetHttpsProxy_addSslPolicy_withForwardingRule[Debug log]
TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyBasicExample[Debug log]
TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyCertificateManagerCertificateExample[Debug log]
TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyMtlsExample[Debug log]
TestAccComputeRegionTargetHttpsProxy_update[Debug log]
TestAccComputeRegionTargetTcpProxy_regionTargetTcpProxyBasicExample[Debug log]
TestAccComputeRegionTargetTcpProxy_update[Debug log]
TestAccComputeRegionUrlMap_advanced[Debug log]
TestAccComputeRegionUrlMap_defaultRouteAction_full_update[Debug log]
TestAccComputeRegionUrlMap_ilbPathUpdate[Debug log]
TestAccComputeRegionUrlMap_ilbRouteUpdate[Debug log]
TestAccComputeRegionUrlMap_noPathRulesWithUpdate[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapBasicExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathPartialExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbRouteExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbRoutePartialExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapPathTemplateMatchExample[Debug log]
TestAccComputeRegionUrlMap_update_path_matcher[Debug log]
TestAccComputeRoute_routeIlbExample[Debug log]
TestAccComputeRoute_routeIlbVipExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitNetworksExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[Error message] [Debug log]
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]
TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeBackendService_trafficDirectorUpdateBasic[Debug log]
TestAccComputeBackendService_trafficDirectorUpdateFull[Debug log]
TestAccComputeBackendService_trafficDirectorUpdateLbPolicies[Debug log]
TestAccComputeForwardingRule_forwardingRuleExternallbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example[Debug log]
TestAccComputeForwardingRule_forwardingRuleIpAddressIpv6[Debug log]
TestAccComputeForwardingRule_forwardingRuleL3DefaultExample[Debug log]
TestAccComputeForwardingRule_forwardingRulePscRecreate[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExampleUpdate[Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate[Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample[Debug log]
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate[Debug log]
TestAccComputePacketMirroring_computePacketMirroringFullExample[Debug log]
TestAccComputeRegionBackendService_basic[Debug log]
TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol[Debug log]
TestAccComputeRegionBackendService_ilbUpdateBasic[Debug log]
TestAccComputeRegionBackendService_ilbUpdateFull[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceCacheExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceExternalExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceExternalWeightedExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceIlbRingHashExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceIlbRoundRobinExample[Debug log]
TestAccComputeRegionBackendService_subsettingUpdate[Debug log]
TestAccComputeRegionBackendService_withBackendAndIAP[Debug log]
TestAccComputeRegionBackendService_withBackendInternal[Debug log]
TestAccComputeRegionBackendService_withBackendInternalManaged[Debug log]
TestAccComputeRegionBackendService_withBackendMultiNic[Debug log]
TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate[Debug log]
TestAccComputeRegionBackendService_withSecurityPolicy[Debug log]
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Debug log]
TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyBasicExample[Debug log]
TestAccComputeRegionTargetHttpProxy_update[Debug log]
TestAccComputeRegionTargetHttpsProxy_addSslPolicy_withForwardingRule[Debug log]
TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyBasicExample[Debug log]
TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyCertificateManagerCertificateExample[Debug log]
TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyMtlsExample[Debug log]
TestAccComputeRegionTargetHttpsProxy_update[Debug log]
TestAccComputeRegionTargetTcpProxy_regionTargetTcpProxyBasicExample[Debug log]
TestAccComputeRegionTargetTcpProxy_update[Debug log]
TestAccComputeRegionUrlMap_advanced[Debug log]
TestAccComputeRegionUrlMap_defaultRouteAction_full_update[Debug log]
TestAccComputeRegionUrlMap_ilbPathUpdate[Debug log]
TestAccComputeRegionUrlMap_ilbRouteUpdate[Debug log]
TestAccComputeRegionUrlMap_noPathRulesWithUpdate[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapBasicExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathPartialExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbRouteExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbRoutePartialExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapPathTemplateMatchExample[Debug log]
TestAccComputeRegionUrlMap_update_path_matcher[Debug log]
TestAccComputeRoute_routeIlbExample[Debug log]
TestAccComputeRoute_routeIlbVipExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitNetworksExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[Error message] [Debug log]
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]
TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@abd-goog
Copy link
Member Author

TestAccIapAppEngineServiceIamBindingGenerated
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[Error message] [Debug log]
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]
TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Error message] [Debug log]

Failing tests seem to be unrelated to the change.

@zli82016 zli82016 requested review from zli82016 and removed request for trodge July 29, 2024 16:31
@zli82016 zli82016 added the override-breaking-change Allows a potential breaking change to be merged label Jul 29, 2024
@github-actions github-actions bot requested a review from zli82016 July 31, 2024 04:58
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 163 files changed, 504 insertions(+), 16 deletions(-))
google-beta provider: Diff ( 176 files changed, 537 insertions(+), 16 deletions(-))
terraform-google-conversion: Diff ( 6 files changed, 6 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field skip_delete within resource google_project was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 163 files changed, 504 insertions(+), 16 deletions(-))
google-beta provider: Diff ( 176 files changed, 537 insertions(+), 16 deletions(-))
terraform-google-conversion: Diff ( 6 files changed, 6 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field skip_delete within resource google_project was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2144
Passed tests: 1907
Skipped tests: 228
Affected tests: 9

Click here to see the affected service packages
  • resourcemanager
  • tags
  • apigee
  • firebase
  • firestore
  • iam2
  • vmwareengine
  • documentaiwarehouse
  • firebasedatabase
  • gkehub
  • iap
  • container
  • dns
  • logging
  • oslogin
  • appengine
  • compute
  • servicenetworking
  • serviceusage
  • cloudquotas
  • corebilling
  • dialogflow
  • gkehub2
  • storage
  • billing
  • binaryauthorization
  • firebaseappcheck
  • monitoring
  • identityplatform
  • kms
  • sql
  • vertexai
  • accesscontextmanager
  • apphub
  • integrationconnectors
  • orgpolicy

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIapAppEngineServiceIamBindingGenerated
  • TestAccIapAppEngineServiceIamBindingGenerated_withCondition
  • TestAccIapAppEngineServiceIamMemberGenerated
  • TestAccIapAppEngineServiceIamMemberGenerated_withCondition
  • TestAccIapAppEngineServiceIamPolicyGenerated
  • TestAccIapAppEngineServiceIamPolicyGenerated_withCondition
  • TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample
  • TestAccAppEngineFlexibleAppVersion_update
  • TestAccAppEngineStandardAppVersion_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 160 files changed, 403 insertions(+), 38 deletions(-))
google-beta provider: Diff ( 174 files changed, 438 insertions(+), 38 deletions(-))
terraform-google-conversion: Diff ( 6 files changed, 6 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • accesscontextmanager
  • binaryauthorization
  • dialogflow
  • documentaiwarehouse
  • gkehub2
  • corebilling
  • gkehub
  • iap
  • integrationconnectors
  • cloudquotas
  • firebase
  • compute
  • identityplatform
  • vmwareengine
  • apigee
  • appengine
  • firebaseappcheck
  • firestore
  • oslogin
  • resourcemanager
  • servicenetworking
  • serviceusage
  • sql
  • storage
  • tags
  • iam2
  • orgpolicy
  • vertexai
  • apphub
  • container
  • dns
  • kms
  • logging
  • monitoring
  • billing
  • firebasedatabase

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 160 files changed, 398 insertions(+), 41 deletions(-))
google-beta provider: Diff ( 174 files changed, 433 insertions(+), 41 deletions(-))
terraform-google-conversion: Diff ( 6 files changed, 6 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field deletion_policy default value changed from DELETE to PREVENT on google_project - reference
  • Field skip_delete within resource google_project was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2148
Passed tests: 1914
Skipped tests: 226
Affected tests: 8

Click here to see the affected service packages
  • firestore
  • iam2
  • sql
  • vmwareengine
  • container
  • documentaiwarehouse
  • identityplatform
  • kms
  • servicenetworking
  • vertexai
  • firebasedatabase
  • iap
  • billing
  • tags
  • accesscontextmanager
  • appengine
  • gkehub
  • logging
  • apphub
  • firebaseappcheck
  • integrationconnectors
  • orgpolicy
  • serviceusage
  • storage
  • apigee
  • gkehub2
  • corebilling
  • dns
  • cloudquotas
  • compute
  • monitoring
  • firebase
  • oslogin
  • resourcemanager
  • binaryauthorization
  • dialogflow

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate
  • TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy
  • TestAccComputeRegionTargetHttpsProxy_addSslPolicy_withForwardingRule
  • TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyBasicExample
  • TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyCertificateManagerCertificateExample
  • TestAccComputeRegionTargetHttpsProxy_update
  • TestAccProjectService_checkUsageOfServices
  • TestAccServiceNetworkingConnection_updateOnCreationFail

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate[Debug log]
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]
TestAccComputeRegionTargetHttpsProxy_addSslPolicy_withForwardingRule[Debug log]
TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyBasicExample[Debug log]
TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyCertificateManagerCertificateExample[Debug log]
TestAccComputeRegionTargetHttpsProxy_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccProjectService_checkUsageOfServices[Error message] [Debug log]
TestAccServiceNetworkingConnection_updateOnCreationFail[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@abd-goog abd-goog changed the title Add deletion_policy field to Project resource Make deletion_policy field for Project resource default to PREVENT Aug 12, 2024
@abd-goog abd-goog changed the title Make deletion_policy field for Project resource default to PREVENT Make deletion_policy field for Project resource PREVENT by default Aug 12, 2024
@abd-goog
Copy link
Member Author

@zli82016 could you please review again now that release branch has synced?
Thanks.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 160 files changed, 399 insertions(+), 41 deletions(-))
google-beta provider: Diff ( 174 files changed, 435 insertions(+), 41 deletions(-))
terraform-google-conversion: Diff ( 6 files changed, 6 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field deletion_policy default value changed from DELETE to PREVENT on google_project - reference
  • Field skip_delete within resource google_project was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2148
Passed tests: 1921
Skipped tests: 226
Affected tests: 1

Click here to see the affected service packages
  • appengine
  • cloudquotas
  • monitoring
  • oslogin
  • firebaseappcheck
  • orgpolicy
  • accesscontextmanager
  • iam2
  • logging
  • iap
  • integrationconnectors
  • sql
  • apphub
  • dialogflow
  • dns
  • firestore
  • gkehub2
  • vertexai
  • gkehub
  • resourcemanager
  • tags
  • billing
  • binaryauthorization
  • documentaiwarehouse
  • vmwareengine
  • apigee
  • container
  • firebase
  • identityplatform
  • kms
  • storage
  • compute
  • corebilling
  • firebasedatabase
  • servicenetworking
  • serviceusage

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

@github-actions github-actions bot requested a review from zli82016 August 13, 2024 05:39
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 160 files changed, 406 insertions(+), 41 deletions(-))
google-beta provider: Diff ( 174 files changed, 442 insertions(+), 41 deletions(-))
terraform-google-conversion: Diff ( 6 files changed, 6 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field deletion_policy default value changed from DELETE to PREVENT on google_project - reference
  • Field skip_delete within resource google_project was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2148
Passed tests: 1922
Skipped tests: 226
Affected tests: 0

Click here to see the affected service packages
  • accesscontextmanager
  • kms
  • storage
  • cloudquotas
  • dialogflow
  • firebase
  • firebasedatabase
  • gkehub2
  • apphub
  • binaryauthorization
  • compute
  • dns
  • documentaiwarehouse
  • firebaseappcheck
  • integrationconnectors
  • servicenetworking
  • appengine
  • billing
  • gkehub
  • iam2
  • oslogin
  • container
  • corebilling
  • firestore
  • iap
  • logging
  • apigee
  • vertexai
  • orgpolicy
  • resourcemanager
  • serviceusage
  • sql
  • tags
  • identityplatform
  • monitoring
  • vmwareengine

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

zli82016
zli82016 approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zli82016 zli82016 merged commit 9905a08 into GoogleCloudPlatform:FEATURE-BRANCH-major-release-6.0.0 Aug 13, 2024
8 checks passed
This was referenced Aug 13, 2024
Merged
Merged
Merged
zli82016 added a commit to zli82016/magic-modules that referenced this pull request Aug 13, 2024
@abd-goog @zli82016
Make deletion_policy field for Project resource PREVENT by default (G…
6cadd80 
…oogleCloudPlatform#11255)

Co-authored-by: Zhenhua Li <[email protected]>
@rileykarson rileykarson mentioned this pull request Aug 15, 2024
Merged
@zli82016 zli82016 mentioned this pull request Aug 15, 2024
Merged
This was referenced Aug 16, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zli82016 zli82016 zli82016 approved these changes

Assignees
No one assigned
Labels
override-breaking-change Allows a potential breaking change to be merged service/terraform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abd-goog @modular-magician @zli82016 @c2thorn