Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove project dependency from TestAccApikeysKey_* #19167

Conversation

modular-magician
Copy link
Collaborator

After deletion_policy is defaulted to PREVENT in google_project resource in GoogleCloudPlatform/magic-modules#11255, the tests TestAccApikeysKey_* started failing as the projects are prevented to be deleted by default.

Nightly testing results

I don't think it's necessary to create a new project in these tests, so remove the project dependency to fix the tests.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#11462

[upstream:372b7c7f15383798536573ebe662c099ac2819d1]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 27bd150 into hashicorp:FEATURE-BRANCH-major-release-6.0.0 Aug 16, 2024
2 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2024
@modular-magician modular-magician deleted the downstream-pr-372b7c7f15383798536573ebe662c099ac2819d1 branch November 17, 2024 01:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant