Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make deletion_policy field for Project resource PREVENT by default #19114

Conversation

modular-magician
Copy link
Collaborator

Make deletion_policy field 'PREVENT' by default to make deletion actions require an explicit intent.
Deprecate skip_delete field in favor of this change.
Part of b/330143705

Part of #18775

Release Note Template for Downstream PRs (will be copied)

resourcemanager: Make `deletion-policy` in `google_project` 'PREVENT' by default. This makes deleting them require an explicit intent. `google_project` resources cannot be destroyed unless `deletion_policy` is set to 'ABANDON' or 'NONE' for the resource.

Derived from GoogleCloudPlatform/magic-modules#11255

…ashicorp#11255)

Co-authored-by: Zhenhua Li <[email protected]>

[upstream:9905a08d80a5fc0bc137ae2cb06bac27e29678ac]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 940f3f6 into hashicorp:FEATURE-BRANCH-major-release-6.0.0 Aug 13, 2024
3 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2024
@modular-magician modular-magician deleted the downstream-pr-9905a08d80a5fc0bc137ae2cb06bac27e29678ac branch November 17, 2024 01:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant