reduce name prefix in compute resources

[c2thorn]

fixes hashicorp/terraform-provider-google#15374

conditionally use a shortened UUID prefix when provided a name_prefix of over 37 characters

Release Note Template for Downstream PRs (will be copied)

compute: changed the behavior of `name_prefix` in multiple Compute resources to allow for a longer max length of 54 characters. See the upgrade guide and resource documentation for more details.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 12 files changed, 155 insertions(+), 24 deletions(-))
google-beta provider: Diff ( 12 files changed, 155 insertions(+), 24 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 18 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3895
Passed tests: 3501
Skipped tests: 384
Affected tests: 10

Click here to see the affected service packages

All service packages are affected

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccApikeysKey_AndroidKey
• TestAccApikeysKey_BasicKey
• TestAccApikeysKey_IosKey
• TestAccApikeysKey_MinimalKey
• TestAccApikeysKey_ServerKey
• TestAccCloudRunV2Job_cloudrunv2JobFullUpdate
• TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate
• TestAccComputeInstance_bootDisk_storagePoolSpecified
• TestAccDataSourceArtifactRegistryDockerImage
• TestAccNetworkServicesLbRouteExtension_update

Get to know how VCR tests work

[c2thorn]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 12 files changed, 155 insertions(+), 24 deletions(-))
google-beta provider: Diff ( 12 files changed, 155 insertions(+), 24 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 18 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3894
Passed tests: 3501
Skipped tests: 384
Affected tests: 9

Click here to see the affected service packages

All service packages are affected

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccApikeysKey_AndroidKey
• TestAccApikeysKey_BasicKey
• TestAccApikeysKey_IosKey
• TestAccApikeysKey_MinimalKey
• TestAccApikeysKey_ServerKey
• TestAccComputeDisk_storagePoolSpecified
• TestAccComputeInstance_bootDisk_storagePoolSpecified
• TestAccDataSourceArtifactRegistryDockerImage
• TestAccNetworkServicesLbRouteExtension_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeDisk_storagePoolSpecified[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccApikeysKey_AndroidKey[Error message] [Debug log]
TestAccApikeysKey_BasicKey[Error message] [Debug log]
TestAccApikeysKey_IosKey[Error message] [Debug log]
TestAccApikeysKey_MinimalKey[Error message] [Debug log]
TestAccApikeysKey_ServerKey[Error message] [Debug log]
TestAccComputeInstance_bootDisk_storagePoolSpecified[Error message] [Debug log]
TestAccDataSourceArtifactRegistryDockerImage[Error message] [Debug log]
TestAccNetworkServicesLbRouteExtension_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[rileykarson]

@zli82016 could you follow up on the failed project deletions when you get a chance? (we may want to check the nightlies if they exist since #11255 was merged)

[zli82016]

@zli82016 could you follow up on the failed project deletions when you get a chance? (we may want to check the nightlies if they exist since #11255 was merged)

Sure, I will check it.

[zli82016]

The tests TestAccApikeysKey_* also failed in the GA nightly 6.0 major release testing. They are DCL generated tests. I am going to fix them and others if any.

[zli82016]

The tests TestAccApikeysKey_* are going to be fixed in #11462