Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make deletion_policy field for Project resource PREVENT by default #2657

Conversation

modular-magician
Copy link
Collaborator

Make deletion_policy field 'PREVENT' by default to make deletion actions require an explicit intent.
Deprecate skip_delete field in favor of this change.
Part of b/330143705

Part of hashicorp/terraform-provider-google#18775

Release Note Template for Downstream PRs (will be copied)

resourcemanager: Make `deletion-policy` in `google_project` 'PREVENT' by default. This makes deleting them require an explicit intent. `google_project` resources cannot be destroyed unless `deletion_policy` is set to 'ABANDON' or 'NONE' for the resource.

Derived from GoogleCloudPlatform/magic-modules#11255

…(#11255)

Co-authored-by: Zhenhua Li <[email protected]>

[upstream:9905a08d80a5fc0bc137ae2cb06bac27e29678ac]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner August 13, 2024 16:01
@modular-magician modular-magician requested review from shuyama1 and removed request for a team August 13, 2024 16:01
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician merged commit 07b441d into GoogleCloudPlatform:FEATURE-BRANCH-major-release-6.0.0 Aug 13, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant