Complete Task Front End #18806

thienlnam · 2023-05-11T23:08:09Z

Details

Fixed Issues

$ #16858
PROPOSAL: GH_LINK_ISSUE(COMMENT)

Tests

Verify that no errors appear in the JS console

Create a task
Select 'Mark as done'
Notice you see the task change to 'Completed'
Go back to the parent chat where the task was created
Notice there is a completed checkbox
Create a task
Go back to the parent chat where the task was created
Hit the checkbox to 'complete' the task
Notice that it says marked
Open the task
Verify you see the task is marked as 'Completed'

Offline tests

Same as online

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-05-15.at.9.09.50.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-05-15.at.9.10.31.AM.mov

Mobile Web - Safari

Desktop

Screen.Recording.2023-05-15.at.9.12.39.AM.mov

iOS

Android

fedirjh · 2023-05-14T22:48:46Z

Could you please merge main. latest changes for update task are not present yet . I noticed this , there is two button , mark as complete and mark as done , is there any difference ?

Screen.Recording.2023-05-14.at.11.27.26.PM.mov

alex-mechler · 2023-05-15T20:58:13Z

src/languages/es.js

+    task: {
+        completed: 'Completada',
+        messages: {
+            completed: 'tarea completada',


Should Tarea be capitalized? in the english translations we have Completed as capitalized

Good catch, @arosiclair since this is small, could you also add this onto your PR for cancel task?

OSBotify · 2023-05-15T21:07:18Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-17T01:09:00Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.3.15-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

isagoico · 2023-05-17T22:57:25Z

@thienlnam Hi! We found these 2 issues when executing this PR

#19150
#19149

OSBotify · 2023-05-18T06:52:11Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.15-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mananjadhav · 2023-06-01T16:25:24Z

When we added MenuItemWithTopDescription we didn't use translation for Task and Description. Hence this resulted in #18690.

I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

We have the checklist item, but I think we still missed adding for these two labels.

mollfpr · 2023-06-29T06:30:13Z

✋ Coming from #19631

The assignee name/email is empty for the non-assignee or non-owner user on the task header.

sobitneupane · 2023-07-03T08:00:03Z

This small issue was not handled in this PR while adding Task Header.

Issue: Only description's text has reduced opacity when it's disabled

sobitneupane · 2023-07-24T14:57:11Z

This issue was not handled in this PR while adding lastMessageText.

Issue: Reopened task message does not translate to Spanish in LHN

s77rt · 2023-07-26T22:58:31Z

src/components/TaskHeader.js

+                                        <Avatar
+                                            source={assigneeAvatar}
+                                            type={CONST.ICON_TYPE_AVATAR}
+                                            name={assigneeName}
+                                            size={CONST.AVATAR_SIZE.HEADER}
+                                        />


This caused a regression. Previously we used TaskSelectorLink -> MultipleAvatars. And MultipleAvatars wraps the Avatar with a Tooltip

App/src/components/MultipleAvatars.js

Line 69 in 5743b15

<Tooltip text={props.avatarTooltips[0]}>

Now we are missing the tooltip (Coming from #21713).

s77rt · 2023-08-13T00:42:19Z

src/libs/actions/Task.js

+            onyxMethod: Onyx.METHOD.MERGE,
+            key: `${ONYXKEYS.COLLECTION.REPORT}${parentReportID}`,
+            value: {
+                lastVisibleActionCreated: completedTaskReportAction.created,
+                lastMessageText: message,
+                lastActorEmail: completedTaskReportAction.actorEmail,
+            },


This is missing the childVisibleActionCount to update the number of replies in the thread.

rushatgabhane · 2023-11-12T23:38:57Z

src/components/ReportActionItem/TaskPreview.js

@@ -68,7 +70,10 @@ const TaskPreview = (props) => {
                    containerStyle={[styles.taskCheckbox]}
                    isChecked={isTaskCompleted}
                    onPress={() => {


Coming from Unauthorized Task Reopening by Anonymous User in Incognito Mode- Inconsistency

We should have checked if an anonymous user is trying to mark a task as completed.

The implementation of the anonymous user was done after this PR :

Open report for anonymous users #18293

thienlnam added 5 commits May 11, 2023 15:25

Add TASKCOMPLETED constant

b48c214

Add new method for task actions

15e0001

Create completeTask command

ae1562a

Hook up functionality to complete task

f815004

Update TaskPreview.js

c75c420

thienlnam self-assigned this May 11, 2023

thienlnam changed the title ~~Create Task Front End~~ Complete Task Front End May 11, 2023

thienlnam added 12 commits May 11, 2023 16:36

add grabbing the parentReportID

d125fe4

add new taskAction component

92ddb6f

render on demand

3ad9fff

add copy for completed task

90a0df4

update task action to pass in actionName

50a2b4d

Update ReportActionItem.js

e0b4d7b

Merge in IR Dan changes

5e623a0

Merge branch 'main' into jack-completeTask

91b25f2

add new component task header

6a7f609

add task header

4ff1e73

update assignee to managerEmail

9ea845c

start adding description to task header

d9541bf

thienlnam mentioned this pull request May 13, 2023

Edit Task Front End #18672

Merged

63 tasks

thienlnam added 9 commits May 13, 2023 15:45

Pass in threeDot menu items

6beeda2

add mark as done button

6c967e7

Add complete task

eb93804

prevent calling when completed

0c9cc8e

Update ReportScreen.js

5383bce

fix bug with preview not loading

28ca867

fix up completeTask

48d3b0d

update the method

7bdebbf

add taskAction

f6cc64c

arosiclair approved these changes May 15, 2023

View reviewed changes

arosiclair merged commit 92f87f7 into main May 15, 2023

arosiclair deleted the jack-completeTask branch May 15, 2023 21:01

alex-mechler reviewed May 15, 2023

View reviewed changes

thienlnam mentioned this pull request May 16, 2023

Fix crash with task action hover #19065

Merged

57 tasks

OSBotify mentioned this pull request May 16, 2023

Deploy Checklist: New Expensify 2023-05-16 #19088

Closed

71 tasks

This was referenced May 17, 2023

Separate chats are left in LHN after completing task until login/logout #19149

Closed

Task title is not displayed in parent chat after sign out / sign in #19150

Closed

mvtglobally mentioned this pull request May 17, 2023

[HELD ON #19298] \[$1000] Unchecking done assignment is not reflected on check-mark #19153

Closed

6 tasks

melvin-bot bot mentioned this pull request May 18, 2023

[HOLD for payment 2023-05-25] CompleteTask Front-End #16858

Closed

situchan mentioned this pull request May 25, 2023

[HOLD for payment 2023-06-07] [$1000] DEV: Console error on click Continue button in login page #19202

Closed

6 tasks

mananjadhav mentioned this pull request Jun 1, 2023

[HOLD for payment 2023-06-01] [$1000] Assign task - Title and Description in Welcome page is in English in Spanish account #18690

Closed

6 tasks

dhairyasenjaliya mentioned this pull request Jun 6, 2023

[CLOSED FOR PROPOSALS] Removes assignee on Edit task title #20234

Closed

6 tasks

mollfpr mentioned this pull request Jun 29, 2023

[HOLD for payment 2023-06-29] [$1000] Strange UX when creating tasks in a DM #19631

Closed

6 tasks

sobitneupane mentioned this pull request Jul 3, 2023

[HOLD for payment 2023-06-21] [$1000] Dev: Only description's text has reduced opacity when it's disabled #19232

Closed

6 tasks

sobitneupane mentioned this pull request Jul 24, 2023

[HOLD for payment 2023-07-20] [$1000] Reopened task message does not translate to Spanish in LHN #21563

Closed

6 tasks

s77rt reviewed Jul 26, 2023

View reviewed changes

s77rt mentioned this pull request Jul 26, 2023

[HOLD for payment 2023-08-02] [$1000] Web - Tooltip not visible for task assignee #21713

Closed

6 tasks

s77rt reviewed Aug 13, 2023

View reviewed changes

s77rt mentioned this pull request Aug 13, 2023

[HOLD for payment 2023-08-17] [$1000] Replies count doesn't update on a task shared in group. #23920

Closed

6 tasks

rushatgabhane reviewed Nov 12, 2023

View reviewed changes

rushatgabhane mentioned this pull request Nov 12, 2023

[C+ Checklist Needs Completion] [$1000] Web - Unauthorized Task Reopening by Anonymous User in Incognito Mode- Inconsistency #23114

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Complete Task Front End #18806

Complete Task Front End #18806

thienlnam commented May 11, 2023 •

edited

Loading

fedirjh commented May 14, 2023

alex-mechler May 15, 2023

thienlnam May 15, 2023

OSBotify commented May 15, 2023

OSBotify commented May 17, 2023

isagoico commented May 17, 2023

OSBotify commented May 18, 2023

mananjadhav commented Jun 1, 2023 •

edited

Loading

mollfpr commented Jun 29, 2023

sobitneupane commented Jul 3, 2023

sobitneupane commented Jul 24, 2023

s77rt Jul 26, 2023

s77rt Aug 13, 2023

rushatgabhane Nov 12, 2023

fedirjh Nov 13, 2023

Complete Task Front End #18806

Complete Task Front End #18806

Conversation

thienlnam commented May 11, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

fedirjh commented May 14, 2023

alex-mechler May 15, 2023

Choose a reason for hiding this comment

thienlnam May 15, 2023

Choose a reason for hiding this comment

OSBotify commented May 15, 2023

OSBotify commented May 17, 2023

isagoico commented May 17, 2023

OSBotify commented May 18, 2023

mananjadhav commented Jun 1, 2023 • edited Loading

mollfpr commented Jun 29, 2023

sobitneupane commented Jul 3, 2023

sobitneupane commented Jul 24, 2023

s77rt Jul 26, 2023

Choose a reason for hiding this comment

s77rt Aug 13, 2023

Choose a reason for hiding this comment

rushatgabhane Nov 12, 2023

Choose a reason for hiding this comment

fedirjh Nov 13, 2023

Choose a reason for hiding this comment

thienlnam commented May 11, 2023 •

edited

Loading

mananjadhav commented Jun 1, 2023 •

edited

Loading