[HOLD for payment 2023-06-01] [$1000] Assign task - Title and Description in Welcome page is in English in Spanish account

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

Preconditional: you can use Spanish account

1. Go to URL https://staging.new.expensify.com/
2. Login with any Expensifail account
3. Click the global create menu and select 'Assign Task'
4. Enter a title and description and navigate to next page
5. Click on the "Assignee" and select and Assignee
6. Click "Confirm Task"

Expected Result:

Title and Description in Welcome page is in Spanish

Actual Result:

Title and Description in Welcome page is in English

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.12.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6048748_Recording__4490.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a5e1781ac0818102
• Upwork Job ID: 1658653285947367424
• Last Price Increase: 2023-05-17

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Incorrect translation of the Assign Task on the Report page

What is the root cause of that problem?

The root cause is that we're not making use of translation keys in the description prop of the MenuItemWithTopDescription component. This can be seen here.

What changes do you think we should make in order to solve the problem?

We have to use translated text in the description prop for MenuItemWithTopDescription component here.
This gets replaced with:

                description={props.translate('newTaskPage.task')}

This gets replaced with:

                description={props.translate('newTaskPage.description')}

In order to use translate function, we'll also have to wrap TaskHeaderView component in the withLocalize HOC and add withLocalizePropTypes in the propTypes.

What alternative solutions did you explore? (Optional)

None

[maddylewis]

back from OOO will action today

[maddylewis]

i can repro this:

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a5e1781ac0818102

[melvin-bot]

Current assignee @maddylewis is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

Triggered auto assignment to @aldo-expensify (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mananjadhav]

Thanks for the patience here. @allroundexperts's proposal looks good to implement here.

@aldo-expensify All yours.

[aldo-expensify]

Thanks @mananjadhav . Hiring @allroundexperts

[melvin-bot]

📣 @allroundexperts You have been assigned to this job by @aldo-expensify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[allroundexperts]

PR created #19223

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.17-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• feat: fix description and task translations on task page #19223

If no regressions arise, payment will be issued on 2023-06-01. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav / @allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav / @allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav / @allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav / @allroundexperts] Determine if we should create a regression test for this bug.
• [@mananjadhav / @allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@maddylewis] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mananjadhav]

@maddylewis Here's the items from the checklist. This is ready for payout today.

#18806 is the PR. We didn't add the translation in the MenuItemWithTopDescription components. I've added the comment on the PR #18806 (comment)

I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

I don't think we need a discussion in the channel, and we already have an item in the checklist for this.

Also I don't think we need a regression test for this one. @aldo-expensify let me know if you think otherwise.

[maddylewis]

Payments

• no reporting bonus
• @mananjadhav (C+) - $1000
• @allroundexperts - $1000

[maddylewis]

offers sent!

[mananjadhav]

@maddylewis this is eligible for timeline bonus I guess

[maddylewis]

got it - i included bonuses for both @mananjadhav and @allroundexperts

[maddylewis]

i believe we're all set here - closing!