Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Task Front End #18806

Merged
merged 39 commits into from
May 15, 2023
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
b48c214
Add TASKCOMPLETED constant
thienlnam May 11, 2023
15e0001
Add new method for task actions
thienlnam May 11, 2023
ae1562a
Create completeTask command
thienlnam May 11, 2023
f815004
Hook up functionality to complete task
thienlnam May 11, 2023
c75c420
Update TaskPreview.js
thienlnam May 11, 2023
d125fe4
add grabbing the parentReportID
thienlnam May 11, 2023
92ddb6f
add new taskAction component
thienlnam May 11, 2023
3ad9fff
render on demand
thienlnam May 11, 2023
90a0df4
add copy for completed task
thienlnam May 11, 2023
50a2b4d
update task action to pass in actionName
thienlnam May 11, 2023
e0b4d7b
Update ReportActionItem.js
thienlnam May 11, 2023
5e623a0
Merge in IR Dan changes
thienlnam May 13, 2023
91b25f2
Merge branch 'main' into jack-completeTask
thienlnam May 13, 2023
6a7f609
add new component task header
thienlnam May 13, 2023
4ff1e73
add task header
thienlnam May 13, 2023
9ea845c
update assignee to managerEmail
thienlnam May 13, 2023
d9541bf
start adding description to task header
thienlnam May 13, 2023
6beeda2
Pass in threeDot menu items
thienlnam May 13, 2023
6c967e7
add mark as done button
thienlnam May 13, 2023
eb93804
Add complete task
thienlnam May 13, 2023
0c9cc8e
prevent calling when completed
thienlnam May 13, 2023
5383bce
Update ReportScreen.js
thienlnam May 13, 2023
28ca867
fix bug with preview not loading
thienlnam May 14, 2023
48d3b0d
fix up completeTask
thienlnam May 14, 2023
7bdebbf
update the method
thienlnam May 14, 2023
f6cc64c
add taskAction
thienlnam May 14, 2023
3791277
Merge branch 'main' into jack-completeTask
thienlnam May 15, 2023
cc33b81
update to mark as complete
thienlnam May 15, 2023
80815bc
move touchable to entire header
thienlnam May 15, 2023
bc72ce3
clean up task header
thienlnam May 15, 2023
085b634
clean up / remove debug changes
thienlnam May 15, 2023
b798b17
linter
thienlnam May 15, 2023
daa0963
disable updating unless task is open
thienlnam May 15, 2023
6b71635
update managerEmail
thienlnam May 15, 2023
537e3c4
hook up header button
thienlnam May 15, 2023
e64388b
add LHN subtitle message
thienlnam May 15, 2023
8186190
reivew comment
thienlnam May 15, 2023
683fe77
revert review comment
thienlnam May 15, 2023
41351a0
check use effect
thienlnam May 15, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update assignee to managerEmail
  • Loading branch information
thienlnam committed May 13, 2023
commit 9ea845c638a95c1f613a5252a7783994be1208a6
2 changes: 1 addition & 1 deletion src/libs/ReportUtils.js
Original file line number Diff line number Diff line change
Expand Up @@ -1588,7 +1588,7 @@ function buildOptimisticTaskReport(ownerEmail, assignee = null, parentReportID,
reportName: title,
description,
ownerEmail,
assignee,
managerEmail: assignee,
type: CONST.REPORT.TYPE.TASK,
parentReportID,
stateNum: CONST.REPORT.STATE_NUM.OPEN,
Expand Down