Merge pull request #18854 from Prince-Mendiratta/fix/18505-2fa-valida…

…tion-on-refresh [2FA] fix: Submit 2FA code after refresh
Expensify · May 15, 2023 · 5743b15 · 5743b15
2 parents a930756 + 80208fe
commit 5743b15
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 19 deletions.
diff --git a/src/libs/actions/Session/index.js b/src/libs/actions/Session/index.js
@@ -347,6 +347,13 @@ function signIn(password, validateCode, twoFactorAuthCode, preferredLocale = CON
                 isLoading: false,
             },
         },
+        {
+            onyxMethod: Onyx.METHOD.MERGE,
+            key: ONYXKEYS.CREDENTIALS,
+            value: {
+                validateCode,
+            },
+        },
     ];
 
     const failureData = [
@@ -367,8 +374,8 @@ function signIn(password, validateCode, twoFactorAuthCode, preferredLocale = CON
     };
 
     // Conditionally pass a password or validateCode to command since we temporarily allow both flows
-    if (validateCode) {
-        params.validateCode = validateCode;
+    if (validateCode || twoFactorAuthCode) {
+        params.validateCode = validateCode || credentials.validateCode;
     } else {
         params.password = password;
     }

diff --git a/src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js b/src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js
@@ -161,24 +161,25 @@ class BaseValidateCodeForm extends React.Component {
     validateAndSubmitForm() {
         const requiresTwoFactorAuth = this.props.account.requiresTwoFactorAuth;
 
-        if (!this.state.validateCode.trim()) {
-            this.setState({formError: {validateCode: 'validateCodeForm.error.pleaseFillMagicCode'}});
-            return;
-        }
-
-        if (!ValidationUtils.isValidValidateCode(this.state.validateCode)) {
-            this.setState({formError: {validateCode: 'validateCodeForm.error.incorrectMagicCode'}});
-            return;
-        }
+        if (requiresTwoFactorAuth) {
+            if (!this.state.twoFactorAuthCode.trim()) {
+                this.setState({formError: {twoFactorAuthCode: 'validateCodeForm.error.pleaseFillTwoFactorAuth'}});
+                return;
+            }
 
-        if (requiresTwoFactorAuth && !this.state.twoFactorAuthCode.trim()) {
-            this.setState({formError: {twoFactorAuthCode: 'validateCodeForm.error.pleaseFillTwoFactorAuth'}});
-            return;
-        }
-
-        if (requiresTwoFactorAuth && !ValidationUtils.isValidTwoFactorCode(this.state.twoFactorAuthCode)) {
-            this.setState({formError: {twoFactorAuthCode: 'passwordForm.error.incorrect2fa'}});
-            return;
+            if (!ValidationUtils.isValidTwoFactorCode(this.state.twoFactorAuthCode)) {
+                this.setState({formError: {twoFactorAuthCode: 'passwordForm.error.incorrect2fa'}});
+                return;
+            }
+        } else {
+            if (!this.state.validateCode.trim()) {
+                this.setState({formError: {validateCode: 'validateCodeForm.error.pleaseFillMagicCode'}});
+                return;
+            }
+            if (!ValidationUtils.isValidValidateCode(this.state.validateCode)) {
+                this.setState({formError: {validateCode: 'validateCodeForm.error.incorrectMagicCode'}});
+                return;
+            }
         }
 
         this.setState({