[HOLD for payment 2023-06-07] [$1000] DEV: Console error on click Continue button in login page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. logout if you logged in
2. type emaild and click continue button

Expected Result:

should not show any Console error

Actual Result:

shows Console error

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Happening in Dev
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-16.at.5.11.15.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684237638723149

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018b7e89ee174b9672
• Upwork Job ID: 1660682236329598976
• Last Price Increase: 2023-05-22

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Prince-Mendiratta]

unable to repro on latest main.

[puneetlath]

I'm also not able to reproduce.

[gadhiyamanan]

to reproduce the issue type email id which has not been used before. console error appears when a welcome message shown
cc: @puneetlath

Screen.Recording.2023-05-22.at.6.24.16.PM.mov

[puneetlath]

Ah cool. I'm able to reproduce now. Thanks @gadhiyamanan

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018b7e89ee174b9672

[melvin-bot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[melvin-bot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[Vishrut19]

Do I need to submit proposal for this as well?

[situchan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Console error on sign in page after enter new email

What is the root cause of that problem?

string && <View /> here:

App/src/pages/signin/SignInPage.js

Line 77 in 58ced75

this.props.credentials.login && this.props.account.primaryLogin && this.props.account.primaryLogin !== this.props.credentials.login && !this.props.account.validated;

App/src/pages/signin/SignInPage.js

Line 98 in 58ced75

const showValidateCodeForm = (this.props.credentials.login || this.props.credentials.validateCode) && !showUnlinkLoginForm && Permissions.canUsePasswordlessLogins(this.props.betas);

What changes do you think we should make in order to solve the problem?

wrap with Boolean here:
this.props.credentials.login && this.props.account.primaryLogin
(this.props.credentials.login || this.props.credentials.validateCode)

[situchan]

This is a regression from #15811 and should have been caught earlier by this checklist:

• I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.

[0xmiros]

@puneetlath proposal looks good to me
🎀 👀 🎀 C+ reviewed

[melvin-bot]

📣 @situchan You have been assigned to this job by @puneetlath!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[puneetlath]

@situchan ETA for the PR?

[situchan]

ETA: 2 hrs

While working on other issue, I found similar bug (came from #18806) which has the same root cause.
I can fix this too if you agree as it's very simple fix.

App/src/components/TaskHeader.js

Lines 56 to 59 in 0663820

	<View style={[styles.flexRow, styles.alignItemsCenter, styles.justifyContentBetween]}>
	{props.report.managerEmail && (
	<>
	<Avatar

It would be good to have linter to avoid these kinds of bugs in the future.
Btw, not sure how this was missed while creating or reviewing PR since it's already in checklist.

[situchan]

PR is ready for review

Note: I also fixed similar issue on task header as commented here

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.20-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix left part of conditional rendering not boolean on SignInPage, TaskHeader components #19639

If no regressions arise, payment will be issued on 2023-06-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter @gadhiyamanan
• Contributor that fixed the issue @situchan
• Contributor+ that helped on the issue and/or PR @0xmiroslav

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
• [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@0xmiroslav] Determine if we should create a regression test for this bug.
• [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[puneetlath]

Contracts sent. @0xmiroslav friendly reminder on the checklist.

[0xmiros]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR: Add unlink secondary login flow #15811
• [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/15811/files#r1214501704
• [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@0xmiroslav] Determine if we should create a regression test for this bug.
• [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

No need regression test as already in PR checklist:

• I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.

[puneetlath]

All paid. Thanks y'all!