Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport MoM Changes #73842

Closed
wants to merge 2 commits into from
Closed

Conversation

Procyonae
Copy link
Contributor

@Procyonae Procyonae commented May 16, 2024

Summary

Mods "[MoM] Power learning overhaul and bugfixes"

Purpose of change

Standing-Storm is evil

Describe the solution

Backports #70615, #70729
Will likely backport #70838, #70830, #70904, #70956, #70910, #70984, #71024, #71061, #71228, #71260, #71276, #71399 and #71437 if I don't have to split this into parts.
Will likely contain other PRs or partial PRs to deal with merge conflicts.

Describe alternatives you've considered

Just backporting the entirety of the mod as it existed post #71437

Testing

Additional context

* Add teleporter powers

* Update power values

* Updates

* Updates

* Add teleportation learning EoCs

* Update eoc_learn_recipes.json

* Update traits.json

* Edit practice recipes for power learning

* Add update EoC

* Add teleportation proficiency

* linting

* Edit profession

* Fixes

* Add "Fifth Sun People" trait for Itzcuauhtli Corps Liaison
* Add telekinesis descriptions

* Update telekinesis powers

* Additional changes
@Procyonae Procyonae marked this pull request as draft May 16, 2024 12:47
@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies [Markdown] Markdown issues and PRs EOC: Effects On Condition Anything concerning Effects On Condition Mods: Mind Over Matter labels May 16, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @Standing-Storm

@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) <Enhancement / Feature> New features, or enhancements on existing Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Info / User Interface Game - player communication, menus, etc. labels May 16, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Use of your powers has led to an insight. Instead of just shoving someone away from your location, you could direct the force orthagonally to knock someone to the ground, if you can figure out the proper technique.
  • Use of your powers has led to an insight. You could control your teleporting, traveling short distances without crossing the intervening space, if you can figure out the proper technique.
  • Use of your powers has led to an insight. You could teleport only your target, sending them somewhere nearby away from you, if you can figure out the technique.
  • You aren't from this universe and hopefully someday you can go home. This is a hidden trait, used for dialogue.
  • You have an understanding of how teleportation functions and unlocking new powers is easier for you.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 16, 2024
@Standing-Storm
Copy link
Contributor

Thank you for repaying my evil with good

This was referenced May 17, 2024
@RenechCDDA
Copy link
Member

@Standing-Storm This is redundant now, right?

@Standing-Storm
Copy link
Contributor

Yes, everything here should have been completed.

@RenechCDDA RenechCDDA closed this Sep 19, 2024
@Procyonae Procyonae deleted the BackportMoMPRs branch December 1, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Crafting / Construction / Recipes Includes: Uncrafting / Disassembling <Documentation> Design documents, internal info, guides and help. <Enhancement / Feature> New features, or enhancements on existing EOC: Effects On Condition Anything concerning Effects On Condition Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mods: Mind Over Matter Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants