[MoM] Final 0.H Fixes

[Standing-Storm]

Summary

Mods "[MoM] Final 0.H Fixes "

Purpose of change

Now that the power learning overhaul is done, this is a PR to collect any bugs before setting it to be ported to 0.H stable and I move on to more new content.

Fixes #71572

Fixes #71614

Fixes #71621

Describe the solution

Fix bugs

Describe alternatives you've considered

Testing

Listed bugs are fixed.

Additional context

[Nebnis]

Another one, unlocking adrenaline trigger says hardened skin instead. The description is odd too

[Rokharn]

Not sure if it's intended, but pyrokinesis Crucible have 12000 base stamina cost on the verge of what is possible with pumped up cardio. The difficulty level exceeds the difficulty of other psionics branches, where second high cost is 11500 for telekinesis Earthshaker (much more expensive in terms of stamina too, than other branches). This is 'mind over matter', but in the end this is cardio over mind, so matter over mind.

Crucible has descriptions 'entirety of your power into a single white-hot point', seems it's intended to check all current possible max stamina for character, not a fixed amount, that can be out of character possibilities.

[Standing-Storm]

IIRC the max with pumped up cardio is closer to 21000 (I just checked and medium cardio Sky Island character has 14400 base stamina), so it's a significant cost but it's not insurmountable.

[Rokharn]

To maintain cardio person need to do some sorts of exercise, which decrease current max stamina to improve global max stamina level, so as result Crucible rarely possible to use enough time to actually training it like other powers before stamina before current stamina level drop below it's usage level.

And for some strange reasons I see no effect to cardio, when do all this psionic at all, so needs to use exercise action, as well. After whole season of pyrokinetic practice training day by day (using abnormal amount of stamina daily) I achieved enough stamina to use crucible only after start exercise, which strange.

At fact I was losing cardio daily, when used only psionic without anything else. The fitness bracelet also showed insufficient body load.

[Standing-Storm]

The way I implemented the calorie drain from psionics doesn't count as exercise, which I'm actually happy with (it's supposed to be weird and not really fit how physics works), but it does mean you'll have to supplement your psionics practice with mundane exercise.

Spellcasting stamina drain not counting as exercise might be unintended, though--I'd report that as a bug and see if that's how it's supposed to work or not.

[Rokharn]

The teleport code reminded me of an old bug associated with it. If you cast a Gateway, but do not choose a direction and cancel it, then the nether attunement will still be increased. After a successful cast with teleportation, it will be count twice. This is a bug from before the introduction nether attunement with older system, seems it's still here.

[Nebnis]

Contemplating Lacerating touch also have wrong description.(btw if you think this is spammy i can tonne down)

[Nebnis]

Also would be nice if enervating touch scaled the regen debuff with levels. Let's say -4 per level. At 12, that would be -48 and would negate most regen things in the game. I'm really not really feeling the flat half debuff since the duration is so short for those fights that matter which last long.

And maybe some debuff effect on enemy so i know they have it or not?

[Vsevolod-Shustov]

Minor stuff should be dumped here, right?

practice_biokin_adrenaline typo: success message says "You've unlocked the Hardened Skin power"
https://github.com/CleverRaven/Cataclysm-DDA/blob/master/data/mods/MindOverMatter/recipes/practice/biokinetic_practice.json#L538

[Nebnis]

Hyper enhanced metabolism has no effect description

Using wakeful rest, then when it ends and ask you "if you would like to continue this activity" and if you pick "Ignore this distraction and continue"it completely locks up the game with alt+f4 being needed.

[Standing-Storm]

Using wakeful rest, then when it ends and ask you "if you would like to continue this activity" and if you pick "Ignore this distraction and continue"it completely locks up the game with alt+f4 being needed.

Known bug with JSON-defined activities: #69780

[Nebnis]

Couple of other things i noticed. I'm not sure if i understood right but voltaic strikes eletricity clouds is hurting me, when it shouldnt? Walking into there hurts.

Also enhanced mobility is preventing me from using my stainless claws(rat mutation) unarmed attack. I can't figure out why this is happening because it has allows natural attacks. Maybe the flag don't work for auras and such.

[Standing-Storm]

Couple of other things i noticed. I'm not sure if i understood right but voltaic strikes eletricity clouds is hurting me, when it shouldnt? Walking into there hurts.

If you have a very low level of Voltaic Strikes, that can happen, but once you get a couple levels it shoudn't be a problem any more.

[Standing-Storm]

@Maleclypse

Now that this is in, here is the list of 0.H Backport PRs:

#70621 (Itzcuauhtli uniform changes--might already be in depending on when in the day 0.H was taken from)
#70623 (Knockdown telekinetic power, assumed in the telekinetic overhaul)
#70729 (Telekinesis learning revamp)
#70830 (Bugfix Nether Attunement gain from rounding down too often)
#70838 (Clairsentience learning revamp)
#70904 (Checks to make sure that players always have the recipes for the powers they know)
#70910 (Bugfix Detoxification power)
#70956 (Pyrokinesis learning revamp)
#70984 (Bugfix Telekinesis contemplation recipes)
#71024 (Bugfix Doomseer starting power name)
#71061 (Telepathy learning revamp)
#71228 (Photokinesis learning revamp)
#71260 (Bugfix Ch47 holster)
#71276 (Bugfix powers missing kcal cost)
#71399 (Vitakinesis learning revamp)

• This PR, and that should be it.