-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MoM] Power learning revamp: Clairsentience #70838
Merged
Maleclypse
merged 18 commits into
CleverRaven:master
from
Standing-Storm:clairsentience-overhaul
Jan 13, 2024
Merged
[MoM] Power learning revamp: Clairsentience #70838
Maleclypse
merged 18 commits into
CleverRaven:master
from
Standing-Storm:clairsentience-overhaul
Jan 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Documentation>
Design documents, internal info, guides and help.
[JSON]
Changes (can be) made in JSON
Mods
Issues related to mods or modding
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
[Markdown]
Markdown issues and PRs
Lore
Game lore, in-game communication. Also the Lore tab.
EOC: Effects On Condition
Anything concerning Effects On Condition
Mods: Mind Over Matter
json-styled
JSON lint passed, label assigned by github actions
astyled
astyled PR, label is assigned by github actions
labels
Jan 11, 2024
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to |
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
<Documentation>
Design documents, internal info, guides and help.
EOC: Effects On Condition
Anything concerning Effects On Condition
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Lore
Game lore, in-game communication. Also the Lore tab.
[Markdown]
Markdown issues and PRs
Mods: Mind Over Matter
Mods
Issues related to mods or modding
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "[MoM] Power learning revamp: Clairsentience"
Purpose of change
The fifth part of the power learning overhauls, this time for Clairsentience.
Describe the solution
Convert clairsentience to the new power learning system, adding appropriate EoCs and migrating old characters to the new system. Update the hobby and profession to match the new system. Add powers to spoiler file.
Describe alternatives you've considered
Testing
Made a Doomseer and saved, then loaded up my changes and made sure proper migration occurred. Waited a few days and made sure the learning EoCs triggered and then attempted to learn the powers and was successful in doing so. Mostly. It took me multiple attempts to learn One Perfect Shot but I got it eventually.
One second thought, I'll keep the higher-level hobbies for 0.I experimental since there's a chain of PRs required to get them to work, so this is ready.
Additional context