Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoM] Power learning revamp: Clairsentience #70838

Merged
merged 18 commits into from
Jan 13, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Jan 11, 2024

Summary

Mods "[MoM] Power learning revamp: Clairsentience"

Purpose of change

The fifth part of the power learning overhauls, this time for Clairsentience.

Describe the solution

Convert clairsentience to the new power learning system, adding appropriate EoCs and migrating old characters to the new system. Update the hobby and profession to match the new system. Add powers to spoiler file.

Describe alternatives you've considered

Testing

Made a Doomseer and saved, then loaded up my changes and made sure proper migration occurred. Waited a few days and made sure the learning EoCs triggered and then attempted to learn the powers and was successful in doing so. Mostly. It took me multiple attempts to learn One Perfect Shot but I got it eventually.

One second thought, I'll keep the higher-level hobbies for 0.I experimental since there's a chain of PRs required to get them to work, so this is ready.

Additional context

@Standing-Storm Standing-Storm marked this pull request as draft January 11, 2024 06:52
@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies [Markdown] Markdown issues and PRs Lore Game lore, in-game communication. Also the Lore tab. EOC: Effects On Condition Anything concerning Effects On Condition Mods: Mind Over Matter json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jan 11, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Use of your powers has led to an insight. You could use your prescience to help direct the flow of battle, calling out orders so your allies can react to dangers before they happen, if you can figure out the technique.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 11, 2024
@Standing-Storm Standing-Storm marked this pull request as ready for review January 12, 2024 07:47
@Maleclypse Maleclypse merged commit d1474f4 into CleverRaven:master Jan 13, 2024
24 checks passed
@Standing-Storm Standing-Storm deleted the clairsentience-overhaul branch January 14, 2024 00:17
@Procyonae Procyonae mentioned this pull request May 16, 2024
akrieger added a commit that referenced this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling <Documentation> Design documents, internal info, guides and help. EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Lore Game lore, in-game communication. Also the Lore tab. [Markdown] Markdown issues and PRs Mods: Mind Over Matter Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants