Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoM] Power learning revamp: Vitakinesis #71399

Merged
merged 24 commits into from
Feb 2, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Feb 1, 2024

Summary

Mods "[MoM] Power learning revamp: Vitakinesis"

Purpose of change

The ninth and final part of the power learning overhauls, this time for Vitakinesis.

Describe the solution

Convert vitakinesis to the new power learning system, adding appropriate EoCs and migrating old characters to the new system. Update the hobby and profession to match the new system. Add powers to spoiler file.

Describe alternatives you've considered

Testing

Created a Faith Healer, then quit and put in the updates, making sure the migration occurred successfully. Waited a while and attempted to learn a few new powers, making sure the appropriate powers were learned. Quit and created a Faith Healer, making sure that all listed powers were properly assigned.

Additional context

@Standing-Storm Standing-Storm marked this pull request as draft February 1, 2024 01:11
@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies [Markdown] Markdown issues and PRs EOC: Effects On Condition Anything concerning Effects On Condition Mods: Mind Over Matter labels Feb 1, 2024
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Feb 1, 2024
Standing-Storm and others added 2 commits January 31, 2024 19:12
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Feb 1, 2024
@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed json-styled JSON lint passed, label assigned by github actions labels Feb 1, 2024
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Feb 1, 2024
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 1, 2024
@Standing-Storm Standing-Storm marked this pull request as ready for review February 1, 2024 20:59
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 2, 2024
@Maleclypse Maleclypse merged commit 6a60ba5 into CleverRaven:master Feb 2, 2024
31 of 32 checks passed
@Standing-Storm Standing-Storm deleted the vitakinesis-revamp branch February 2, 2024 03:04
@Procyonae Procyonae mentioned this pull request May 16, 2024
akrieger added a commit that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling <Documentation> Design documents, internal info, guides and help. EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mods: Mind Over Matter Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants