robofac/json: fix prototype dialogue checks #71374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 30, 2024
Closed
Co-authored-by: Andrew Rosa <[email protected]> Co-authored-by: Anton Simakov <[email protected]>
andrei8l
force-pushed
the
fix-interom-prototypes
branch
from
16cbac3 to
3cf5327
Compare
github-actions
bot
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fix errors in Hub 01's dialogue introduced by the port to math
Describe the solution
Flip a couple of comparison signs from #70936 and #70996
Fix variable names for armor projects from #70996
Add another variable guard to replace the one partially removed by #70614
Describe alternatives you've considered
N/A
Testing
Tested every prototype dialogue topic
In all cases, the projects complete correctly, can be repeated correctly (note that exotic barrel and 5-point anchor initial analysis aren't repeatable), you can't collect the reward too early, and you can't collect the rewards multiple times or the wrong reward for the current project.
Additional context
N/A