Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hub01 will provide prototype armor at no cost. #71331

Closed
hagetawashi opened this issue Jan 29, 2024 · 0 comments · Fixed by #71374
Closed

hub01 will provide prototype armor at no cost. #71331

hagetawashi opened this issue Jan 29, 2024 · 0 comments · Fixed by #71374
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@hagetawashi
Copy link
Contributor

Describe the bug

When purchasing armor in a dialogue with hub01, if you select a type and cancel, you will be offered the selected type of armor free of charge on the spot.

Attach save file

N/A

Steps to reproduce

  1. Interact with the intercom on hub01 and select "Let's discuss prototypes."
  2. 「I'd like to request a set of ...」
    Select one of the
    「I'll check in later.」
    to end the conversation.
  3. Interact with the Intercom again,
    「Let's discuss prototypes.」
    Select Create.
  4. "How is my ordered armor going? It should be done by now."
    By selecting this option, you can receive the armor you selected in 2 for free.

Expected behavior

hub01 should receive the appropriate rewards and should be required to take the time to fabricate the armor.

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.22621.3085 (22H2)
  • Game Version: b3a2e0d [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth]
    ]

Additional context

I found some fixes for this issue.
In robofac_intercom_prototypes.json,
Line 24 { "math": [ "hub01_uhmwpe_researched", "==", "1" ] }
{ "math": [ "hub01_uhmwpe_researched", "!=", "1" ] },
Line 187 { "math": [ "time_since(u_timer_hub_rnd_u_waiting_on_hub)", "<", "time('1 d')" ] }
{ "math": [ "time_since(u_timer_hub_rnd_u_waiting_on_hub)", ">", "time('1 d')" ] }
Lines 576, 598, 620, 642, 664
{ "math": [ "u_timer_hub_rnd_u_waiting_on_gun", "=", "time('now')" ] }
Change to { "math": [ "u_timer_hub_rnd_u_waiting_on_hub", "=", "time('now')" ] }.
With this change, the option to order prototype armor for the first time worked properly.
However, from the second time onwards, the armor will be provided for free by following steps 2, 3, and 4 of Steps to reproduce.
This is expected to be due to the fact that the timer continues to count even after the first order is completed, and the variable saved with the option selected in step 2. However, I couldn't successfully fix this.

Finally, I relied on automatic translation to create this sentence.
I apologize if there are any mistakes in the text.

@hagetawashi hagetawashi added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
1 participant