Fix hub timers #71370
Closed
Fix hub timers #71370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
andrei8l
reviewed
Jan 30, 2024
| @@ -261,7 +261,7 @@ | |||
| "text": "How are my armor repairs coming?", | |||
| "condition": { | |||
| "and": [ | |||
| { "math": [ "time_since(u_timer_hub_rnd_u_waiting_on_hub)", "<", "time('1 d')" ] }, | |||
| { "math": [ "time_since(u_timer_hub_rnd_u_waiting_on_hub)", ">", "time('1 d')" ] }, | |||
There was a problem hiding this comment.
This is for "it's not ready yet" so the sign is correct
There was a problem hiding this comment.
Does the second commit correct? I assume the idea is to have separate timers for weapon and for armor, but didn't dig deep enough
|
I didn't notice you had already put up a PR. There are a couple of other errors there that I've addressed in #71374 |
|
Nevertheless, it'd be easier to close it in favor of #71374 |
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Attempt to fix #71331 and fix #71366
Describe the solution
Swapped checks to return true when it passed more than X days, not less
replace waiting_on_gun with waiting_on_hub variable, because it looks like the second should respond for your armor crafting
Testing
I opened prototypes menu before the fix, confirmed i can finish it instantly
I applied fix, i tried again, and i can't do this anymore
Additional context
I don't really know is it suffisient fix, #71331 meniton error in Line 24, but i don't see how it may cause issues, and i am not entirely sure i undersand the logic behind all the dialogues