Fix UHMWPE prototype dialogue #71373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During arithmetic migration, this check was flipped by accident, resulting in a state where you could ask for prototypes but no question to follow-up and actually set the global var.
Closed
|
Hey, sorry I didn't see this. Looks like the 3 of us were working on the same thing at the same time. I think my fix in #71374 is the most complete one |
|
That's awesome @andrei8l! I'm good to close this one in favor of yours. Thanks for working on that ✌️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fix UHMWPE prototype dialog, which entered a kind of dialog "deadlock" with no way to move forward and receive the new armor pieces.
Describe the solution
During arithmetic migration, this check was flipped by accident. This patch just reverts it back to
!=.Describe alternatives you've considered
None
Testing
Well... I had current game and did this one line fix myself and worked as intended. Checked the commit history as audit and makes sense. I'm not familiar with dev tools to reproduce this quest line, so I'm sorry for not detailed reproducible steps.
Additional context
None