Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hub now offers armor set printing after the HWP is unlocked #70614

Merged
merged 8 commits into from
Jan 4, 2024

Conversation

carlarctg
Copy link
Contributor

Summary

Features "Hub now offers armor set printing after HWP is unlocked"

Purpose of change

It's quite annoying to need to travel all the way to hub every week to see if they have what you want in stock. It shouldn't be hard to get a full set of gear, that's what they do after all. Print stuff. There was also a problem i had in my last run where the jerks never restocked on MDS after I had lost my last poncho to a zombie horde eating my npc.

Describe the solution

After the HWP is unlocked for printing, hub now sells sets of armor. The rig, prototype, kinetic, ballistic, turnout. Military after that's unlocked. Respectively, they cost 3, 2, 4, 4, 4, 12 for the military set, 'cause it's expensive.

Describe alternatives you've considered

Increasing costs. They're based on the purchase value of prototype armor, but I dunno.

Having hub sell full sets of armor rig at all times, and one armor set per shop cycle. This felt off. I like that they have surplus equipment for sale, I just don't like that I had to rely on it to get a full set.

Testing

Spawned myself in, spawned a hub, did the necessary missions, ordered kinetic armor for printing, fastforwarded time by one day and got my armor.

Additional context

Third pr, yay.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON <Enhancement / Feature> New features, or enhancements on existing astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jan 3, 2024
@andrei8l
Copy link
Contributor

andrei8l commented Jan 3, 2024

With this solution you have to trade for coins with the regular trade interface, then go back through the dialogue to order an armor set. You also have the price for the thing in two different places. Why not just make the armor sets guaranteed entries in the shopkeeper group?

@carlarctg
Copy link
Contributor Author

With this solution you have to trade for coins with the regular trade interface, then go back through the dialogue to order an armor set. You also have the price for the thing in two different places. Why not just make the armor sets guaranteed entries in the shopkeeper group?

I like the idea of hub fabricating the armor and the 24 hour wait time. I also like the concept that they're selling surplus gear in the shop group, not full sets. This is stated in alternatives. Thus, if you're a new hire, you make do with whatever they're selling, but if you've proven yourself to hub, you gain access to specialized printing of equipment, which I think is neat.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 3, 2024
@John-Candlebury
Copy link
Member

Seems good to me, conceptually.

@Maleclypse Maleclypse merged commit f4d68fd into CleverRaven:master Jan 4, 2024
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants