Wooden pulley fixes #60285
Merged
Wooden pulley fixes #60285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
looks_like to wooden pulley
wooden pulley to actually work
github-actions
bot
added
[JSON]
pjf
added a commit
to pjf/Cataclysm-DDA
that referenced
this pull request
Aug 21, 2022
* origin/master: Prepper NPC quest follow-up (CleverRaven#59515) Adds a new widget for th structured sidebar with all midsize bodygraphs (i.e. the ones structured uses for "Health + Status" et al) side by side with nothing else, for use with Health + Overmap because I like the way the midsize bodygraphs look and don't want to have to choose just one of them to display (CleverRaven#60244) [DinoMod] slower zombie dino upgrades (CleverRaven#60311) [Xedra Evolved] Adds itemgroups for spell items (CleverRaven#60296) Update mutations.json (CleverRaven#60295) Fix typos (CleverRaven#60269) Wooden pulley fixes (CleverRaven#60285) Update landscaping.json (CleverRaven#60299) Update martialarts.json (CleverRaven#60305) fix: 'person' monster silently vanishes after touching character (CleverRaven#60270) fix: prevent use of non valid creature pointer (CleverRaven#60272) Nested Recipes - Ropes, Bundles, Shelled Nuts (CleverRaven#60297) Nested Recipes - Chain Armor (CleverRaven#60268) Nerf isherwood dandelion quest rewards (CleverRaven#60273) Animal ports from TropiCata to Mainline + egg density fixes for insects and birds (CleverRaven#60234) Modular Defense Anchor is SOFT (CleverRaven#60279)
Hirmuolio
pushed a commit
to Hirmuolio/Cataclysm-DDA
that referenced
this pull request
Aug 27, 2022
* Update terrain-mechanisms.json looks_like to wooden pulley * Update gates.json wooden pulley to actually work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Wooden palisade pulley actually works."
Purpose of change
Missed how the gates in-game actually worked (gates.json) so the wooden pulley didn't actually work. Fix that and also adds a looks_like field for it.
Describe the solution
Adds t_palisade_pulley_wood entry in gates.json and adds a looks_like field for the wooden version the same as the metal.
Describe alternatives you've considered
Purely decorative rope pulley systems?
Testing
Made changes, checked it had a sprite and opened gate.
Additional context
I...may have forgotten to test the wooden version in #59880.