Animal ports from TropiCata to Mainline + egg density fixes for insects and birds #60234

Xaritscin · 2022-08-17T04:04:43Z

Summary

Mods "ports animals from mod"

Purpose of change

Longstanding plan to move several mobs from the mod to mainline based on accuracy and plausibility seeing that they arent exclusive to the tropics.

Describe the solution

The following animals were ported from mod:

-birds: hummingbirds, woodpeckers, rails, cormorants, grebes, geese (domestic variants)
-amphibians: toads (including a zombie version)
-arthropods: butterflies and moths, cicadas, woodlice, diving beetles, water scorpions
-mammals: llamas

EDIT: to evade fails on item test, i updated the weights and volumes of the generic bird(55g/50ml), insect(275g/250ml) and canadian goose(143g/130ml) eggs to get most of the animal eggs out of the "bad density" list. this also fixed it for owlbear eggs in Magiclysm.

Describe alternatives you've considered

I was considering on moving guinea pigs, parrots, cockatoos and budgerigars too but due to New England temperatures i dont think those creatures would survive without indoor heating.

Testing

Grabbed the files and generated a new map, started strolling around, found several of the animals in their respective places. only crashes at load were due to build syntax errors that are being fixed or already solved.

Additional context

most if not all the animals ported have a worldwide distribution, and some like llamas can probably survive just fine in the far north due to their wooly covering.

added geese, rails, grebes, cormorants, hummingbirds and woodpeckers to vanilla birds file along with their offspring.

moved several birds to vanilla game from mod

added several types for eggs for animals that are being ported from mod to vanilla

moved several eggs from mod to vanilla

added monstegroup for eggs from mod

moved several monstergroups from eggs to vanilla files

added toads to vanilla game

moved toads to vanilla

moved gastrobufo to vanilla game

added gastrobufo to vanilla game

ported insect dust for butterflies and moths from mod

added insect dust to chitin meal recipes

ported several insects from mod to vanilla

moved several insects from mod to vanilla

ported llamas from mod to vanilla

moved llamas to vanilla

moved butterfly groups to vanilla file

ported butterfly groups from mod to vanilla

ported animal entries on monstergroups from mod to vanilla files

ported several animals in groups to vanilla files

ported monster entries from mod to vanilla

moved monster entries from mod to vanilla

trying to fix the density errors

bombasticSlacks · 2022-08-18T10:46:27Z

Alright so all the "cannot assign a value same as default" errors you can just delete the relevant line.

For the density test basically it's saying:

"Your items way X" "A perfect cube made of the same materials of the same volume weighs Y"

If your item weighs more than the perfect cube it doesn't make any sense.

It looks like most the eggs are based off current game eggs. So you would need to fix those.

The 3 ways to fix an item are:
Adjust the volume to be more correct. Is the item not big enough?
Adjust the weight to be more correct. Is the item too heavy?
Adjust the materials. Are the materials wrong, or wrong proportionally? (Ex a pair of sandals could be leather, cork and steel. By default that means it's 33% of each but if defined correctly would be like 60% cork, 30% leather, 10% steel buckle)

changed the size of bird eggs to match "medium" size chicken eggs (from 57g and 50ml to 50g and 43 ml). this change was made so as to see if the density errors on item test stop appearing.

matched egg volume to mass to see if it stop sending errors

listed off eggs fixed with the density fix

lint fix

more writting off eggs

changed insect and canadian goose egg volume to match density requirements

wrote off insect eggs now that egg_insect has a correct density

Xaritscin · 2022-08-19T03:51:03Z

Ok all non fish/complex cooking eggs got checked for density fails and basic build isnt throwing errors anymore. at least for this PR, hopefully now the autochecker will finish in due time

owlbear egg also written off -_-

bombasticSlacks · 2022-08-19T16:44:17Z

Thanks for fixing the eggs, I know it isn't particularly engaging work but we appreciate you doing it right.

* origin/master: Prepper NPC quest follow-up (CleverRaven#59515) Adds a new widget for th structured sidebar with all midsize bodygraphs (i.e. the ones structured uses for "Health + Status" et al) side by side with nothing else, for use with Health + Overmap because I like the way the midsize bodygraphs look and don't want to have to choose just one of them to display (CleverRaven#60244) [DinoMod] slower zombie dino upgrades (CleverRaven#60311) [Xedra Evolved] Adds itemgroups for spell items (CleverRaven#60296) Update mutations.json (CleverRaven#60295) Fix typos (CleverRaven#60269) Wooden pulley fixes (CleverRaven#60285) Update landscaping.json (CleverRaven#60299) Update martialarts.json (CleverRaven#60305) fix: 'person' monster silently vanishes after touching character (CleverRaven#60270) fix: prevent use of non valid creature pointer (CleverRaven#60272) Nested Recipes - Ropes, Bundles, Shelled Nuts (CleverRaven#60297) Nested Recipes - Chain Armor (CleverRaven#60268) Nerf isherwood dandelion quest rewards (CleverRaven#60273) Animal ports from TropiCata to Mainline + egg density fixes for insects and birds (CleverRaven#60234) Modular Defense Anchor is SOFT (CleverRaven#60279)

…ts and birds (CleverRaven#60234) * Update bird.json added geese, rails, grebes, cormorants, hummingbirds and woodpeckers to vanilla birds file along with their offspring. * Update tropical_bird.json moved several birds to vanilla game from mod * Update egg.json added several types for eggs for animals that are being ported from mod to vanilla * Update egg.json moved several eggs from mod to vanilla * Update eggs.json added monstegroup for eggs from mod * Update eggs.json moved several monstergroups from eggs to vanilla files * Update reptile_amphibian.json added toads to vanilla game * Update tropical_reptile_amphibian.json moved toads to vanilla * Update tropical_zanimals.json moved gastrobufo to vanilla game * Delete tropical_zanimals.json * Update zed-animal.json added gastrobufo to vanilla game * Update biosignatures.json ported insect dust for butterflies and moths from mod * Delete biosignatures.json * Update recipe_others.json added insect dust to chitin meal recipes * Delete recipe_others.json * Update insect_spider.json ported several insects from mod to vanilla * Update tropical_insect_spider.json moved several insects from mod to vanilla * Update mammal.json ported llamas from mod to vanilla * Update tropical_mammal.json moved llamas to vanilla * Update tropical_bugs.json moved butterfly groups to vanilla file * Update bugs.json ported butterfly groups from mod to vanilla * Update misc.json ported animal entries on monstergroups from mod to vanilla files * Update misc.json ported several animals in groups to vanilla files * Update wilderness.json ported monster entries from mod to vanilla * Update wilderness.json moved monster entries from mod to vanilla * Update monster_factions.json * Update wilderness.json * Update eggs.json * Update misc.json * Update wilderness.json * Update wilderness.json * Update bird.json build fixes * Update bird.json * Update eggs.json build fixes * Update egg.json * Update bird.json * Update egg.json * Update biosignatures.json changed chitin dust so it matches other chitinous materials * Update egg.json hummingbird egg fixes * Update eggs.json added starting date for giant caterpillars to spawn from eggs as per Venera´s feedback * Update wilderness.json added starting hours for giant caterpillars to appear on overmap * Update insect_spider.json updated harvest type for lepidopterans and cicadas * Update insect_spider.json changed growth of mutated butterflies into giants (per Venera's advice) * Update insect_spider.json nerfed cicada agression and caterpillar speeds * Update insect_spider.json several fixes to cicadas and beetles * Update misc.json branch conflict fixes * Update biosignatures.json * Update egg.json trying to fix the density errors * Update egg.json * Update egg.json changed the size of bird eggs to match "medium" size chicken eggs (from 57g and 50ml to 50g and 43 ml). this change was made so as to see if the density errors on item test stop appearing. * Update egg.json matched egg volume to mass to see if it stop sending errors * Update egg.json * Update known_bad_density.json listed off eggs fixed with the density fix * Update egg.json * Update egg.json lint fix * Update known_bad_density.json more writting off eggs * Update egg.json changed insect and canadian goose egg volume to match density requirements * Update egg.json * Update known_bad_density.json * Update egg.json * Update known_bad_density.json wrote off insect eggs now that egg_insect has a correct density * Update known_bad_density.json * Update known_bad_density.json owlbear egg also written off -_- Co-authored-by: Maleclypse <[email protected]>

Xaritscin added 26 commits August 16, 2022 22:12

Update bird.json

544015c

added geese, rails, grebes, cormorants, hummingbirds and woodpeckers to vanilla birds file along with their offspring.

Update tropical_bird.json

0a54d59

moved several birds to vanilla game from mod

Update egg.json

ad66fdb

added several types for eggs for animals that are being ported from mod to vanilla

Update egg.json

1a84553

moved several eggs from mod to vanilla

Update eggs.json

84f37bb

added monstegroup for eggs from mod

Update eggs.json

51608a4

moved several monstergroups from eggs to vanilla files

Update reptile_amphibian.json

da96842

added toads to vanilla game

Update tropical_reptile_amphibian.json

3ee14a9

moved toads to vanilla

Update tropical_zanimals.json

12282dc

moved gastrobufo to vanilla game

Delete tropical_zanimals.json

d403bb2

Update zed-animal.json

a7b8c15

added gastrobufo to vanilla game

Update biosignatures.json

5e281a6

ported insect dust for butterflies and moths from mod

Delete biosignatures.json

e274f12

Update recipe_others.json

5a8d9a0

added insect dust to chitin meal recipes

Delete recipe_others.json

a92dc98

Update insect_spider.json

dfb2f01

ported several insects from mod to vanilla

Update tropical_insect_spider.json

30aa74a

moved several insects from mod to vanilla

Update mammal.json

2c7d4fb

ported llamas from mod to vanilla

Update tropical_mammal.json

61856c6

moved llamas to vanilla

Update tropical_bugs.json

fcf7e6f

moved butterfly groups to vanilla file

Update bugs.json

4efa5fb

ported butterfly groups from mod to vanilla

Update misc.json

1b4818b

ported animal entries on monstergroups from mod to vanilla files

Update misc.json

2e3f72b

ported several animals in groups to vanilla files

Update wilderness.json

804724b

ported monster entries from mod to vanilla

Update wilderness.json

d955ead

moved monster entries from mod to vanilla

Update monster_factions.json

9a33d66

github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Mods Issues related to mods or modding Mods: TropiCataclysm 🌴 Having to do with the tropical region mod for DDA. labels Aug 17, 2022

Xaritscin added 2 commits August 18, 2022 00:08

Update egg.json

b1a2af9

trying to fix the density errors

Update egg.json

d7072a7

Xaritscin added 4 commits August 18, 2022 19:03

Update egg.json

f6d1eb4

changed the size of bird eggs to match "medium" size chicken eggs (from 57g and 50ml to 50g and 43 ml). this change was made so as to see if the density errors on item test stop appearing.

Update egg.json

c993e0a

matched egg volume to mass to see if it stop sending errors

Update egg.json

a248e43

Update known_bad_density.json

afd9dc0

listed off eggs fixed with the density fix

github-actions bot added the Code: Tests Measurement, self-control, statistics, balancing. label Aug 19, 2022

Update egg.json

c16bdaa

github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Aug 19, 2022

Update egg.json

483405a

lint fix

github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Aug 19, 2022

Xaritscin added 7 commits August 18, 2022 20:29

Update known_bad_density.json

6135cb4

more writting off eggs

Update egg.json

68df30a

changed insect and canadian goose egg volume to match density requirements

Update egg.json

b47b93c

Update known_bad_density.json

f4b4533

Update egg.json

8b5e1ee

Update known_bad_density.json

4640b8f

wrote off insect eggs now that egg_insect has a correct density

Update known_bad_density.json

93781d7

Update known_bad_density.json

1e7aee1

owlbear egg also written off -_-

Xaritscin changed the title ~~Animal ports from TropiCata to Mainline~~ Animal ports from TropiCata to Mainline + egg density fixes for insects and birds Aug 19, 2022

github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 19, 2022

bombasticSlacks merged commit 7451a94 into CleverRaven:master Aug 19, 2022

Xaritscin deleted the TropiCata-0.7g branch August 20, 2022 01:39

a-chancey mentioned this pull request Aug 29, 2022

Odd upgrade path for toads #60565

Closed

RenechCDDA mentioned this pull request Sep 16, 2022

Allow newly added eggs to be cooked #61037

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Animal ports from TropiCata to Mainline + egg density fixes for insects and birds #60234

Animal ports from TropiCata to Mainline + egg density fixes for insects and birds #60234

Xaritscin commented Aug 17, 2022 •

edited

Loading

bombasticSlacks commented Aug 18, 2022

Xaritscin commented Aug 19, 2022 •

edited

Loading

bombasticSlacks commented Aug 19, 2022

Animal ports from TropiCata to Mainline + egg density fixes for insects and birds #60234

Animal ports from TropiCata to Mainline + egg density fixes for insects and birds #60234

Conversation

Xaritscin commented Aug 17, 2022 • edited Loading

Summary

Purpose of change

Describe the solution

Describe alternatives you've considered

Testing

Additional context

bombasticSlacks commented Aug 18, 2022

Xaritscin commented Aug 19, 2022 • edited Loading

bombasticSlacks commented Aug 19, 2022

Xaritscin commented Aug 17, 2022 •

edited

Loading

Xaritscin commented Aug 19, 2022 •

edited

Loading