Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Interface] New Widget for Structured Sidebar #60244

Merged
merged 1 commit into from
Aug 19, 2022
Merged

[Interface] New Widget for Structured Sidebar #60244

merged 1 commit into from
Aug 19, 2022

Conversation

foul-fortune-feline
Copy link
Contributor

@foul-fortune-feline foul-fortune-feline commented Aug 17, 2022

Summary

Interface "Adds a widget to the structured sidebar with all midsize bodygraphs and nothing else"

Purpose of change

The midsize bodygraphs in the structured sidebar are nice, but as is it's not really feasible to use them all at once, which limits their utility.

Describe the solution

Simply adds a widget which has all midsize bodygraphs, intended for use with the "Health + Overmap" widget

Describe alternatives you've considered

None

Testing

Tried out in game, works without issue

Additional context

…hs (i.e. the ones structured uses for "Health + Status" et al) side by side with nothing else, for use with Health + Overmap because I like the way the midsize bodygraphs look and don't want to have to choose just one of them to display
@foul-fortune-feline foul-fortune-feline changed the title Adds a new widget for th structured sidebar with all midsize bodygrap… [Interface] New Widget for Structured Sidebar Aug 17, 2022
@foul-fortune-feline
Copy link
Contributor Author

foul-fortune-feline commented Aug 17, 2022

Sorry for messy initial pr lol i accidentally clickthroughed a tad too fast, but edited it to be more proper -w-'

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Info / User Interface Game - player communication, menus, etc. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Aug 17, 2022
@mlange-42
Copy link
Contributor

mlange-42 commented Aug 17, 2022

Nice! But could you make the new widget DISABLED_BY_DEFAULT? Would like to keep the sidebar directly usable without changing the settings. I.e. no redundancies that waste precious space...

EDIT: Sorry, I think it already is disabled by default due to the copy-from. Was not able to try it out, as currently not being on a PC.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 17, 2022
@foul-fortune-feline
Copy link
Contributor Author

Ye it's modeled after the structured health blocks, so it acts pretty much identically to them (takes up the same amt of space even)

@sonphantrung
Copy link
Contributor

Just for some recommendations in the future: You should not make changes directly into your master branch, instead create a new branch using git branch whatevernameyouwant then git checkout to that branch ;)

@foul-fortune-feline
Copy link
Contributor Author

foul-fortune-feline commented Aug 18, 2022

oic. Thank for advice haha, that makes a lot of sense (especially since I have some other ideas for things, but my biggest one's gonna end up in 0.H if it happens as it would absolutely be a feature freeze candidate)

@dseguin dseguin merged commit d17c11d into CleverRaven:master Aug 19, 2022
pjf added a commit to pjf/Cataclysm-DDA that referenced this pull request Aug 21, 2022
* origin/master:
  Prepper NPC quest follow-up (CleverRaven#59515)
  Adds a new widget for th structured sidebar with all midsize bodygraphs (i.e. the ones structured uses for "Health + Status" et al) side by side with nothing else, for use with Health + Overmap because I like the way the midsize bodygraphs look and don't want to have to choose just one of them to display (CleverRaven#60244)
  [DinoMod] slower zombie dino upgrades (CleverRaven#60311)
  [Xedra Evolved] Adds itemgroups for spell items (CleverRaven#60296)
  Update mutations.json (CleverRaven#60295)
  Fix typos (CleverRaven#60269)
  Wooden pulley fixes (CleverRaven#60285)
  Update landscaping.json (CleverRaven#60299)
  Update martialarts.json (CleverRaven#60305)
  fix: 'person' monster silently vanishes after touching character (CleverRaven#60270)
  fix: prevent use of non valid creature pointer (CleverRaven#60272)
  Nested Recipes - Ropes, Bundles, Shelled Nuts (CleverRaven#60297)
  Nested Recipes - Chain Armor (CleverRaven#60268)
  Nerf isherwood dandelion quest rewards (CleverRaven#60273)
  Animal ports from TropiCata to Mainline + egg density fixes for insects and birds (CleverRaven#60234)
  Modular Defense Anchor is SOFT (CleverRaven#60279)
Hirmuolio pushed a commit to Hirmuolio/Cataclysm-DDA that referenced this pull request Aug 27, 2022
…hs (i.e. the ones structured uses for "Health + Status" et al) side by side with nothing else, for use with Health + Overmap because I like the way the midsize bodygraphs look and don't want to have to choose just one of them to display (CleverRaven#60244)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants