Tailoring recipe audit #54256
Tailoring recipe audit #54256
Conversation
… fabric weights and volumes, the materials, as well as any recipe using cotton_tailoring or cotton_patchwork_tailoring requirements. Next commit will be when I review the remaining cotton recipes. this also adds cotton patches - i'll get to their recipes in the next pass.
This is the first pass of cotton, committing this for now. This commit covers the recipes that use just the cotton fabrics Removed some plurals i got warned about Adds cotton patches and recipes.
github-actions
bot
added
astyled
github-actions
bot
added
the
BasicBuildPassed
Maleclypse
added
[JSON]
|
You've listed the wrong issue you are continuing I think. |
D'oh. stupid me for having 50 tabs open. Correcting it now. |
|
Once #54308 is merged I'll be able to get the fabrics all set to the right weight and volume within a day and try to burn through these recipes. |
|
A few weeks back it was very annoying to get synthetic fabric, despite like half the clothes in the real world being made of it. Plus, in a lot of cases, it doesn't really matter if you patch your nylon tshirt with cotton etc. |
With the tailoring overhaul currently in progess in CleverRaven#54256, as well as appliances being introduced in CleverRaven#51286, I figured this was the best time to add sewing machines to cause the least amount of churn. works towards CleverRaven#53647
|
Whew. Had some issues with the merge after the genericization was added in, but i'm back up and running now. I'll be hopefully working through the rest of the values this week and reviewing recipes. |
|
So I've been working on this, and I've come to the conclusion that patchwork clothing parts are unnecessary in the context of the game, and they only add an intermediary step that only frustrates players. While their existence makes sense, because various sizes of fabric between 6" patches and 18"x24" sheets is realistic, it's also functionally useless at the level of abstraction we're at. We aren't cutting off "pair of cotton short sleeves (poor fit)" and sewing them back on later. In reviewing recipes, I honestly can't come up with a use for them in game other than them being a weird intermediary size between the different fabric pieces, when they'd eventually become patches in real life. Let's cut out the confusion and the middle man. I'm now proposing that each woven fabric has scraps, patches, patchwork sheets, and (manufactured) sheets. Sizes will remain as above - a patchwork sheet will be made of 8 6" square patches. Patches will be used for repairs and small crafting, sheets will be used for large crafting. Both scraps and patches can be byproduct based on what's used in a recipe. Need more sheets? Quilt some from your patches. The best part? It's all just going to be a name, weight and volume changes in the json. Most of the patchwork clothing parts are already ID'd as patchwork_sheet. There's some patches I'd love to migrate to appropriate IDs, but I don't think it's worth the hassle. Interestingly, cotton doesn't have a patch, so the patchwork cotton clothing parts fit neatly into that missing item spot. |
[WIP] Merging manual conflicts again
… recipes next. This should be all the fabric weights and volumes. Recipes come tomorrow.
|
Merged with latest earlier today, test failures appear to be unrelated to my changes. Going to pull again just to keep things up to date. |
github-actions
bot
removed
the
BasicBuildPassed
No worries. I didn't dig too deep into the mod folders, so if I missed anything, I can open new issues once this is merged. I'm just trying to keep the branch up to date and conflict free so it's ready to merge without adding anything beyond what already here, since it is massive already. After the merge maybe I'll give the mods another run through just to make sure things are still balanced. I didn't go through mod materials too finely, so I may have missed something that needs rebalanced in Magiclysm or Aftershock |
github-actions
bot
added
the
BasicBuildPassed
|
@LyleSY sorry to ping you - didn't mean to request a second review, I bumped that little refresh button below the comment window while scrolling the screen earlier accidentally. |
|
just wanted to say that I greatly appreciate all work that went into this, having had contributed some changes to making tailoring stuff less button press consuming in the past, I know how much of a pain it is to have to go through so many recipes, I only had covered some early game stuff so the player didn't freeze to death, and maybe three complete limb json files, and my solution was probably more of a stop-gap than this one! I'll probably start playing again because of this, I have nerve pain in my wrists and saving the button presses from converting between different cotton types will make the game a lot more playable! |
Co-authored-by: Maleclypse <[email protected]>
|
Let me say congratulations yet again. This has been a long journey to watch, but I think it will be well worth the effort. |
|
Now an unfinished crafting state desires a rag, and rags are nowhere to be found :O |
Please in the future make an issue rather than commenting on a merged PR. Are you able to debug in rags to finish with? |
|
On Fri, Jun 17, 2022 at 06:15:51PM -0700, Maleclypse wrote:
> Now an unfinished crafting state desires a rag, and rags are nowhere to be found :O
Please in the future make an issue rather than commenting on a merged PR. Are you able to debug in rags to finish with?
Yes.
…--
() ascii ribbon campaign - against html mail
/\ http://arc.pasp.de/ - against proprietary attachments
|
Summary
Balance "Tailoring Recipe Audit"
Purpose of change
Continues progress on #53436. This does the following:
Ultimately should: resolve and close #58327, close #53059, close #53436, close #57802
Describe the solution
As part of this entire audit the following is happening:
Standardize (most of) the fabric materials to the following 3 rough sizes across 4 items per fabric:
- 12"x12" (30.48cm x 30.48cm): Patchwork clothing partssee comment below. As it turns out, I couldn't find a reason that these exist other than we are maintaining an unfinished overhaul that's only confusing things.24"x12" was chosen as the standard sheet size for a few reasons. Fabric bolts are typically 30-36" tall, with thinner fabrics sometimes being folded so they're actually 60"-72" tall. This means three sheets will roughly equal 2 feet of fabric length on a bolt. The second reason is that 24"x12" is a commonly available size for Kevlar sheets and rigid panels in real life, so it was easiest to standardize based on that.
Patchwork clothing parts
are beinghave been renamed and resized to patchwork sheets. Their existing IDs actually listed them as patchwork sheets (not clothing parts), so for consistency's sake, it wasn't a big issue. The only exception to this is cotton. Cotton already had a patchwork sheet, so the patchwork clothing parts became cotton patches - as they and synthetic fabric were the only two to not have patches.The 3 added fabric items are: patchwork leather sheets, patchwork fur sheets, and synthetic fabric patches.
Recipes that utilize each fabric are being reviewed individually to ensure the area and volume match what's expected in the final product. Some are migrating to use requirements where they make sense. New requirements are being added to give small options as seen in fur and leather. Not all will be used, but they will be available for future use.
I'm planning to add cardboard fabric bolt containers that will only hold fabric sheets once this is all done. I'll have to figure out what I can do to pull this together after I'm done.
This standardization also means creating a few new items - most materials are missing patchwork sheets, though their internal IDs indicate the patchwork clothing parts should be patchwork sheets. These items will change to patchwork sheets, and patchwork clothing parts will be added with appropriate IDs.Patchwork clothing parts became patchwork sheets in most cases, except cotton, which became patches. Patches are used to make repairs, craft patchwork sheets and are used in the small tailoring requirements.
Kevlar is a special case. Kevlar's strength is derived from the way it is manufactured, and the research I've done shows that kevlar fabrics are typically not repairable - the entire fabric panel would need replaced. Kevlar layered panels are the same as Kevlar sheets - they are just 16 layers thick, sewn together. Rigid Kevlar plates are layered panels covered in epoxy - and in real life, these are repairable with Kevlar patches and epoxy.
Materials weight and volume calculations use the following stats, based on averages found from multiple sources online and measurements I verified with calipers at local fabric stores. Cotton is based on average "medium weight" cotton. Kevlar and Nomex stats are pulled from Dupont's datasheets, as they are standardized fabrics. Fur and faux fur are rough estimates due to a massive variety in the available fabrics and compressibility of the fur on the pelt.
Progress:
Files:
Recipes:
Materials:
Material tailoring requirements to be added
Describe alternatives you've considered
Letting someone else do this. Honestly, the insanity of the mixed item sizes, descriptions and amounts used in recipes were enough to work on this.
Testing
After making the changes, I've been testing tailoring on both a new and existing save, so as not to completely break updating the game for an existing character.
Additional context
We're out of draft! open to feedback on any decisions made.
We will likely still need more spawns added for Nomex and Kevlar sheets, as well as spawns for each of their threads.
WE'RE OUT OF DRAFT!
I'M A MADMAN. I just removed rags from everything and migrated them to cotton patches. Running tests before i commit.