Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Survivor Hoods and Cowl Update Take 2 #78098

Merged

Conversation

Kantonine
Copy link
Contributor

Ported original changes from previous hood and cowl PR, mainly done for easier history viewability than before, as well as making mouth on both cowls plastic.

Summary

Balance "Changed Survivor Hood Materials and Added Filtration to Cowls"

Purpose of change

This is a redo of #75255, with the crafting recipe changes cut out. The PR was swamped by a commit history that was difficult to parse, and the crafting changes blocked merging, along with potentially being unrealistic, so I decided to let someone else who was better experienced follow up on that.

Describe the solution

Same as #75255, but with one key difference: The mouth of the cowls now also use plastic, with the same thickness as the filter mask+goggles for the eyes and mouth. Changed hoods to use kevlar instead of ballistic kevlar, as well as made the Scavenger Cowl (Now Mercenary Cowl) use the current sublimb system.

Describe alternatives you've considered

Testing

None Needed, already tested for the last attempt, and all bugs were related to crafting system.

Additional context

cap-okzk
inspiration for this change.

Ported original changes from previous hood and cowl PR, mainly done for easier history viewability than before, as well as making mouth on both cowls plastic.
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Armor / Clothing Armor and clothing Game: Balance Balancing of (existing) in-game features. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Nov 23, 2024
@Kantonine
Copy link
Contributor Author

Actually, before anything else continues, is anyone able to provide any info on what kinda nylon we have in game, or is it just generic? I might add nylon fabric as a base layer to the hoods

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 23, 2024
@IdleSol
Copy link
Contributor

IdleSol commented Nov 23, 2024

I've seen only this: #54256

#34871 :

2 new fabrics have been made: lycra, which is mostly nylon/polyethylene terephthalate(PET) mixed with polyurethane based elastomers, and synthetic fabric, a split between nylon/polyethylene terephthalate(PET). Anywhere one would want stretchy, form fitting fabric, use lycra. Anywhere else where strong nylon or versatile PET is fine, use synthetic fabric. Where impermeable plastics are used, like those in rain ponchos, rain coats, rubber boots, clean suits and hazmat suits, the original plastic will be used.

@Night-Pryanik Night-Pryanik merged commit 0010278 into CleverRaven:master Nov 24, 2024
18 of 24 checks passed
@Kantonine Kantonine deleted the Cowls-make-sense-for-real-this-time branch November 24, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Game: Balance Balancing of (existing) in-game features. Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants