Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sewing machines #54348

Closed
wants to merge 1 commit into from
Closed

Conversation

UmbralReaper
Copy link
Contributor

@UmbralReaper UmbralReaper commented Jan 13, 2022

Summary

Content "Adds a sewing machine and an overlocker"

Purpose of change

With the tailoring overhaul currently in progess in #54256, as well as appliances being introduced in #51286, I figured this was the best time to add sewing machines to cause the least amount of churn.

works towards #53647

Describe the solution

  • Implement two new items sewing_machine and overlocker.
  • Implement deconstruct recipes for sewing_machine and overlocker
  • Allow sewing_machine and overlocker to have the SEW quality when consuming power.
  • Spawn sewing_machine and overlocker in houses and craft stores.
  • Add sewing machines to recipes. @a-chancey Any chance you could help with this?

Describe alternatives you've considered

Adding a recipe for a manual sewing machine. Adding sewing needles.

Testing

Both items spawned and installed correctly.

Additional context

With the tailoring overhaul currently in progess in CleverRaven#54256, as well as
appliances being introduced in CleverRaven#51286, I figured this was the best time
to add sewing machines to cause the least amount of churn.

works towards CleverRaven#53647
@github-actions
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A disconnected domestic overlocker, designed to rapidly stitch seams and edges. The faded advertising sticker recommends purchasing a Sewing Machine, praising it as "The essential companion for any tailor".
  • A standard domestic overlocker, designed to rapidly stitch seams and edges. The faded advertising sticker recommends purchasing a Sewing Machine, praising it as "The essential companion for any tailor".
  • A standard domestic overlocker, designed to rapidly stitch seams and edges. The faded advertising sticker recommends purchasing a Sewing Machine, praising it as "The essential companion for any tailor". You could disconnect it and plug it in to a working power grid, or power it with UPS.
  • disconnected overlocker
  • disconnected overlockers
  • overlocker

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 13, 2022
@PatrikLundell
Copy link
Contributor

I don't know if there's a demand for manual sewing machines for players who play in worlds without access to power (although they might have trouble making the parts for it)?

@a-chancey
Copy link
Contributor

We had some discussions about this on discord and the general consensus is that both manual (pedal and flywheel) and powered sewing machines that run at different speeds are desired. Unfortunately, the only way the player will benefit is by adding alternative recipes to everything that could use either machine.

I don't think I'm going to make alternative recipes just yet for everything, as that's a LOT to cover, and I have already blown past the scope of my original planned work.

Based on the discussions, we need someone who's far better at CPP than I to work on #42556, as the plan is for routines to have time designated per step, so a powered sewing machine doesn't make the entire project faster, just the actual sewing portion. Essentially it would be like having a sorted list of entries similar to requirements, but each entry would define the time and resources needed for that step. From what I understand, it would also require reworking the tool/ingredient search algorithm and some UI work to allow the player to select which tools to use, likely defaulting to the fastest.

For now, giving them the SEW 2 quality should allow them to be used in the place of a needle in every recipe we have. They shouldn't be a substitute for a sewing or tailors kit, because those items have cutting and other specialty tools.

@Maleclypse Maleclypse added Appliance/Power Grid Anything to do with appliances and power grid Items / Item Actions / Item Qualities Items and how they work and interact labels Jan 14, 2022
@UmbralReaper
Copy link
Contributor Author

I'm not sure how to give the sewing machine the sewing quality only when it has power. Does charged_qualities work with appliances?

@UmbralReaper
Copy link
Contributor Author

I'm going to close this due to lack of interest. I don't think it's worth adding sewing machines to the game until they can be used to improve the crafting speed of recipes.

n0pen pushed a commit to n0pen/Cataclysm-DDA that referenced this pull request Aug 2, 2022
Currently you need to duplicate recipes to include new tools.
This results in bloated crafting gui and repeated json data
related to CleverRaven#54348 , CleverRaven#42556 , CleverRaven#45157
n0pen pushed a commit to n0pen/Cataclysm-DDA that referenced this pull request Aug 2, 2022
Currently you need to duplicate recipes to include new tools.
This results in bloated crafting gui and repeated json data
related to CleverRaven#54348 , CleverRaven#42556 , CleverRaven#45157
n0pen pushed a commit to n0pen/Cataclysm-DDA that referenced this pull request Aug 18, 2022
Currently you need to duplicate recipes to include new tools.
This results in bloated crafting gui and repeated json data
related to CleverRaven#54348 , CleverRaven#42556 , CleverRaven#45157
n0pen pushed a commit to n0pen/Cataclysm-DDA that referenced this pull request Aug 24, 2022
Currently you need to duplicate recipes to include new tools.
This results in bloated crafting gui and repeated json data
related to CleverRaven#54348 , CleverRaven#42556 , CleverRaven#45157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Appliance/Power Grid Anything to do with appliances and power grid astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items / Item Actions / Item Qualities Items and how they work and interact json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants