-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sewing machines #54348
Sewing machines #54348
Conversation
With the tailoring overhaul currently in progess in CleverRaven#54256, as well as appliances being introduced in CleverRaven#51286, I figured this was the best time to add sewing machines to cause the least amount of churn. works towards CleverRaven#53647
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to |
I don't know if there's a demand for manual sewing machines for players who play in worlds without access to power (although they might have trouble making the parts for it)? |
We had some discussions about this on discord and the general consensus is that both manual (pedal and flywheel) and powered sewing machines that run at different speeds are desired. Unfortunately, the only way the player will benefit is by adding alternative recipes to everything that could use either machine. I don't think I'm going to make alternative recipes just yet for everything, as that's a LOT to cover, and I have already blown past the scope of my original planned work. Based on the discussions, we need someone who's far better at CPP than I to work on #42556, as the plan is for routines to have time designated per step, so a powered sewing machine doesn't make the entire project faster, just the actual sewing portion. Essentially it would be like having a sorted list of entries similar to requirements, but each entry would define the time and resources needed for that step. From what I understand, it would also require reworking the tool/ingredient search algorithm and some UI work to allow the player to select which tools to use, likely defaulting to the fastest. For now, giving them the SEW 2 quality should allow them to be used in the place of a needle in every recipe we have. They shouldn't be a substitute for a sewing or tailors kit, because those items have cutting and other specialty tools. |
I'm not sure how to give the sewing machine the sewing quality only when it has power. Does |
I'm going to close this due to lack of interest. I don't think it's worth adding sewing machines to the game until they can be used to improve the crafting speed of recipes. |
Currently you need to duplicate recipes to include new tools. This results in bloated crafting gui and repeated json data related to CleverRaven#54348 , CleverRaven#42556 , CleverRaven#45157
Currently you need to duplicate recipes to include new tools. This results in bloated crafting gui and repeated json data related to CleverRaven#54348 , CleverRaven#42556 , CleverRaven#45157
Currently you need to duplicate recipes to include new tools. This results in bloated crafting gui and repeated json data related to CleverRaven#54348 , CleverRaven#42556 , CleverRaven#45157
Currently you need to duplicate recipes to include new tools. This results in bloated crafting gui and repeated json data related to CleverRaven#54348 , CleverRaven#42556 , CleverRaven#45157
Summary
Content "Adds a sewing machine and an overlocker"
Purpose of change
With the tailoring overhaul currently in progess in #54256, as well as appliances being introduced in #51286, I figured this was the best time to add sewing machines to cause the least amount of churn.
works towards #53647
Describe the solution
sewing_machine
andoverlocker
.sewing_machine
andoverlocker
sewing_machine
andoverlocker
to have theSEW
quality when consuming power.sewing_machine
andoverlocker
in houses and craft stores.Describe alternatives you've considered
Adding a recipe for a manual sewing machine. Adding sewing needles.
Testing
Both items spawned and installed correctly.
Additional context