Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate tailoring_nylon_patchwork recipe / Nerf synth fabric crafting #63031

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

moxian
Copy link
Contributor

@moxian moxian commented Jan 7, 2023

Summary

Content "Fix an oversight that allowed using synthetic fabric patches instead of sheets in recipes"

Purpose of change

Presently we have duplicated tailoring_nylon_patchwork requirement definition. The first one represents "big" piece of fabric, the second represents the "small" one. Due to the small one being defined later, it gets used in all the recipes using that requirement.

This is an oversight. It was introduced in #54256, which intended the latter to be called tailoring_nylon_patchwork_small. However this was never caught, due to the lack of any small enough recipes that would use the _small one.

Describe the solution

Rename the smaller recipe to be tailoring_nylon_patchwork_small as originally intended

Describe alternatives you've considered

  1. delete the unused requirement instead of simply renaming. However, I think the symmetry with other _small tailoring requirements is neat and might be useful in the future.
  2. delete/rename the bigger one, instead of the smaller one. This preserves the status quo, doesn't make it any harder to do synth fabric crafting, however it also results in slightly unrealistic recipes (25L backpack being made from 80g of cloth..).

Testing

20230107-214009-cataclysm-tiles

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 7, 2023
@dseguin dseguin merged commit 4481481 into CleverRaven:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants