Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointlessly convoluted cotton crafting #58327

Closed
dissociativity opened this issue Jun 10, 2022 · 4 comments · Fixed by #54256
Closed

Pointlessly convoluted cotton crafting #58327

dissociativity opened this issue Jun 10, 2022 · 4 comments · Fixed by #54256
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@dissociativity
Copy link
Contributor

Describe the bug

There's no reason to have rag, patchwork cotton sheet and patchwork cotton clothing part as different items with different purposes as it stands.

I understand having a clear cut difference between a patchwork and higher quality cotton sheet for crafting some items, but these currently completely arbitrary units of cotton just make crafting extremely tedious for no gain, as ultimately you're disassembling low quality cotton to get a different type of low quality cotton.

I consider this a bug because remnants of an utterly unfinished tailoring overhaul are still plaguing the game and making a lot of things take substially longer in real-life key presses, with no gain in realism nor gameplay benefit for it.

Steps to reproduce

The way things are, one needs to disassemble a sheet, then disassemble the patchwork sheet, then the clothing part, then one finally has a rag to craft a bandage.

Expected behavior

Ideally we just disassemble the sheet, get our patchwork or higher quality units of cotton (cotton sheet), and use that to craft and repair all things cotton without excessive button presses that have no justification.

This is to say we should obsolete "rag" and "patchwork clothing part" since it doesn't really serve any purpose, it would be assumed the character would make the clothing parts out of the patchwork sheets while making the clothing.

I may do this myself when I have time, but I figured the issue worth making in-case others would like to take some of the workload off of my hand, I already had to add these new arbitrary clothing parts to a lot of recipes in the past in order to not make crafting common clothing items immensely painful, there was a time where I'd take apart sheets then suffer from the cold for too long because I couldn't find the elusive "rag" to make wraps to keep myself warm.

Screenshots

No response

Versions and configuration

Windows 10 x64
1e56d2a (10/06/22)

Additional context

No response

@dissociativity dissociativity added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Jun 10, 2022
@Zireael07
Copy link
Contributor

I think differentiating rag vs patchwork piece makes sense (rags are suitable for bandages/towels/ropes etc. but not clothing).

However patchwork sheet vs patchwork piece is imho an unnecessary distinction,

@Terrorforge
Copy link
Contributor

Yeah, it's a mess. The whole textile crafting system needs a good seeing-to (#53059).

I believe there are some ongoing efforts to straighten it out, but it's a pretty onerous task since it involves auditing pretty much every single clothing recipe in the game. And it kind of has to be done in one go, because if you do it halfway and then get sidetracked you've just made the problem worse.

It's on the release blocker list tho, so hopefully it gets cleared up for 0.G.

@anothersimulacrum
Copy link
Member

CC @a-chancey - does #54256 do anything to address this?

@a-chancey
Copy link
Contributor

If I had answered last night, I would have said it partially addresses it.

But then my toddler woke up at 2:30am while we're on vacation and I couldn't fall back asleep when she laid back down so I got to work.

I managed to get rags removed from all of the instances I found in recipes, and migrated rags to cotton patches.

I finished fixing my failing tests a half hour ago and pushed my commit.

As for the rest of the issue here, see #54256 for more details. Fabric hierarchy is being adjusted and standardized, patchwork clothing parts are gone, and much more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants