Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify when CertificatePolicy.contentType is required #12309

Closed
heaths opened this issue Nov 5, 2020 · 0 comments · Fixed by #13759
Closed

Clarify when CertificatePolicy.contentType is required #12309

heaths opened this issue Nov 5, 2020 · 0 comments · Fixed by #13759
Assignees
@sadasant @maorleger
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone
[2021] March

Comments

@heaths
Copy link
Member

heaths commented Nov 5, 2020

Based on Azure/azure-sdk-for-net#16610, please update documentation and optionally add samples to clarify when CertificatePolicy.contentType is required, which is when importing a PEM-formatted certificate, or even for a PKCS#12/PFX when setting any other policy (i.e. when a policy is used, contentType is required, it seems, regardless of what swagger says).
@heaths heaths added Client This issue points to a problem in the data-plane of the library. KeyVault labels Nov 5, 2020
@heaths heaths added this to the [2021] February milestone Nov 5, 2020
@maorleger maorleger mentioned this issue Feb 11, 2021
Merged
2 tasks
maorleger added a commit that referenced this issue Feb 16, 2021
@maorleger
[KeyVault] - Address a few items for keys and admin and bump service …
35fb851 
…version (#13759)

## What

- Move `curve` from `createECKeyOptions` to `createKeyOptions`
- Add sample clatifying when `CertificatePolicy.contentType` is required
- Bump the API version to 7.2 (and update recordings)

## Why

- `createKeyOptions` is the catch-all and should accept parameters for all possible key creations (fixes #11263)
- It's not entirely clear when contentType is required. Following dotnet's example here (fixes #12309)
- 7.2 is already supported, and we will not GA with 7.2-preview (fixes #13594)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 25, 2021
@levimm @alexeldeib
@JunSun17 @tilnl
CodeGen from PR 12771 in Azure/azure-rest-api-specs
5c48b4f 
Dev containerservice microsoft.container service 2021 02 01 (Azure#12771)

* Adds base for updating Microsoft.ContainerService from version stable/2020-12-01 to version 2021-02-01

* Updates readme

* Updates API version in new specs and examples

* aks: generate 2021-02-01 sdk (Azure#12311)

* aks: add `allowNetworkPluginKubenet` field to `ManagedClusterPodIdentityProfile` (Azure#12309)

* aks: add `allowNetworkPluginKubenet` field to `ManagedClusterPodIdentityProfile`

* aks: add pod identity example

* AKS: add fqdnSubdomain for private cluster with custom private dns zone (Azure#12361)

* add fqdnSubdomain for private cluster with custom private dns zone

* add example ref

* fix example

Co-authored-by: Li Ma <[email protected]>

* add new disk choice (Azure#12682)

* AKS: Add Node Public IP Prefix support. (Azure#12673)

* Add azure portal fqdn (Azure#12725)

* add azure portal fqdn

* add azure portal fqdn

* fix prettier

Co-authored-by: Super <[email protected]>
Co-authored-by: Li Ma <[email protected]>
Co-authored-by: Ace Eldeib <[email protected]>
Co-authored-by: Jun Sun <[email protected]>
Co-authored-by: tilnl <[email protected]>
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Mar 3, 2021
@levimm @alexeldeib
@JunSun17 @tilnl
CodeGen from PR 12771 in Azure/azure-rest-api-specs
b0a5e68 
Dev containerservice microsoft.container service 2021 02 01 (Azure#12771)

* Adds base for updating Microsoft.ContainerService from version stable/2020-12-01 to version 2021-02-01

* Updates readme

* Updates API version in new specs and examples

* aks: generate 2021-02-01 sdk (Azure#12311)

* aks: add `allowNetworkPluginKubenet` field to `ManagedClusterPodIdentityProfile` (Azure#12309)

* aks: add `allowNetworkPluginKubenet` field to `ManagedClusterPodIdentityProfile`

* aks: add pod identity example

* AKS: add fqdnSubdomain for private cluster with custom private dns zone (Azure#12361)

* add fqdnSubdomain for private cluster with custom private dns zone

* add example ref

* fix example

Co-authored-by: Li Ma <[email protected]>

* add new disk choice (Azure#12682)

* AKS: Add Node Public IP Prefix support. (Azure#12673)

* Add azure portal fqdn (Azure#12725)

* add azure portal fqdn

* add azure portal fqdn

* fix prettier

Co-authored-by: Super <[email protected]>
Co-authored-by: Li Ma <[email protected]>
Co-authored-by: Ace Eldeib <[email protected]>
Co-authored-by: Jun Sun <[email protected]>
Co-authored-by: tilnl <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sadasant sadasant

@maorleger maorleger

Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
[2021] March
3 participants
@sadasant @maorleger @heaths